springframework-rcp-dev

[Springframework-rcp-dev] [Spring-JIRA] Created: (RCP-554) TableMasterForm should be able to use SortedList with no comparator

[Benoit X. (JIRA) <no...@sp...>]

TableMasterForm should be able to use SortedList with no comparator
-------------------------------------------------------------------

                 Key: RCP-554
                 URL: http://jira.springframework.org/browse/RCP-554
             Project: Spring Framework Rich Client Project
          Issue Type: Improvement
    Affects Versions: 1.0.0
            Reporter: Benoit Xhenseval


Hi

The AbstractTableMasterForm requires a comparator in order to use the SortedList from GlazedList , this is not necessary and in most case not required.

I would like to suggest the following patch to enable use of sorted list regardless whether a comparator was provided.

I have added a protected method useSortedList() which returns false in the class here so the behaviour is unchanged.
However, It lets us override that method and therefore use the default behaviour for SortedList.

Secondly, I would like to wrap up the configuration of the splitter in a protected method, that way an application can change the size/splitter details by overriding that method.
Once again, the current behaviour is NOT changed by the patch.

I hope that the patch will be accepted.

many thanks

Benoit

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.springframework.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[Springframework-rcp-dev] [Spring-JIRA] Updated: (RCP-554) TableMasterForm should be able to use SortedList with no comparator

[Benoit X. (JIRA) <no...@sp...>]

     [ http://jira.springframework.org/browse/RCP-554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benoit Xhenseval updated RCP-554:
---------------------------------

    Attachment: AbstractTableMasterForm.java.patch

The patch, no impact unless you override useSortedList or configureSplitter.

Thanks for considering it.

That way, we can use Spring Rich Client out of the box!
Benoit

> TableMasterForm should be able to use SortedList with no comparator
> -------------------------------------------------------------------
>
>                 Key: RCP-554
>                 URL: http://jira.springframework.org/browse/RCP-554
>             Project: Spring Framework Rich Client Project
>          Issue Type: Improvement
>    Affects Versions: 1.0.0
>            Reporter: Benoit Xhenseval
>         Attachments: AbstractTableMasterForm.java.patch
>
>
> Hi
> The AbstractTableMasterForm requires a comparator in order to use the SortedList from GlazedList , this is not necessary and in most case not required.
> I would like to suggest the following patch to enable use of sorted list regardless whether a comparator was provided.
> I have added a protected method useSortedList() which returns false in the class here so the behaviour is unchanged.
> However, It lets us override that method and therefore use the default behaviour for SortedList.
> Secondly, I would like to wrap up the configuration of the splitter in a protected method, that way an application can change the size/splitter details by overriding that method.
> Once again, the current behaviour is NOT changed by the patch.
> I hope that the patch will be accepted.
> many thanks
> Benoit

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.springframework.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[Springframework-rcp-dev] [Spring-JIRA] Closed: (RCP-554) TableMasterForm should be able to use SortedList with no comparator

[Jan H. (JIRA) <no...@sp...>]

     [ http://jira.springframework.org/browse/RCP-554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jan Hoskens closed RCP-554.
---------------------------

         Assignee: Jan Hoskens
       Resolution: Fixed
    Fix Version/s: 1.0.1

Changes applied as suggested. 

http://spring-rich-c.svn.sourceforge.net/viewvc/spring-rich-c?view=rev&revision=2043

Thanks for the patch.

> TableMasterForm should be able to use SortedList with no comparator
> -------------------------------------------------------------------
>
>                 Key: RCP-554
>                 URL: http://jira.springframework.org/browse/RCP-554
>             Project: Spring Framework Rich Client Project
>          Issue Type: Improvement
>    Affects Versions: 1.0.0
>            Reporter: Benoit Xhenseval
>            Assignee: Jan Hoskens
>             Fix For: 1.0.1
>
>         Attachments: AbstractTableMasterForm.java.patch
>
>
> Hi
> The AbstractTableMasterForm requires a comparator in order to use the SortedList from GlazedList , this is not necessary and in most case not required.
> I would like to suggest the following patch to enable use of sorted list regardless whether a comparator was provided.
> I have added a protected method useSortedList() which returns false in the class here so the behaviour is unchanged.
> However, It lets us override that method and therefore use the default behaviour for SortedList.
> Secondly, I would like to wrap up the configuration of the splitter in a protected method, that way an application can change the size/splitter details by overriding that method.
> Once again, the current behaviour is NOT changed by the patch.
> I hope that the patch will be accepted.
> many thanks
> Benoit

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.springframework.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira