Menu
▾
▴
springframework-rcp-dev
|
From: Ryan S. (JIRA) <no...@at...> - 2006-09-24 21:04:20
|
Wizard validation fires before reaching step
--------------------------------------------
Key: RCP-406
URL: http://opensource.atlassian.com/projects/spring/browse/RCP-406
Project: Spring Framework Rich Client Project
Type: Bug
Components: Application Framework
Versions: 0.1.0, 0.2.0, 0.2.1
Reporter: Ryan Sonnek
Priority: Critical
Consider this simple scenerio:
1. MyObject has two properties, firstName and lastName.
2. register "required" validator for both properties.
3. for some reason, i built a wizard where the firstName and lastName are on two different steps of the wizard.
4. When launching the wizard, I'm unable to get past the first step because it says one of the properties is required.
This is wrong because I haven't yet got to that step in the wizard to fill in that property.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/spring/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
|
|
From: Ryan S. (JIRA) <no...@at...> - 2006-12-05 14:15:42
|
[ http://opensource.atlassian.com/projects/spring/browse/RCP-406?page=comments#action_21200 ] Ryan Sonnek commented on RCP-406: --------------------------------- here's a blog entry that summarizes the issue as well: http://jroller.com/page/wireframe?entry=wizard_validation > Wizard validation fires before reaching step > -------------------------------------------- > > Key: RCP-406 > URL: http://opensource.atlassian.com/projects/spring/browse/RCP-406 > Project: Spring Framework Rich Client Project > Type: Bug > Components: Application Framework > Versions: 0.1.0, 0.2.0, 0.2.1 > Reporter: Ryan Sonnek > Priority: Critical > > Consider this simple scenerio: > 1. MyObject has two properties, firstName and lastName. > 2. register "required" validator for both properties. > 3. for some reason, i built a wizard where the firstName and lastName are on two different steps of the wizard. > 4. When launching the wizard, I'm unable to get past the first step because it says one of the properties is required. > This is wrong because I haven't yet got to that step in the wizard to fill in that property. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/spring/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
|
From: Jan H. (JIRA) <no...@at...> - 2007-07-10 09:23:57
|
[ http://opensource.atlassian.com/projects/spring/browse/RCP-406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jan Hoskens resolved RCP-406.
-----------------------------
Assignee: Jan Hoskens
Resolution: Fixed
Fix Version/s: 0.3.0
It is possible to have this scenario, but you need to handle this in the correct manner. Each childform has the possibility to have its own validation and will prevent the user to go to the next page while there are errors.
Your case:
- create different childForms for each wizardPage
- assign a different validator for each childForm (first one only validating on firstname, second one only on lastname)
- your wizard contains a compoundForm which combines these childForms so when the dialog's onFinished() method is triggered you can commit the full object and retrieve it from that compoundForm.
It will NOT work if your validation is global, defined on the parentFormModel or whenever rules are defined that work with properties that aren't displayed on that form.
I'm closing this issue, if you think this doesn't cover your case, please reopen. If the given solution isn't clear, drop a mail on the dev list or forum.
> Wizard validation fires before reaching step
> --------------------------------------------
>
> Key: RCP-406
> URL: http://opensource.atlassian.com/projects/spring/browse/RCP-406
> Project: Spring Framework Rich Client Project
> Issue Type: Bug
> Components: Application Framework
> Affects Versions: 0.1.0, 0.2.0, 0.2.1
> Reporter: Ryan Sonnek
> Assignee: Jan Hoskens
> Priority: Critical
> Fix For: 0.3.0
>
>
> Consider this simple scenerio:
> 1. MyObject has two properties, firstName and lastName.
> 2. register "required" validator for both properties.
> 3. for some reason, i built a wizard where the firstName and lastName are on two different steps of the wizard.
> 4. When launching the wizard, I'm unable to get past the first step because it says one of the properties is required.
> This is wrong because I haven't yet got to that step in the wizard to fill in that property.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/spring/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
|
|
From: Ryan S. (JIRA) <no...@at...> - 2007-07-10 13:03:59
|
[ http://opensource.atlassian.com/projects/spring/browse/RCP-406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_24719 ]
Ryan Sonnek commented on RCP-406:
---------------------------------
If spring RCP doesn't support my usecase, that's fine but please don't mark this issue as "fixed".
the workaround you described will work, but it is definitely a workaround and not a feature of the framework. creating child forms for every step of the wizard really defeats the purpose of the wizard and is much more clumsy than i would like.
> Wizard validation fires before reaching step
> --------------------------------------------
>
> Key: RCP-406
> URL: http://opensource.atlassian.com/projects/spring/browse/RCP-406
> Project: Spring Framework Rich Client Project
> Issue Type: Bug
> Components: Application Framework
> Affects Versions: 0.1.0, 0.2.0, 0.2.1
> Reporter: Ryan Sonnek
> Assignee: Jan Hoskens
> Priority: Critical
> Fix For: 0.3.0
>
>
> Consider this simple scenerio:
> 1. MyObject has two properties, firstName and lastName.
> 2. register "required" validator for both properties.
> 3. for some reason, i built a wizard where the firstName and lastName are on two different steps of the wizard.
> 4. When launching the wizard, I'm unable to get past the first step because it says one of the properties is required.
> This is wrong because I haven't yet got to that step in the wizard to fill in that property.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/spring/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
|
|
From: Jan H. (JIRA) <no...@at...> - 2007-07-10 13:37:58
|
[ http://opensource.atlassian.com/projects/spring/browse/RCP-406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_24720 ]
Jan Hoskens commented on RCP-406:
---------------------------------
So you're having a different case than I thought.
Can you give a sample of how you're using the wizard? How do you create your wizardPages?
> Wizard validation fires before reaching step
> --------------------------------------------
>
> Key: RCP-406
> URL: http://opensource.atlassian.com/projects/spring/browse/RCP-406
> Project: Spring Framework Rich Client Project
> Issue Type: Bug
> Components: Application Framework
> Affects Versions: 0.1.0, 0.2.0, 0.2.1
> Reporter: Ryan Sonnek
> Assignee: Jan Hoskens
> Priority: Critical
> Fix For: 0.3.0
>
>
> Consider this simple scenerio:
> 1. MyObject has two properties, firstName and lastName.
> 2. register "required" validator for both properties.
> 3. for some reason, i built a wizard where the firstName and lastName are on two different steps of the wizard.
> 4. When launching the wizard, I'm unable to get past the first step because it says one of the properties is required.
> This is wrong because I haven't yet got to that step in the wizard to fill in that property.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/spring/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
|
|
From: Jan H. (JIRA) <no...@at...> - 2007-07-16 06:54:01
|
[ http://opensource.atlassian.com/projects/spring/browse/RCP-406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jan Hoskens reopened RCP-406:
-----------------------------
Waiting for a more detailed case/sample to illustrate the desired behavior.
> Wizard validation fires before reaching step
> --------------------------------------------
>
> Key: RCP-406
> URL: http://opensource.atlassian.com/projects/spring/browse/RCP-406
> Project: Spring Framework Rich Client Project
> Issue Type: Bug
> Components: Application Framework
> Affects Versions: 0.1.0, 0.2.0, 0.2.1
> Reporter: Ryan Sonnek
> Assignee: Jan Hoskens
> Priority: Critical
> Fix For: 0.3.0
>
>
> Consider this simple scenerio:
> 1. MyObject has two properties, firstName and lastName.
> 2. register "required" validator for both properties.
> 3. for some reason, i built a wizard where the firstName and lastName are on two different steps of the wizard.
> 4. When launching the wizard, I'm unable to get past the first step because it says one of the properties is required.
> This is wrong because I haven't yet got to that step in the wizard to fill in that property.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/spring/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
|
|
From: Jan H. (JIRA) <no...@at...> - 2007-07-20 09:53:59
|
[ http://opensource.atlassian.com/projects/spring/browse/RCP-406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_24904 ]
Jan Hoskens commented on RCP-406:
---------------------------------
My apologies if I closed the issue too soon.
Some things I wanted to know include:
- how do you provide your fields? You don't create multiple forms/formModels?
- when the first name page is showing, should the next button always be enabled? Validation only triggers enabled state of wizards finish button?
- if not (button disabled until firstname filled in), then it seems to me that there needs to be a separate trigger to do that. Normally this would be done by providing a different form for that page. How do you see this?
- what do you expect to have to implement? (what are your annoyances concerning the wizard framework)
Please enlighten me to show how you would expect this to work.
Kind Regards,
Jan
> Wizard validation fires before reaching step
> --------------------------------------------
>
> Key: RCP-406
> URL: http://opensource.atlassian.com/projects/spring/browse/RCP-406
> Project: Spring Framework Rich Client Project
> Issue Type: Bug
> Components: Application Framework
> Affects Versions: 0.1.0, 0.2.0, 0.2.1
> Reporter: Ryan Sonnek
> Assignee: Jan Hoskens
> Priority: Critical
> Fix For: 0.3.0
>
>
> Consider this simple scenerio:
> 1. MyObject has two properties, firstName and lastName.
> 2. register "required" validator for both properties.
> 3. for some reason, i built a wizard where the firstName and lastName are on two different steps of the wizard.
> 4. When launching the wizard, I'm unable to get past the first step because it says one of the properties is required.
> This is wrong because I haven't yet got to that step in the wizard to fill in that property.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/spring/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
|
|
From: Ryan S. (JIRA) <no...@at...> - 2007-07-20 14:40:58
|
[ http://opensource.atlassian.com/projects/spring/browse/RCP-406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_24915 ]
Ryan Sonnek commented on RCP-406:
---------------------------------
It's been almost a year since this was opened, and when I ran into these issues, I basically hopped off of the spring RCP bandwagon. I haven't worked on it since.
If spring-rcp supports my usecase (using whatever code solution), that's great. my current code is here, but my project is opensource if there's anything interesting for you:
https://shard.dev.java.net/source/browse/shard/shard-minotaur/src/main/java/com/codecrate/shard/ui/
{code}
public void addPages() {
addPage(new FormBackedWizardPage(new AbilityScoreForm(getWizardForm().getFormModel())));
addPage(new FormBackedWizardPage(new RaceForm(getWizardForm().getFormModel(), raceDao, alignmentDao)));
addPage(new FormBackedWizardPage(new BioForm(getWizardForm().getFormModel())));
}
{code}
Feel free to take this usecase and run with it. I won't be working with spring-rcp to test any changes to the API.
> Wizard validation fires before reaching step
> --------------------------------------------
>
> Key: RCP-406
> URL: http://opensource.atlassian.com/projects/spring/browse/RCP-406
> Project: Spring Framework Rich Client Project
> Issue Type: Bug
> Components: Application Framework
> Affects Versions: 0.1.0, 0.2.0, 0.2.1
> Reporter: Ryan Sonnek
> Assignee: Jan Hoskens
> Priority: Critical
> Fix For: 0.3.0
>
>
> Consider this simple scenerio:
> 1. MyObject has two properties, firstName and lastName.
> 2. register "required" validator for both properties.
> 3. for some reason, i built a wizard where the firstName and lastName are on two different steps of the wizard.
> 4. When launching the wizard, I'm unable to get past the first step because it says one of the properties is required.
> This is wrong because I haven't yet got to that step in the wizard to fill in that property.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/spring/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
|
|
From: Jan H. (JIRA) <no...@sp...> - 2008-03-18 07:22:08
|
[ http://jira.springframework.org/browse/RCP-406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jan Hoskens updated RCP-406:
----------------------------
Fix Version/s: (was: 1.0.0)
1.0.1
> Wizard validation fires before reaching step
> --------------------------------------------
>
> Key: RCP-406
> URL: http://jira.springframework.org/browse/RCP-406
> Project: Spring Framework Rich Client Project
> Issue Type: Bug
> Components: Application Framework
> Affects Versions: 0.1.0, 0.2.0, 0.2.1
> Reporter: Ryan Sonnek
> Assignee: Jan Hoskens
> Priority: Critical
> Fix For: 1.0.1
>
>
> Consider this simple scenerio:
> 1. MyObject has two properties, firstName and lastName.
> 2. register "required" validator for both properties.
> 3. for some reason, i built a wizard where the firstName and lastName are on two different steps of the wizard.
> 4. When launching the wizard, I'm unable to get past the first step because it says one of the properties is required.
> This is wrong because I haven't yet got to that step in the wizard to fill in that property.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.springframework.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
|
|
From: Lieven D. (JIRA) <no...@sp...> - 2008-10-09 19:16:21
|
[ http://jira.springframework.org/browse/RCP-406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lieven Doclo updated RCP-406:
-----------------------------
Fix Version/s: (was: 1.0.1)
1.0.2
> Wizard validation fires before reaching step
> --------------------------------------------
>
> Key: RCP-406
> URL: http://jira.springframework.org/browse/RCP-406
> Project: Spring Framework Rich Client Project
> Issue Type: Bug
> Components: Application Framework
> Affects Versions: 0.1.0, 0.2.0, 0.2.1
> Reporter: Ryan Sonnek
> Assignee: Jan Hoskens
> Priority: Critical
> Fix For: 1.0.2
>
>
> Consider this simple scenerio:
> 1. MyObject has two properties, firstName and lastName.
> 2. register "required" validator for both properties.
> 3. for some reason, i built a wizard where the firstName and lastName are on two different steps of the wizard.
> 4. When launching the wizard, I'm unable to get past the first step because it says one of the properties is required.
> This is wrong because I haven't yet got to that step in the wizard to fill in that property.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.springframework.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
|
|
From: Lieven D. (JIRA) <no...@sp...> - 2008-10-09 20:07:21
|
[ http://jira.springframework.org/browse/RCP-406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lieven Doclo updated RCP-406:
-----------------------------
Priority: Minor (was: Critical)
Fix Version/s: (was: 1.0.2)
1.x
Issue Type: Task (was: Bug)
> Wizard validation fires before reaching step
> --------------------------------------------
>
> Key: RCP-406
> URL: http://jira.springframework.org/browse/RCP-406
> Project: Spring Framework Rich Client Project
> Issue Type: Task
> Components: Application Framework
> Affects Versions: 0.1.0, 0.2.0, 0.2.1
> Reporter: Ryan Sonnek
> Assignee: Jan Hoskens
> Priority: Minor
> Fix For: 1.x
>
>
> Consider this simple scenerio:
> 1. MyObject has two properties, firstName and lastName.
> 2. register "required" validator for both properties.
> 3. for some reason, i built a wizard where the firstName and lastName are on two different steps of the wizard.
> 4. When launching the wizard, I'm unable to get past the first step because it says one of the properties is required.
> This is wrong because I haven't yet got to that step in the wizard to fill in that property.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.springframework.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
|
Thanks for helping keep SourceForge clean.
X