Menu
▾
▴
springframework-rcp-dev
|
From: Brian R. (JIRA) <no...@at...> - 2006-03-21 16:20:55
|
and access to the control on a CommandGroup
-------------------------------------------
Key: RCP-299
URL: http://opensource.atlassian.com/projects/spring/browse/RCP-299
Project: Spring Framework Rich Client Project
Type: Improvement
Components: Command System
Reporter: Brian Ross
some CommandGroup controls, like the toolbar, only support a very small set of features at this point. Those who wish to add things to the toolbar other than plain buttons need a way to access the control from their code. this involves only a small change to CommandGroup.java, which I will attach.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/spring/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
|
|
From: Brian R. (JIRA) <no...@at...> - 2006-03-21 16:22:48
|
[ http://opensource.atlassian.com/projects/spring/browse/RCP-299?page=all ] Brian Ross updated RCP-299: --------------------------- Attachment: CommandGroup.java > and access to the control on a CommandGroup > ------------------------------------------- > > Key: RCP-299 > URL: http://opensource.atlassian.com/projects/spring/browse/RCP-299 > Project: Spring Framework Rich Client Project > Type: Improvement > Components: Command System > Reporter: Brian Ross > Attachments: CommandGroup.java > > some CommandGroup controls, like the toolbar, only support a very small set of features at this point. Those who wish to add things to the toolbar other than plain buttons need a way to access the control from their code. this involves only a small change to CommandGroup.java, which I will attach. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/spring/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
|
From: Brian R. (JIRA) <no...@at...> - 2006-03-21 16:26:51
|
[ http://opensource.atlassian.com/projects/spring/browse/RCP-299?page=comments#action_16891 ] Brian Ross commented on RCP-299: -------------------------------- Sorry, "add", not "and" > and access to the control on a CommandGroup > ------------------------------------------- > > Key: RCP-299 > URL: http://opensource.atlassian.com/projects/spring/browse/RCP-299 > Project: Spring Framework Rich Client Project > Type: Improvement > Components: Command System > Reporter: Brian Ross > Attachments: CommandGroup.java > > some CommandGroup controls, like the toolbar, only support a very small set of features at this point. Those who wish to add things to the toolbar other than plain buttons need a way to access the control from their code. this involves only a small change to CommandGroup.java, which I will attach. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/spring/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
|
From: Larry S. (JIRA) <no...@at...> - 2006-05-13 15:33:43
|
[ http://opensource.atlassian.com/projects/spring/browse/RCP-299?page=comments#action_17584 ] Larry Streepy commented on RCP-299: ----------------------------------- I don't see how this change accomplishes anything useful. The Component being created by the various createXXX methods is already being returned. The proposed change would not add any new functionality and it would add a temporal coupling between the call to createXXX and the call to getComponent. If you can better describe your specific problem, then maybe a solution can be developed. > and access to the control on a CommandGroup > ------------------------------------------- > > Key: RCP-299 > URL: http://opensource.atlassian.com/projects/spring/browse/RCP-299 > Project: Spring Framework Rich Client Project > Type: Improvement > Components: Command System > Reporter: Brian Ross > Assignee: Larry Streepy > Attachments: CommandGroup.java > > some CommandGroup controls, like the toolbar, only support a very small set of features at this point. Those who wish to add things to the toolbar other than plain buttons need a way to access the control from their code. this involves only a small change to CommandGroup.java, which I will attach. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/spring/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
|
From: Brian R. (JIRA) <no...@at...> - 2006-05-14 03:32:45
|
[ http://opensource.atlassian.com/projects/spring/browse/RCP-299?page=comments#action_17591 ] Brian Ross commented on RCP-299: -------------------------------- The create methods do return the component, however those methods are not called directly by the user's code, but rather internally within the framework during the construction of the main window. The return values are then discarded. Hence, there is no way for the user to get access to the menu bar or the tool bar. By having each command group hold a reference to the component it creates, it's easy to get a hold of it. In my case, from the LifecycleAdvisor I call window.getToolBar().getControl(). If you can think of a better way to accomplish this, I'm okay with that too. This way worked for me and seemed to fit in with the general Spring RCP achitecture as it is similar to the way views work, each one holding its control. > and access to the control on a CommandGroup > ------------------------------------------- > > Key: RCP-299 > URL: http://opensource.atlassian.com/projects/spring/browse/RCP-299 > Project: Spring Framework Rich Client Project > Type: Improvement > Components: Command System > Reporter: Brian Ross > Assignee: Larry Streepy > Attachments: CommandGroup.java > > some CommandGroup controls, like the toolbar, only support a very small set of features at this point. Those who wish to add things to the toolbar other than plain buttons need a way to access the control from their code. this involves only a small change to CommandGroup.java, which I will attach. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/spring/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
|
From: Larry S. (JIRA) <no...@at...> - 2006-05-14 12:52:44
|
[ http://opensource.atlassian.com/projects/spring/browse/RCP-299?page=comments#action_17593 ] Larry Streepy commented on RCP-299: ----------------------------------- The problem with the suggested patch is that it assumes that the command group will only be used to create a single control. However, the general design of the CommandGroup is that it can be rendered into several different control types. Thus, just recording the last control created creates the temporal coupling I mentioned above. If you want to capture the primary controls created for the application window (like the toolbar and menubar), you should look at overriding DefaultApplicationWindow. I'll also look at the possibility of making those components available in the ApplicationWindow interface. > and access to the control on a CommandGroup > ------------------------------------------- > > Key: RCP-299 > URL: http://opensource.atlassian.com/projects/spring/browse/RCP-299 > Project: Spring Framework Rich Client Project > Type: Improvement > Components: Command System > Reporter: Brian Ross > Assignee: Larry Streepy > Attachments: CommandGroup.java > > some CommandGroup controls, like the toolbar, only support a very small set of features at this point. Those who wish to add things to the toolbar other than plain buttons need a way to access the control from their code. this involves only a small change to CommandGroup.java, which I will attach. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/spring/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
|
From: Brian R. (JIRA) <no...@at...> - 2006-05-15 13:52:50
|
[ http://opensource.atlassian.com/projects/spring/browse/RCP-299?page=comments#action_17620 ] Brian Ross commented on RCP-299: -------------------------------- I could override DefaultApplicationWindow, but this seems like something that needs to be available as part of the framework, not custom code. After reading your explanation, I understand the problem with my suggestion. The window would be a better place. The API would be a bit weird though, in that you would have 2 methods, getToolBar() and getToolBarControl(). Perhaps an intermediate object is in order. Instead of instances of JComponent, the create methods could return CommandGroupComponent objects or something, which would give the user access to both the underlying command group and the control created by it. This way, I could call window.getToolBar().getControl() or window.getToolBar().getCommandGroup(). It's a bit cleaner, I think. > and access to the control on a CommandGroup > ------------------------------------------- > > Key: RCP-299 > URL: http://opensource.atlassian.com/projects/spring/browse/RCP-299 > Project: Spring Framework Rich Client Project > Type: Improvement > Components: Command System > Reporter: Brian Ross > Assignee: Larry Streepy > Attachments: CommandGroup.java > > some CommandGroup controls, like the toolbar, only support a very small set of features at this point. Those who wish to add things to the toolbar other than plain buttons need a way to access the control from their code. this involves only a small change to CommandGroup.java, which I will attach. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/spring/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
|
From: Lieven D. (JIRA) <no...@sp...> - 2008-10-09 20:17:19
|
[ http://jira.springframework.org/browse/RCP-299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lieven Doclo resolved RCP-299.
------------------------------
Resolution: Won't Fix
Fix Version/s: 1.0.2
Controls can be added through the factory bean for command groups
> and access to the control on a CommandGroup
> -------------------------------------------
>
> Key: RCP-299
> URL: http://jira.springframework.org/browse/RCP-299
> Project: Spring Framework Rich Client Project
> Issue Type: Improvement
> Components: Command System
> Reporter: Brian Ross
> Assignee: Larry Streepy
> Fix For: 1.0.2
>
> Attachments: CommandGroup.java
>
>
> some CommandGroup controls, like the toolbar, only support a very small set of features at this point. Those who wish to add things to the toolbar other than plain buttons need a way to access the control from their code. this involves only a small change to CommandGroup.java, which I will attach.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.springframework.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
|
Thanks for helping keep SourceForge clean.
X