springframework-rcp-dev

[Springframework-rcp-dev] [Spring-JIRA] Created: (RCP-221) Shadowed logger

[Geoffrey (JIRA) <no...@at...>]

Shadowed logger
---------------

         Key: RCP-221
         URL: http://opensource.atlassian.com/projects/spring/browse/RCP-221
     Project: Spring Framework Rich Client Project
        Type: Bug
  Components: Application Framework  
 Reporter: Geoffrey
 Assigned to: Oliver Hutchison 
    Priority: Trivial


The logger in AbstractControlFactory  shadows the one in ApplicationServicesAccessor:


public abstract class AbstractControlFactory extends ApplicationServicesAccessor implements ControlFactory {

    protected Log logger = LogFactory.getLog(getClass());

    //...
}

public class ApplicationServicesAccessor {
    protected final Log logger = LogFactory.getLog(getClass());

    //...
}


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://opensource.atlassian.com/projects/spring/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[Springframework-rcp-dev] [Spring-JIRA] Updated: (RCP-221) Shadowed logger

[Yudhi W. (JIRA) <no...@at...>]

     [ http://opensource.atlassian.com/projects/spring/browse/RCP-221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Yudhi Widyatama updated RCP-221:
--------------------------------

    Attachment: RCP-221.patch

Won't simply remove the field in the subclass solves this issue? Its already declared protected in the superclass. (Unless we want to allow another subclass to replace the logger..)

> Shadowed logger
> ---------------
>
>                 Key: RCP-221
>                 URL: http://opensource.atlassian.com/projects/spring/browse/RCP-221
>             Project: Spring Framework Rich Client Project
>          Issue Type: Bug
>          Components: Application Framework
>            Reporter: Geoffrey De Smet
>            Assignee: Oliver Hutchison
>            Priority: Trivial
>         Attachments: RCP-221.patch
>
>
> The logger in AbstractControlFactory  shadows the one in ApplicationServicesAccessor:
> public abstract class AbstractControlFactory extends ApplicationServicesAccessor implements ControlFactory {
>     protected Log logger = LogFactory.getLog(getClass());
>     //...
> }
> public class ApplicationServicesAccessor {
>     protected final Log logger = LogFactory.getLog(getClass());
>     //...
> }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/spring/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[Springframework-rcp-dev] [Spring-JIRA] Resolved: (RCP-221) Shadowed logger

[Kevin S. (JIRA) <no...@at...>]

     [ http://opensource.atlassian.com/projects/spring/browse/RCP-221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kevin Stembridge resolved RCP-221.
----------------------------------

       Resolution: Fixed
    Fix Version/s: 0.3.0

Patch applied. Thanks Yudhi.

> Shadowed logger
> ---------------
>
>                 Key: RCP-221
>                 URL: http://opensource.atlassian.com/projects/spring/browse/RCP-221
>             Project: Spring Framework Rich Client Project
>          Issue Type: Bug
>          Components: Application Framework
>            Reporter: Geoffrey De Smet
>            Assignee: Kevin Stembridge
>            Priority: Trivial
>             Fix For: 0.3.0
>
>         Attachments: RCP-221.patch
>
>
> The logger in AbstractControlFactory  shadows the one in ApplicationServicesAccessor:
> public abstract class AbstractControlFactory extends ApplicationServicesAccessor implements ControlFactory {
>     protected Log logger = LogFactory.getLog(getClass());
>     //...
> }
> public class ApplicationServicesAccessor {
>     protected final Log logger = LogFactory.getLog(getClass());
>     //...
> }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/spring/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira