springframework-rcp-dev

[Springframework-rcp-dev] [Spring-JIRA] Updated: (RCP-165) Eliminate need for special bean names when configuring Application and ApplicationServices

[Jan H. (JIRA) <no...@at...>]

     [ http://opensource.atlassian.com/projects/spring/browse/RCP-165?page=all ]

Jan Hoskens updated RCP-165:
----------------------------

    Fix Version:     (was: 0.2.0)
                 0.3.0

> Eliminate need for special bean names when configuring Application and ApplicationServices
> ------------------------------------------------------------------------------------------
>
>          Key: RCP-165
>          URL: http://opensource.atlassian.com/projects/spring/browse/RCP-165
>      Project: Spring Framework Rich Client Project
>         Type: Improvement

>     Reporter: Oliver Hutchison
>     Assignee: Oliver Hutchison
>      Fix For: 0.3.0

>
> We should totally eliminate the special bean names that are required when configuring the Application and ApplicationServices singletons. Both these classes should be configurable using DI.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://opensource.atlassian.com/projects/spring/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[Springframework-rcp-dev] [Spring-JIRA] Updated: (RCP-165) Eliminate need for special bean names when configuring Application and ApplicationServices

[Arne L. (JIRA) <no...@at...>]

     [ http://opensource.atlassian.com/projects/spring/browse/RCP-165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arne Limburg updated RCP-165:
-----------------------------

    Attachment: Application.java.patch

This patch enables a spring-richclient application to start without an image-source configured.
It catches the NoSuchImageResourceException in getImage() if no such source is configured.

> Eliminate need for special bean names when configuring Application and ApplicationServices
> ------------------------------------------------------------------------------------------
>
>                 Key: RCP-165
>                 URL: http://opensource.atlassian.com/projects/spring/browse/RCP-165
>             Project: Spring Framework Rich Client Project
>          Issue Type: Improvement
>            Reporter: Oliver Hutchison
>            Assignee: Oliver Hutchison
>             Fix For: 0.3.0
>
>         Attachments: Application.java.patch
>
>
> We should totally eliminate the special bean names that are required when configuring the Application and ApplicationServices singletons. Both these classes should be configurable using DI.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/spring/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[Springframework-rcp-dev] [Spring-JIRA] Updated: (RCP-165) Eliminate need for special bean names when configuring Application and ApplicationServices

[Arne L. (JIRA) <no...@at...>]

     [ http://opensource.atlassian.com/projects/spring/browse/RCP-165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arne Limburg updated RCP-165:
-----------------------------

    Attachment: RCP-165.patch

I have taken a closer look at the task of providing a nice default configuration for spring-richclient.

With my changes (applied in the second patch above) a spring-richclient-application is able to start up without configuring anything. The application context can look like:

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE beans PUBLIC "-//SPRING//DTD BEAN//EN" "http://www.springframework.org/dtd/spring-beans.dtd">
<beans>
    <bean id="application" class="org.springframework.richclient.application.Application"/>
</beans>

A spring-richclient application is even able to start without an application context this way:

Application application = new Application();
application.afterPropertiesSet();
application.start();

This is what I did:

1. Added a default constructor to Application, that creates a DefaultApplicationLifecycleAdvisor
2. Removed the assertion in afterPropertiesSet of ApplicationLifecycleAdvisor, that checks if the startingPageId is set  (I don't need the startingPageId to be set any more, if the developer wants to start with an empty page, why not?)
3. Added code to openWindow of Application to handle null pageDescriptorId (i.e. startingPageId)
4. Setting a default-location for the windowCommandBarDefinitions in DefaultApplicationLifecycleAdvisor. I created a default-commands-context for this.
5. Added a check in Application.services() wether the ApplicationServicesLocator-singleton is initialized (for this I added the method isLoaded in ApplicationServicesLocator). If it is not, it will be initialized there with DefaultApplicationServices.
6. Fixed a bug in getImage of Application leading to an Exception when no application-image is configured.
7. Changed imageSourceImplBuilder, messageSourceImplBuilder and applicationObjectConfigurerImplBuilder in DefaultApplicationServices to use org/springframework/richclient/image/images.properties and org/springframework/richclient/application/messages.properties as default. For this I had to change getApplicationContext in DefaultApplicationServices to always return a non-null (but empty) application-context to avoid a NullPointerException when accessing the application-context.
8. At the last I added newCommand.label and newCommand.caption to messages.properties and newCommand.icon, saveCommand.icon, printCommand.icon and propertiesCommand.icon to images.properties to support my commands-context

> Eliminate need for special bean names when configuring Application and ApplicationServices
> ------------------------------------------------------------------------------------------
>
>                 Key: RCP-165
>                 URL: http://opensource.atlassian.com/projects/spring/browse/RCP-165
>             Project: Spring Framework Rich Client Project
>          Issue Type: Improvement
>            Reporter: Oliver Hutchison
>            Assignee: Oliver Hutchison
>             Fix For: 0.3.0
>
>         Attachments: Application.java.patch, RCP-165.patch
>
>
> We should totally eliminate the special bean names that are required when configuring the Application and ApplicationServices singletons. Both these classes should be configurable using DI.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/spring/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[Springframework-rcp-dev] [Spring-JIRA] Updated: (RCP-165) Eliminate need for special bean names when configuring Application and ApplicationServices

[Arne L. (JIRA) <no...@at...>]

     [ http://opensource.atlassian.com/projects/spring/browse/RCP-165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arne Limburg updated RCP-165:
-----------------------------

    Attachment: RCP-165.patch

> Eliminate need for special bean names when configuring Application and ApplicationServices
> ------------------------------------------------------------------------------------------
>
>                 Key: RCP-165
>                 URL: http://opensource.atlassian.com/projects/spring/browse/RCP-165
>             Project: Spring Framework Rich Client Project
>          Issue Type: Improvement
>            Reporter: Oliver Hutchison
>            Assignee: Jan Hoskens
>             Fix For: 0.3.0
>
>         Attachments: Application.java.patch, RCP-165.patch, RCP-165.patch
>
>
> We should totally eliminate the special bean names that are required when configuring the Application and ApplicationServices singletons. Both these classes should be configurable using DI.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/spring/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[Springframework-rcp-dev] [Spring-JIRA] Updated: (RCP-165) Eliminate need for special bean names when configuring Application and ApplicationServices

[Arne L. (JIRA) <no...@at...>]

     [ http://opensource.atlassian.com/projects/spring/browse/RCP-165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arne Limburg updated RCP-165:
-----------------------------

    Attachment: RCP-165.patch

> Eliminate need for special bean names when configuring Application and ApplicationServices
> ------------------------------------------------------------------------------------------
>
>                 Key: RCP-165
>                 URL: http://opensource.atlassian.com/projects/spring/browse/RCP-165
>             Project: Spring Framework Rich Client Project
>          Issue Type: Improvement
>            Reporter: Oliver Hutchison
>            Assignee: Jan Hoskens
>             Fix For: 0.3.0
>
>         Attachments: Application.java.patch, RCP-165.patch, RCP-165.patch, RCP-165.patch
>
>
> We should totally eliminate the special bean names that are required when configuring the Application and ApplicationServices singletons. Both these classes should be configurable using DI.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/spring/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira