Menu
▾
▴
springframework-rcp-dev
|
From: Geoffrey De S. (JIRA) <no...@at...> - 2006-01-20 08:54:42
|
ComboBoxAutoCompletionInterceptorFactory shouldn't use hardcoded "instanceof LabeledEnumListRenderer" etc
---------------------------------------------------------------------------------------------------------
Key: RCP-266
URL: http://opensource.atlassian.com/projects/spring/browse/RCP-266
Project: Spring Framework Rich Client Project
Type: Bug
Components: Binding System
Reporter: Geoffrey De Smet
Assigned to: Oliver Hutchison
Priority: Minor
I wrote a "TigerEnumComboBoxBinder" for 1.5 enum, which works mainly because it can do:
ComboBoxBinding binding = (ComboBoxBinding)super.doBind(control, formModel, formPropertyPath, context);
binding.setSelectableItemsHolder(createEnumSelectableItemsHolder(formModel, formPropertyPath));
binding.setRenderer(createEnumRenderer());
Yet there the ComboBoxAutoCompletionInterceptorFactory does something more on other combobox bindings, it checks with an instanceof and adds interceptors hardcoded.
I believe it should be able to set the interceptors on the binding and use those.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/spring/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
|
|
From: Geoffrey De S. (JIRA) <no...@at...> - 2006-01-20 10:59:41
|
[ http://opensource.atlassian.com/projects/spring/browse/RCP-266?page=all ] Geoffrey De Smet updated RCP-266: --------------------------------- Attachment: spring-richclient-patch-RCP-266.zip The real issue is that bindings can set renderers but not editors. So I fixed that, patch attached. Just unzip it in the springrich root, take a look at the differences and commit it. > ComboBoxAutoCompletionInterceptorFactory shouldn't use hardcoded "instanceof LabeledEnumListRenderer" etc > --------------------------------------------------------------------------------------------------------- > > Key: RCP-266 > URL: http://opensource.atlassian.com/projects/spring/browse/RCP-266 > Project: Spring Framework Rich Client Project > Type: Bug > Components: Binding System > Reporter: Geoffrey De Smet > Assignee: Oliver Hutchison > Priority: Minor > Attachments: spring-richclient-patch-RCP-266.zip > > I wrote a "TigerEnumComboBoxBinder" for 1.5 enum, which works mainly because it can do: > ComboBoxBinding binding = (ComboBoxBinding)super.doBind(control, formModel, formPropertyPath, context); > binding.setSelectableItemsHolder(createEnumSelectableItemsHolder(formModel, formPropertyPath)); > binding.setRenderer(createEnumRenderer()); > Yet there the ComboBoxAutoCompletionInterceptorFactory does something more on other combobox bindings, it checks with an instanceof and adds interceptors hardcoded. > I believe it should be able to set the interceptors on the binding and use those. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/spring/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
|
From: Geoffrey De S. (JIRA) <no...@at...> - 2006-01-20 11:04:44
|
[ http://opensource.atlassian.com/projects/spring/browse/RCP-266?page=comments#action_16114 ] Geoffrey De Smet commented on RCP-266: -------------------------------------- The original description is wrong by the way: Not interceptors should be addable, but editors, because renderers are already addable. I did the following things: - allowed editors to be added to a comboboxbinding, in the same way like a renderer - removed the hardcoded instanceof LabeledEnumListRenderer in the intercept where the editors used to be added - added the editors in the same place where the renderers get added. > ComboBoxAutoCompletionInterceptorFactory shouldn't use hardcoded "instanceof LabeledEnumListRenderer" etc > --------------------------------------------------------------------------------------------------------- > > Key: RCP-266 > URL: http://opensource.atlassian.com/projects/spring/browse/RCP-266 > Project: Spring Framework Rich Client Project > Type: Bug > Components: Binding System > Reporter: Geoffrey De Smet > Assignee: Oliver Hutchison > Priority: Minor > Attachments: spring-richclient-patch-RCP-266.zip > > I wrote a "TigerEnumComboBoxBinder" for 1.5 enum, which works mainly because it can do: > ComboBoxBinding binding = (ComboBoxBinding)super.doBind(control, formModel, formPropertyPath, context); > binding.setSelectableItemsHolder(createEnumSelectableItemsHolder(formModel, formPropertyPath)); > binding.setRenderer(createEnumRenderer()); > Yet there the ComboBoxAutoCompletionInterceptorFactory does something more on other combobox bindings, it checks with an instanceof and adds interceptors hardcoded. > I believe it should be able to set the interceptors on the binding and use those. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/spring/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
|
From: Geoffrey De S. (JIRA) <no...@at...> - 2006-01-20 11:17:43
|
[ http://opensource.atlassian.com/projects/spring/browse/RCP-266?page=all ] Geoffrey De Smet updated RCP-266: --------------------------------- Attachment: spring-richclient-patch-RCP-266.zip Bug fix on orginal patch with the beanproperty combobox assert Ignore the older patch > ComboBoxAutoCompletionInterceptorFactory shouldn't use hardcoded "instanceof LabeledEnumListRenderer" etc > --------------------------------------------------------------------------------------------------------- > > Key: RCP-266 > URL: http://opensource.atlassian.com/projects/spring/browse/RCP-266 > Project: Spring Framework Rich Client Project > Type: Bug > Components: Binding System > Reporter: Geoffrey De Smet > Assignee: Oliver Hutchison > Priority: Minor > Attachments: spring-richclient-patch-RCP-266.zip, spring-richclient-patch-RCP-266.zip > > I wrote a "TigerEnumComboBoxBinder" for 1.5 enum, which works mainly because it can do: > ComboBoxBinding binding = (ComboBoxBinding)super.doBind(control, formModel, formPropertyPath, context); > binding.setSelectableItemsHolder(createEnumSelectableItemsHolder(formModel, formPropertyPath)); > binding.setRenderer(createEnumRenderer()); > Yet there the ComboBoxAutoCompletionInterceptorFactory does something more on other combobox bindings, it checks with an instanceof and adds interceptors hardcoded. > I believe it should be able to set the interceptors on the binding and use those. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/spring/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
|
From: Peter De B. (JIRA) <no...@at...> - 2007-11-30 11:32:17
|
[ http://opensource.atlassian.com/projects/spring/browse/RCP-266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Peter De Bruycker resolved RCP-266.
-----------------------------------
Assignee: Peter De Bruycker (was: Oliver Hutchison)
Resolution: Fixed
was already fixed
> ComboBoxAutoCompletionInterceptorFactory shouldn't use hardcoded "instanceof LabeledEnumListRenderer" etc
> ---------------------------------------------------------------------------------------------------------
>
> Key: RCP-266
> URL: http://opensource.atlassian.com/projects/spring/browse/RCP-266
> Project: Spring Framework Rich Client Project
> Issue Type: Bug
> Components: Binding System
> Reporter: Geoffrey De Smet
> Assignee: Peter De Bruycker
> Priority: Minor
> Attachments: spring-richclient-patch-RCP-266.zip, spring-richclient-patch-RCP-266.zip
>
>
> I wrote a "TigerEnumComboBoxBinder" for 1.5 enum, which works mainly because it can do:
> ComboBoxBinding binding = (ComboBoxBinding)super.doBind(control, formModel, formPropertyPath, context);
> binding.setSelectableItemsHolder(createEnumSelectableItemsHolder(formModel, formPropertyPath));
> binding.setRenderer(createEnumRenderer());
> Yet there the ComboBoxAutoCompletionInterceptorFactory does something more on other combobox bindings, it checks with an instanceof and adds interceptors hardcoded.
> I believe it should be able to set the interceptors on the binding and use those.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/spring/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
|
Thanks for helping keep SourceForge clean.
X