Menu
▾
▴
springframework-rcp-dev
|
From: Jonny W. (JIRA) <no...@at...> - 2007-12-18 02:25:22
|
Improve configurability of toolbar creation
-------------------------------------------
Key: RCP-508
URL: http://opensource.atlassian.com/projects/spring/browse/RCP-508
Project: Spring Framework Rich Client Project
Issue Type: Improvement
Components: Command System
Affects Versions: 0.2.1
Reporter: Jonny Wray
In attempting to integrate the Jide action framework into Spring RCP I've come across a number of places where the configuration of the toolbars could be improved.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/spring/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
|
|
From: Jonny W. (JIRA) <no...@at...> - 2007-12-18 02:36:15
|
[ http://opensource.atlassian.com/projects/spring/browse/RCP-508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonny Wray updated RCP-508:
---------------------------
Attachment: spring-rcp-support.patch
The attached patch contains a number of changes related to improving the configuration of the tool-bar, and buttons in them.
* The ButtonFactory interface was changed to return AbstractButton in a couple of methods. This allows alternative implementations to not have to override the Swing concrete classes. All cascading changes (eg DefaultButtonFactory) have also been made.
* The CommandGroup now uses the ComponentFactory, exposed via CommandServices, to construct the tool-bar. The createToolBar method was recently added to ComponentFactory but wasn't been used as far as I could tell. The type returned from the component factory was changed from JToolBar to JComponent, again allowing for conceptual tool-bar components that don't override JToolBar.
* The concept of a tool-bar specific button factory was introduced to the command services, and is used for tool-bar construction in the command group. If a tool-bar specific button factory is not specified in the command services it defaults to the regular button factory.
Non of these changes should effect existing applications unless they are overriding default implementations of the interfaces that have changed.
> Improve configurability of toolbar creation
> -------------------------------------------
>
> Key: RCP-508
> URL: http://opensource.atlassian.com/projects/spring/browse/RCP-508
> Project: Spring Framework Rich Client Project
> Issue Type: Improvement
> Components: Command System
> Affects Versions: 0.2.1
> Reporter: Jonny Wray
> Attachments: spring-rcp-support.patch
>
>
> In attempting to integrate the Jide action framework into Spring RCP I've come across a number of places where the configuration of the toolbars could be improved.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/spring/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
|
|
From: Jonny W. (JIRA) <no...@sp...> - 2008-02-02 20:42:47
|
[ http://jira.springframework.org/browse/RCP-508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonny Wray updated RCP-508:
---------------------------
Attachment: spring-rcp-support-relative.patch.txt
While attempting to apply this patch of mine to a new check out I released it had hardcoded, absolute directory references in it. I added a new one, with the relative suffix, that contains relative directory paths
> Improve configurability of toolbar creation
> -------------------------------------------
>
> Key: RCP-508
> URL: http://jira.springframework.org/browse/RCP-508
> Project: Spring Framework Rich Client Project
> Issue Type: Improvement
> Components: Command System
> Affects Versions: 0.2.1
> Reporter: Jonny Wray
> Assignee: Peter De Bruycker
> Attachments: spring-rcp-support-relative.patch.txt, spring-rcp-support.patch
>
>
> In attempting to integrate the Jide action framework into Spring RCP I've come across a number of places where the configuration of the toolbars could be improved.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.springframework.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
|
|
From: Jan H. (JIRA) <no...@sp...> - 2008-02-26 10:11:24
|
[ http://jira.springframework.org/browse/RCP-508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_32512 ]
Jan Hoskens commented on RCP-508:
---------------------------------
I'm going to change the return type of all methods in the ButtonFactory to AbstractButton. JCheckBox and JRadioButton both may have a custom implementation that don't extend them.
> Improve configurability of toolbar creation
> -------------------------------------------
>
> Key: RCP-508
> URL: http://jira.springframework.org/browse/RCP-508
> Project: Spring Framework Rich Client Project
> Issue Type: Improvement
> Components: Command System
> Affects Versions: 0.2.1
> Reporter: Jonny Wray
> Assignee: Peter De Bruycker
> Attachments: spring-rcp-support-relative.patch.txt, spring-rcp-support.patch
>
>
> In attempting to integrate the Jide action framework into Spring RCP I've come across a number of places where the configuration of the toolbars could be improved.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.springframework.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
|
|
From: Nils O. (JIRA) <no...@sp...> - 2008-03-02 10:41:07
|
[ http://jira.springframework.org/browse/RCP-508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_32722 ]
Nils Olsson commented on RCP-508:
---------------------------------
Hi (I just noticed this jira issue)
I was in a need for a more advanced toolbar, so I search the forum but I didn't find any solution so I made my own [RCP-542]. I don't know if that solution gets obsolete when this patch is applied or if the combination of the patches will make the handling of the toolbar even more developer friendly, maybe you guys can have a look.
> Improve configurability of toolbar creation
> -------------------------------------------
>
> Key: RCP-508
> URL: http://jira.springframework.org/browse/RCP-508
> Project: Spring Framework Rich Client Project
> Issue Type: Improvement
> Components: Command System
> Affects Versions: 0.2.1
> Reporter: Jonny Wray
> Assignee: Peter De Bruycker
> Attachments: spring-rcp-support-relative.patch.txt, spring-rcp-support.patch
>
>
> In attempting to integrate the Jide action framework into Spring RCP I've come across a number of places where the configuration of the toolbars could be improved.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.springframework.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
|
|
From: Jan H. (JIRA) <no...@sp...> - 2008-03-06 12:21:09
|
[ http://jira.springframework.org/browse/RCP-508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jan Hoskens closed RCP-508.
---------------------------
Assignee: Jan Hoskens (was: Peter De Bruycker)
Resolution: Fixed
Fix Version/s: 1.0.0
Fixed in
http://spring-rich-c.svn.sourceforge.net/spring-rich-c/?rev=1998&view=rev
Thanks for the patch
> Improve configurability of toolbar creation
> -------------------------------------------
>
> Key: RCP-508
> URL: http://jira.springframework.org/browse/RCP-508
> Project: Spring Framework Rich Client Project
> Issue Type: Improvement
> Components: Command System
> Affects Versions: 0.2.1
> Reporter: Jonny Wray
> Assignee: Jan Hoskens
> Fix For: 1.0.0
>
> Attachments: spring-rcp-support-relative.patch.txt, spring-rcp-support.patch
>
>
> In attempting to integrate the Jide action framework into Spring RCP I've come across a number of places where the configuration of the toolbars could be improved.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.springframework.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
|
Thanks for helping keep SourceForge clean.
X