springframework-rcp-dev

[Springframework-rcp-dev] [Spring-JIRA] Created: (RCP-483) missing to remove view from ApplicationEventMulticaster when view is closed

[Christian H. (JIRA) <no...@at...>]

missing to remove view from ApplicationEventMulticaster when view is closed
---------------------------------------------------------------------------

                 Key: RCP-483
                 URL: http://opensource.atlassian.com/projects/spring/browse/RCP-483
             Project: Spring Framework Rich Client Project
          Issue Type: Bug
          Components: Application Framework
            Reporter: Christian Heilmann
            Priority: Critical


In DefaultViewDescriptor.createView() the view is added to the ApplicationEventMulticaster (ApplicationEventMulticaster.addApplicationListener(view)) as Listener.
But when closing the view, it is missing to remove the view from the ApplicationEventMulticaster (ApplicationEventMulticaster.removeApplicationListener(view)).

Please remove the view from the ApplicationEventMulticaster when it is closed.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/spring/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[Springframework-rcp-dev] [Spring-JIRA] Commented: (RCP-483) missing to remove view from ApplicationEventMulticaster when view is closed

[Peter De B. (JIRA) <no...@at...>]

    [ http://opensource.atlassian.com/projects/spring/browse/RCP-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_26518 ] 

Peter De Bruycker commented on RCP-483:
---------------------------------------

if we add code to remove the view from the ApplicationEventMulticaster, the best place would be AbstractApplicationPage.

The code to add the view as an application listener is in DefaultViewDescriptor.createView method.

Wouldn't it be better if this code is also moved to AbstractApplicationPage (i.e. the createPageComponent method)?

> missing to remove view from ApplicationEventMulticaster when view is closed
> ---------------------------------------------------------------------------
>
>                 Key: RCP-483
>                 URL: http://opensource.atlassian.com/projects/spring/browse/RCP-483
>             Project: Spring Framework Rich Client Project
>          Issue Type: Bug
>          Components: Application Framework
>            Reporter: Christian Heilmann
>            Priority: Critical
>
> In DefaultViewDescriptor.createView() the view is added to the ApplicationEventMulticaster (ApplicationEventMulticaster.addApplicationListener(view)) as Listener.
> But when closing the view, it is missing to remove the view from the ApplicationEventMulticaster (ApplicationEventMulticaster.removeApplicationListener(view)).
> Please remove the view from the ApplicationEventMulticaster when it is closed.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/spring/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[Springframework-rcp-dev] [Spring-JIRA] Commented: (RCP-483) missing to remove view from ApplicationEventMulticaster when view is closed

[Christian H. (JIRA) <no...@at...>]

    [ http://opensource.atlassian.com/projects/spring/browse/RCP-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_27916 ] 

Christian Heilmann commented on RCP-483:
----------------------------------------

Please put the following code in to fix it:

 AbstractApplicationPage.close(PageComponent pageComponent) {
...
        ApplicationEventMulticaster aem = getApplicationEventMulticaster();
        if (aem != null && pageComponent instanceof ApplicationListener) {
            aem.removeApplicationListener((ApplicationListener) pageComponent);
        }
...
}

protected ApplicationEventMulticaster getApplicationEventMulticaster() {
        if (getApplicationContext() != null) {
            final String beanName = AbstractApplicationContext.APPLICATION_EVENT_MULTICASTER_BEAN_NAME;
            if (getApplicationContext().containsBean(beanName)) {
                return (ApplicationEventMulticaster) getApplicationContext().getBean(beanName);
            }
        }
        return null;
    }

> missing to remove view from ApplicationEventMulticaster when view is closed
> ---------------------------------------------------------------------------
>
>                 Key: RCP-483
>                 URL: http://opensource.atlassian.com/projects/spring/browse/RCP-483
>             Project: Spring Framework Rich Client Project
>          Issue Type: Bug
>          Components: Application Framework
>            Reporter: Christian Heilmann
>            Priority: Critical
>
> In DefaultViewDescriptor.createView() the view is added to the ApplicationEventMulticaster (ApplicationEventMulticaster.addApplicationListener(view)) as Listener.
> But when closing the view, it is missing to remove the view from the ApplicationEventMulticaster (ApplicationEventMulticaster.removeApplicationListener(view)).
> Please remove the view from the ApplicationEventMulticaster when it is closed.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/spring/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[Springframework-rcp-dev] [Spring-JIRA] Closed: (RCP-483) missing to remove view from ApplicationEventMulticaster when view is closed

[Jan H. (JIRA) <no...@at...>]

     [ http://opensource.atlassian.com/projects/spring/browse/RCP-483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jan Hoskens closed RCP-483.
---------------------------

         Assignee: Jan Hoskens
       Resolution: Fixed
    Fix Version/s: 0.3.0

Moved adding of listener to AbstractApplicationPage.createPageComponent
Added removing of listener in AbstractApplicationPage.close(PageComponent)

http://spring-rich-c.svn.sourceforge.net/viewvc/spring-rich-c?view=rev&revision=1866

> missing to remove view from ApplicationEventMulticaster when view is closed
> ---------------------------------------------------------------------------
>
>                 Key: RCP-483
>                 URL: http://opensource.atlassian.com/projects/spring/browse/RCP-483
>             Project: Spring Framework Rich Client Project
>          Issue Type: Bug
>          Components: Application Framework
>            Reporter: Christian Heilmann
>            Assignee: Jan Hoskens
>            Priority: Critical
>             Fix For: 0.3.0
>
>
> In DefaultViewDescriptor.createView() the view is added to the ApplicationEventMulticaster (ApplicationEventMulticaster.addApplicationListener(view)) as Listener.
> But when closing the view, it is missing to remove the view from the ApplicationEventMulticaster (ApplicationEventMulticaster.removeApplicationListener(view)).
> Please remove the view from the ApplicationEventMulticaster when it is closed.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/spring/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira