Menu
▾
▴
springframework-rcp-dev
|
From: Benoit X. (JIRA) <no...@at...> - 2007-09-27 15:08:39
|
Issue in ExtTabbedPane if the title change for a Tab placed after an invisible one
----------------------------------------------------------------------------------
Key: RCP-490
URL: http://opensource.atlassian.com/projects/spring/browse/RCP-490
Project: Spring Framework Rich Client Project
Issue Type: Bug
Reporter: Benoit Xhenseval
Attachments: ExtTabbedPane-patch.txt
Hi,
This is probably something for Peter.
I'm using the TabbedDialogPage and ExtTabbedPane (cheers Peter) and I think that I've found a bug.
When the title changes (say due to a page complete event), the propertyChangeHandler is called in ExtTabbedPane and this is use to call:
tabbedPane.setTitleAt(index,...)
Unfortunately, the index is incorrect if the Tab is placed after an invisible tab. The index should be determined calling the method determineUIIndex(tab).
I will suggest a patch which would only change the title/icon etc if the tab is visible and use the correct index.
I'd be grateful if you could consider it.
Many thanks
Benoit
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/spring/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
|
|
From: Benoit X. (JIRA) <no...@at...> - 2007-09-27 15:08:39
|
[ http://opensource.atlassian.com/projects/spring/browse/RCP-490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benoit Xhenseval updated RCP-490:
---------------------------------
Attachment: ExtTabbedPane-patch.txt
The suggested patch.
Thanks!
> Issue in ExtTabbedPane if the title change for a Tab placed after an invisible one
> ----------------------------------------------------------------------------------
>
> Key: RCP-490
> URL: http://opensource.atlassian.com/projects/spring/browse/RCP-490
> Project: Spring Framework Rich Client Project
> Issue Type: Bug
> Reporter: Benoit Xhenseval
> Attachments: ExtTabbedPane-patch.txt
>
>
> Hi,
> This is probably something for Peter.
> I'm using the TabbedDialogPage and ExtTabbedPane (cheers Peter) and I think that I've found a bug.
> When the title changes (say due to a page complete event), the propertyChangeHandler is called in ExtTabbedPane and this is use to call:
> tabbedPane.setTitleAt(index,...)
> Unfortunately, the index is incorrect if the Tab is placed after an invisible tab. The index should be determined calling the method determineUIIndex(tab).
> I will suggest a patch which would only change the title/icon etc if the tab is visible and use the correct index.
> I'd be grateful if you could consider it.
> Many thanks
> Benoit
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/spring/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
|
|
From: Benoit X. (JIRA) <no...@at...> - 2007-09-27 15:52:36
|
[ http://opensource.atlassian.com/projects/spring/browse/RCP-490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_26495 ]
Benoit Xhenseval commented on RCP-490:
--------------------------------------
While I'm at it... I'd like to suggest adding the following method to the TabbedDialogPage.java
protected Tab getTab(final DialogPage page) {
return (Tab) page2tab.get(page);
}
That way a subclass could get access to the Tab if required (eg to show title in bold in the decorateTitle if selected).
> Issue in ExtTabbedPane if the title change for a Tab placed after an invisible one
> ----------------------------------------------------------------------------------
>
> Key: RCP-490
> URL: http://opensource.atlassian.com/projects/spring/browse/RCP-490
> Project: Spring Framework Rich Client Project
> Issue Type: Bug
> Reporter: Benoit Xhenseval
> Attachments: ExtTabbedPane-patch.txt
>
>
> Hi,
> This is probably something for Peter.
> I'm using the TabbedDialogPage and ExtTabbedPane (cheers Peter) and I think that I've found a bug.
> When the title changes (say due to a page complete event), the propertyChangeHandler is called in ExtTabbedPane and this is use to call:
> tabbedPane.setTitleAt(index,...)
> Unfortunately, the index is incorrect if the Tab is placed after an invisible tab. The index should be determined calling the method determineUIIndex(tab).
> I will suggest a patch which would only change the title/icon etc if the tab is visible and use the correct index.
> I'd be grateful if you could consider it.
> Many thanks
> Benoit
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/spring/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
|
|
From: Peter De B. (JIRA) <no...@at...> - 2007-09-28 06:01:38
|
[ http://opensource.atlassian.com/projects/spring/browse/RCP-490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Peter De Bruycker resolved RCP-490.
-----------------------------------
Resolution: Fixed
patch applied
> Issue in ExtTabbedPane if the title change for a Tab placed after an invisible one
> ----------------------------------------------------------------------------------
>
> Key: RCP-490
> URL: http://opensource.atlassian.com/projects/spring/browse/RCP-490
> Project: Spring Framework Rich Client Project
> Issue Type: Bug
> Reporter: Benoit Xhenseval
> Assignee: Peter De Bruycker
> Attachments: ExtTabbedPane-patch.txt
>
>
> Hi,
> This is probably something for Peter.
> I'm using the TabbedDialogPage and ExtTabbedPane (cheers Peter) and I think that I've found a bug.
> When the title changes (say due to a page complete event), the propertyChangeHandler is called in ExtTabbedPane and this is use to call:
> tabbedPane.setTitleAt(index,...)
> Unfortunately, the index is incorrect if the Tab is placed after an invisible tab. The index should be determined calling the method determineUIIndex(tab).
> I will suggest a patch which would only change the title/icon etc if the tab is visible and use the correct index.
> I'd be grateful if you could consider it.
> Many thanks
> Benoit
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/spring/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
|
Thanks for helping keep SourceForge clean.
X