springframework-rcp-dev — Spring Rich Client developer list

[Springframework-rcp-dev] [Spring-JIRA] Updated: (RCP-541) ButtonFactory should return AbstractButton

[Johannes S. (JIRA) <no...@sp...>]

     [ http://jira.springframework.org/browse/RCP-541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Johannes Schneider updated RCP-541:
-----------------------------------

    Attachment: Button.patch

> ButtonFactory should return AbstractButton
> ------------------------------------------
>
>                 Key: RCP-541
>                 URL: http://jira.springframework.org/browse/RCP-541
>             Project: Spring Framework Rich Client Project
>          Issue Type: Improvement
>          Components: Binding System
>    Affects Versions: 1.0.0
>            Reporter: Johannes Schneider
>         Attachments: Button.patch
>
>
> org.springframework.richclient.factory.ButtonFactory#createToggleButton should return an AbstractButton.
> This is necessary to return own implementations (e.g. JideToggleButton) that don't extend JToggleButton.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.springframework.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[Springframework-rcp-dev] [Spring-JIRA] Created: (RCP-541) ButtonFactory should return AbstractButton

[Johannes S. (JIRA) <no...@sp...>]

ButtonFactory should return AbstractButton
------------------------------------------

                 Key: RCP-541
                 URL: http://jira.springframework.org/browse/RCP-541
             Project: Spring Framework Rich Client Project
          Issue Type: Improvement
          Components: Binding System
    Affects Versions: 1.0.0
            Reporter: Johannes Schneider
         Attachments: Button.patch

org.springframework.richclient.factory.ButtonFactory#createToggleButton should return an AbstractButton.
This is necessary to return own implementations (e.g. JideToggleButton) that don't extend JToggleButton.



-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.springframework.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[Springframework-rcp-dev] [Spring-JIRA] Commented: (RCP-540) BrowserLauncher uses netscape as default-browser

[Arne L. (JIRA) <no...@sp...>]

    [ http://jira.springframework.org/browse/RCP-540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_32474 ] 

Arne Limburg commented on RCP-540:
----------------------------------

On Windows it uses cmd.exe or command.exe to open the url. So it should start your real default browser! I have not tried JDIC for now, but if it works for linux indeed it sounds better than BrowserLauncher. So it's ok for me that you closed this issue.

> BrowserLauncher uses netscape as default-browser
> ------------------------------------------------
>
>                 Key: RCP-540
>                 URL: http://jira.springframework.org/browse/RCP-540
>             Project: Spring Framework Rich Client Project
>          Issue Type: Improvement
>          Components: Helper Classes
>         Environment: Linux
>            Reporter: Arne Limburg
>            Assignee: Jan Hoskens
>             Fix For: 1.0.0
>
>
> The BrowserLauncher class uses netscape as default browser if no other command to launch an url can be found on the current system (which is the case on all Linux-systems). You should change this default to firefox as it is the most popular browser on these systems. It is the most popular browser at all after iexplorer (which will be handled correct for windows and mac in any case by BrowserLauncher).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.springframework.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[Springframework-rcp-dev] [Spring-JIRA] Commented: (RCP-540) BrowserLauncher uses netscape as default-browser

[Jan H. (JIRA) <no...@sp...>]

    [ http://jira.springframework.org/browse/RCP-540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_32398 ] 

Jan Hoskens commented on RCP-540:
---------------------------------

Good point, I'll deprecate the class and suggest using JDIC.

> BrowserLauncher uses netscape as default-browser
> ------------------------------------------------
>
>                 Key: RCP-540
>                 URL: http://jira.springframework.org/browse/RCP-540
>             Project: Spring Framework Rich Client Project
>          Issue Type: Improvement
>          Components: Helper Classes
>         Environment: Linux
>            Reporter: Arne Limburg
>            Assignee: Jan Hoskens
>             Fix For: 1.0.0
>
>
> The BrowserLauncher class uses netscape as default browser if no other command to launch an url can be found on the current system (which is the case on all Linux-systems). You should change this default to firefox as it is the most popular browser on these systems. It is the most popular browser at all after iexplorer (which will be handled correct for windows and mac in any case by BrowserLauncher).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.springframework.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[Springframework-rcp-dev] [Spring-JIRA] Commented: (RCP-540) BrowserLauncher uses netscape as default-browser

[Geoffrey De S. (JIRA) <no...@sp...>]

    [ http://jira.springframework.org/browse/RCP-540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_32394 ] 

Geoffrey De Smet commented on RCP-540:
--------------------------------------

Shouldn't this class be deprecated in favor the JDIC implementation (or java 6 version of that)?

It sounds like it doesn't start the real default browser.
I am on Windows, but I would be insulted if it started up Internet Exploder :) My default is Firefox, but it could be Opera tomorrow.

> BrowserLauncher uses netscape as default-browser
> ------------------------------------------------
>
>                 Key: RCP-540
>                 URL: http://jira.springframework.org/browse/RCP-540
>             Project: Spring Framework Rich Client Project
>          Issue Type: Improvement
>          Components: Helper Classes
>         Environment: Linux
>            Reporter: Arne Limburg
>            Assignee: Jan Hoskens
>             Fix For: 1.0.0
>
>
> The BrowserLauncher class uses netscape as default browser if no other command to launch an url can be found on the current system (which is the case on all Linux-systems). You should change this default to firefox as it is the most popular browser on these systems. It is the most popular browser at all after iexplorer (which will be handled correct for windows and mac in any case by BrowserLauncher).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.springframework.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[Springframework-rcp-dev] [Spring-JIRA] Commented: (RCP-98) Flexdock integration

[Jan H. (JIRA) <no...@sp...>]

    [ http://jira.springframework.org/browse/RCP-98?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_32378 ] 

Jan Hoskens commented on RCP-98:
--------------------------------

Of course you can. Have you used the stuff in the sandbox area and extended/improved them? Can you create a patch and upload it?

> Flexdock integration
> --------------------
>
>                 Key: RCP-98
>                 URL: http://jira.springframework.org/browse/RCP-98
>             Project: Spring Framework Rich Client Project
>          Issue Type: New Feature
>            Reporter: Claudio Romano
>            Assignee: Peter De Bruycker
>            Priority: Minor
>         Attachments: ClosableDockingPanel.java, FlexApplicationPage.java, FlexApplicationWindow.java, FlexComponentDelegate.java, FlexComponentPane.java, FlexConfigurationManager.java, FlexDockingPort.java, FlexPageDescriptor.java
>
>
> - ClosableDockingPanel, FlexDockingPort and FlexComponentDelegate 
> These are flexdock related classes, should be moved to flexdock later on.
> - FlexApplicationWindow 
> Create a FlexApplicationPage instead of DefaultApplicationPage.
> - FlexApplicationPage
> Handles page components inside flexdock (open, close)
> - FlexConfigurationManager
> Handle the layout configuration of the flexdock. It also loads and save the flexdock configuration into a file. A default layout can be provided in the classpath. (Better integration to the preferences package)
> - FlexPageDescriptor
> Holds a FlexConfigurationManager and builds the initial page layout.
> - DesktopPageDescriptor
> http://opensource.atlassian.com/projects/spring/browse/RCP-56
> - FlexComponentPane extends DesktopPageDescriptor
> This class is in the org.springframework.richclient.command.support and not in org.springframework.richclient.command.support.flexdock beacause it uses the protected method PageComponent.fireFocus... 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.springframework.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[Springframework-rcp-dev] [Spring-JIRA] Closed: (RCP-540) BrowserLauncher uses netscape as default-browser

[Jan H. (JIRA) <no...@sp...>]

     [ http://jira.springframework.org/browse/RCP-540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jan Hoskens closed RCP-540.
---------------------------

         Assignee: Jan Hoskens
       Resolution: Fixed
    Fix Version/s: 1.0.0

Changed in:
http://spring-rich-c.svn.sourceforge.net/spring-rich-c/?rev=1973&view=rev


> BrowserLauncher uses netscape as default-browser
> ------------------------------------------------
>
>                 Key: RCP-540
>                 URL: http://jira.springframework.org/browse/RCP-540
>             Project: Spring Framework Rich Client Project
>          Issue Type: Improvement
>          Components: Helper Classes
>         Environment: Linux
>            Reporter: Arne Limburg
>            Assignee: Jan Hoskens
>             Fix For: 1.0.0
>
>
> The BrowserLauncher class uses netscape as default browser if no other command to launch an url can be found on the current system (which is the case on all Linux-systems). You should change this default to firefox as it is the most popular browser on these systems. It is the most popular browser at all after iexplorer (which will be handled correct for windows and mac in any case by BrowserLauncher).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.springframework.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[Springframework-rcp-dev] [Spring-JIRA] Created: (RCP-540) BrowserLauncher uses netscape as default-browser

[Arne L. (JIRA) <no...@sp...>]

BrowserLauncher uses netscape as default-browser
------------------------------------------------

                 Key: RCP-540
                 URL: http://jira.springframework.org/browse/RCP-540
             Project: Spring Framework Rich Client Project
          Issue Type: Improvement
          Components: Helper Classes
         Environment: Linux
            Reporter: Arne Limburg


The BrowserLauncher class uses netscape as default browser if no other command to launch an url can be found on the current system (which is the case on all Linux-systems). You should change this default to firefox as it is the most popular browser on these systems. It is the most popular browser at all after iexplorer (which will be handled correct for windows and mac in any case by BrowserLauncher).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.springframework.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[Springframework-rcp-dev] [Spring-JIRA] Commented: (RCP-98) Flexdock integration

[Eduardo C. (JIRA) <no...@sp...>]

    [ http://jira.springframework.org/browse/RCP-98?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_32361 ] 

Eduardo Cardoso commented on RCP-98:
------------------------------------

I´m using Spring RCP + Flexdock in my job. Can I help in this issue?

> Flexdock integration
> --------------------
>
>                 Key: RCP-98
>                 URL: http://jira.springframework.org/browse/RCP-98
>             Project: Spring Framework Rich Client Project
>          Issue Type: New Feature
>            Reporter: Claudio Romano
>            Assignee: Peter De Bruycker
>            Priority: Minor
>         Attachments: ClosableDockingPanel.java, FlexApplicationPage.java, FlexApplicationWindow.java, FlexComponentDelegate.java, FlexComponentPane.java, FlexConfigurationManager.java, FlexDockingPort.java, FlexPageDescriptor.java
>
>
> - ClosableDockingPanel, FlexDockingPort and FlexComponentDelegate 
> These are flexdock related classes, should be moved to flexdock later on.
> - FlexApplicationWindow 
> Create a FlexApplicationPage instead of DefaultApplicationPage.
> - FlexApplicationPage
> Handles page components inside flexdock (open, close)
> - FlexConfigurationManager
> Handle the layout configuration of the flexdock. It also loads and save the flexdock configuration into a file. A default layout can be provided in the classpath. (Better integration to the preferences package)
> - FlexPageDescriptor
> Holds a FlexConfigurationManager and builds the initial page layout.
> - DesktopPageDescriptor
> http://opensource.atlassian.com/projects/spring/browse/RCP-56
> - FlexComponentPane extends DesktopPageDescriptor
> This class is in the org.springframework.richclient.command.support and not in org.springframework.richclient.command.support.flexdock beacause it uses the protected method PageComponent.fireFocus... 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.springframework.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Springframework-rcp-dev] [Spring-JIRA] Closed: (RCP-539) BigDecimalTextField looses precision when value is set

[Jan H. (JIRA) <no...@sp...>]

     [ http://jira.springframework.org/browse/RCP-539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jan Hoskens closed RCP-539.
---------------------------

         Assignee: Jan Hoskens
       Resolution: Fixed
    Fix Version/s: 1.0.0

Fixed in:

http://spring-rich-c.svn.sourceforge.net/spring-rich-c/?rev=1971&view=rev

& added some testcases for BigDecimal.

> BigDecimalTextField looses precision when value is set
> ------------------------------------------------------
>
>                 Key: RCP-539
>                 URL: http://jira.springframework.org/browse/RCP-539
>             Project: Spring Framework Rich Client Project
>          Issue Type: Bug
>          Components: Binding System
>    Affects Versions: 0.2.1
>            Reporter: Johannes Bergmann
>            Assignee: Jan Hoskens
>             Fix For: 1.0.0
>
>
> Method setValue in BigDecimalTextField converts the number to a double value before passing it to the format:
>     public void setValue(Number number) {
>         String txt = null;
>         if (number != null) {
>             txt = this.format.format(number.doubleValue());
>         }
>         setText(txt);
>     }
> If number is a BigDecimal the precision of this value might be lost.
> Example: new BigDecimal("1234567890123456.7") is displayed as 1234567890123456.7
> Supposed solution: 
> Pass number instance directly to the format method:
> txt = this.format.format(number);

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.springframework.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[Springframework-rcp-dev] [Spring-JIRA] Created: (RCP-539) BigDecimalTextField looses precision when value is set

[Johannes B. (JIRA) <no...@sp...>]

BigDecimalTextField looses precision when value is set
------------------------------------------------------

                 Key: RCP-539
                 URL: http://jira.springframework.org/browse/RCP-539
             Project: Spring Framework Rich Client Project
          Issue Type: Bug
          Components: Binding System
    Affects Versions: 0.2.1
            Reporter: Johannes Bergmann


Method setValue in BigDecimalTextField converts the number to a double value before passing it to the format:

    public void setValue(Number number) {
        String txt = null;
        if (number != null) {
            txt = this.format.format(number.doubleValue());
        }
        setText(txt);
    }

If number is a BigDecimal the precision of this value might be lost.
Example: new BigDecimal("1234567890123456.7") is displayed as 1234567890123456.7

Supposed solution: 
Pass number instance directly to the format method:
txt = this.format.format(number);


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.springframework.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[Springframework-rcp-dev] [Spring-JIRA] Updated: (RCP-538) Invalid link (dialogs:wizards) in spring-richclient-manual

[Robert M. (JIRA) <no...@sp...>]

     [ http://jira.springframework.org/browse/RCP-538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Munteanu updated RCP-538:
--------------------------------

    Attachment: wizards.diff

Trivial patch attached.

> Invalid link (dialogs:wizards) in spring-richclient-manual
> ----------------------------------------------------------
>
>                 Key: RCP-538
>                 URL: http://jira.springframework.org/browse/RCP-538
>             Project: Spring Framework Rich Client Project
>          Issue Type: Bug
>          Components: Documentation
>    Affects Versions: 1.0.0
>            Reporter: Robert Munteanu
>            Priority: Minor
>         Attachments: wizards.diff
>
>
> The chapter id dialogs:wizards causes both Firefox / Opera / W3M to attempt to locate a 'dialog' handler.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.springframework.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[Springframework-rcp-dev] [Spring-JIRA] Created: (RCP-538) Invalid link (dialogs:wizards) in spring-richclient-manual

[Robert M. (JIRA) <no...@sp...>]

Invalid link (dialogs:wizards) in spring-richclient-manual
----------------------------------------------------------

                 Key: RCP-538
                 URL: http://jira.springframework.org/browse/RCP-538
             Project: Spring Framework Rich Client Project
          Issue Type: Bug
          Components: Documentation
    Affects Versions: 1.0.0
            Reporter: Robert Munteanu
            Priority: Minor


The chapter id dialogs:wizards causes both Firefox / Opera / W3M to attempt to locate a 'dialog' handler.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.springframework.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[Springframework-rcp-dev] [Spring-JIRA] Closed: (RCP-537) Constraing regexp does not display a nice message

[Jan H. (JIRA) <no...@sp...>]

     [ http://jira.springframework.org/browse/RCP-537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jan Hoskens closed RCP-537.
---------------------------

         Assignee: Jan Hoskens
       Resolution: Fixed
    Fix Version/s: 1.0.0

Implemented in:

http://spring-rich-c.svn.sourceforge.net/spring-rich-c/?rev=1970&view=rev

> Constraing regexp does not display a nice message
> -------------------------------------------------
>
>                 Key: RCP-537
>                 URL: http://jira.springframework.org/browse/RCP-537
>             Project: Spring Framework Rich Client Project
>          Issue Type: Bug
>    Affects Versions: 0.2.1
>            Reporter: Benoit Xhenseval
>            Assignee: Jan Hoskens
>             Fix For: 1.0.0
>
>         Attachments: screenshot-1.jpg
>
>
> The enclosed image shows that when a regular expression is violated, the message is not formatted properly.
> eg the image enclosed is the result of:
> add("isin", regexp("([A-Z]{2}[A-Z0-9]{9}[0-9])?", "ISIN Format"));
> this results in:
> "ISIN Code org.springframework.rules.constraint.RegexpConstraint@11f2041"
> Could somebody add a toString method on RegexpConstraint
> public toString() {
>    return getDefaultMessage() + " " + pattern;
> }
> Thanks!

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.springframework.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Re: [Springframework-rcp-dev] ApplicationDialog dispose

[Jan H. <jh...@sc...>]

Fixed 1 and 2 by adding disposeDialogContentPane() and moving
wizard.addPages() to the WizardDialog.setWizard() method. 

Point 3 still exists, but is a minor one.

If the changed behavior due to moving the addPages method proves to be
less suitable than having it on gui-construction
(createDialogContentPane) please provide a use-case.

Kind Regards,
Jan

On Mon, 2008-02-11 at 14:43 +0100, Jan Hoskens wrote:
> Some more thoughts about 2):
> 
> I would opt to call wizard.addPages() in the setWizard() method of the
> WizardDialog. However the wizard.addPages() method states in its javadoc
> that it can be used to lazily add pages just before the dialog becomes
> visible. This seems a bit strange to me. The visual components are only
> created when needed (during dialog construction) so these can be seen as
> lazily created. The actual dialogPages (thus the modelling) should be
> available when the wizard is set on the dialog, which seems reasonable
> to me at this moment. At the moment that you want to have a Dialog, it
> seems logical to have all your pages set.
> 
> The new owner wizard of the petclinic sample does break with this change
> because it creates the dialog first, then the form to display. Changing
> this sequence fixes the wizard.
> 
> Kind Regards,
> Jan
> 
> On Mon, 2008-02-11 at 13:41 +0100, Jan Hoskens wrote:
> > Hi,
> > 
> > I've run into some issues concerning the dispose of the
> > ApplicationDialog. The default CloseAction of ApplicationDialogs is set
> > to DISPOSE and will have the effect of disposing the actual JDialog
> > which resides in ApplicationDialog. 
> > 
> > Issues I encounter are:
> > 
> > 1) subclasses don't 'dispose' the content pane they provide, however the
> > surrounding JDialog is disposed. This can be fixed by providing an
> > additional method disposeDialogContentPane. Any components kept in
> > fields and created in createDialogContentPane can have their reference
> > set to null in the disposeDialogContentPane.
> > 
> > 2) subclasses may use the createDialogContentPane for other reasons than
> > just the creation of visual components. Eg WizardDialog actually adds
> > its pages in that method. This is not a real part of the content
> > creation and momentarily has problems because it gets executed every
> > time the wizard is opened. It reflects in duplicate pages (see issue
> > RCP-536). I don't think we want to remove them in
> > disposeDialogContentPane and re-add them again but fix this by calling
> > it only once. I'm looking for the best spot/way to do this.
> > 
> > 3) the create/dispose methods may not be transparent. Meaning when using
> > the TitledApplicationDialog, a titlepane is used on top. When creating
> > the dialog, titlePane.getControl() is used. When closing the
> > ApplicationDialog, the JDialog can be disposed as well as any content in
> > the TitledApplicationDialog by the disposeDialogContentPane, but the
> > titlepane still has its component cached. Is this a problem?
> > 
> > WDYT?
> > 
> > Kind Regards,
> > Jan
> > 
> > 
> >  **** DISCLAIMER ****
> >  http://www.schaubroeck.be/maildisclaimer.htm
> > 
> > -------------------------------------------------------------------------
> > This SF.net email is sponsored by: Microsoft
> > Defy all challenges. Microsoft(R) Visual Studio 2008.
> > http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> > _______________________________________________
> > Springframework-rcp-dev mailing list
> > Spr...@li...
> > https://lists.sourceforge.net/lists/listinfo/springframework-rcp-dev
> 
> 
>  **** DISCLAIMER ****
>  http://www.schaubroeck.be/maildisclaimer.htm
> 
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> _______________________________________________
> Springframework-rcp-dev mailing list
> Spr...@li...
> https://lists.sourceforge.net/lists/listinfo/springframework-rcp-dev


 **** DISCLAIMER ****
 http://www.schaubroeck.be/maildisclaimer.htm

[Springframework-rcp-dev] [Spring-JIRA] Closed: (RCP-536) AbstractWizard#addPages is called multiple times, when Wizard is reused

[Jan H. (JIRA) <no...@sp...>]

     [ http://jira.springframework.org/browse/RCP-536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jan Hoskens closed RCP-536.
---------------------------

         Assignee: Jan Hoskens
       Resolution: Fixed
    Fix Version/s: 1.0.0

The adding of pages is moved to setWizard() of the WizardDialog:

http://spring-rich-c.svn.sourceforge.net/viewvc/spring-rich-c?view=rev&revision=1967

The createDialogContentPane() can be called multiple times when the close action is set to DISPOSE. Therefor an additional method disposeDialogContentPane() is created in ApplicationDialog to allow cleanup of the contentpane. 

The addPages() however is not a part of the construction of the contentPane (page.getControl() is) and therefor removed from that method. Placing this in the WizardDialog.setWizard() method changes the behavior defined in javadoc as lazy init, but when creating the container (hence setting things up to show) it seems logical to have the wizard pages available (except for dynamically added pages) and their graphical control will be created lazily when the JDialog is created.

> AbstractWizard#addPages is called multiple times, when Wizard is reused
> -----------------------------------------------------------------------
>
>                 Key: RCP-536
>                 URL: http://jira.springframework.org/browse/RCP-536
>             Project: Spring Framework Rich Client Project
>          Issue Type: Bug
>          Components: Command System
>    Affects Versions: 1.0.0
>            Reporter: Johannes Schneider
>            Assignee: Jan Hoskens
>            Priority: Critical
>             Fix For: 1.0.0
>
>
> The method AbstractWizard#addPages is called multiple times when a WizardDialog is shown multiple times.
> You can reproduce this using the PetClinitStandalone.
> Just open the NewOwnerWizard, enter some values, go to the next page and *cancel*.
> Now reopen the wizard. Now the wizard has each page added two times.....
> This is a major problem that should be fixed asap. Wizards are almost unusable now.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.springframework.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Re: [Springframework-rcp-dev] ApplicationDialog dispose

[Jan H. <jh...@sc...>]

Some more thoughts about 2):

I would opt to call wizard.addPages() in the setWizard() method of the
WizardDialog. However the wizard.addPages() method states in its javadoc
that it can be used to lazily add pages just before the dialog becomes
visible. This seems a bit strange to me. The visual components are only
created when needed (during dialog construction) so these can be seen as
lazily created. The actual dialogPages (thus the modelling) should be
available when the wizard is set on the dialog, which seems reasonable
to me at this moment. At the moment that you want to have a Dialog, it
seems logical to have all your pages set.

The new owner wizard of the petclinic sample does break with this change
because it creates the dialog first, then the form to display. Changing
this sequence fixes the wizard.

Kind Regards,
Jan

On Mon, 2008-02-11 at 13:41 +0100, Jan Hoskens wrote:
> Hi,
> 
> I've run into some issues concerning the dispose of the
> ApplicationDialog. The default CloseAction of ApplicationDialogs is set
> to DISPOSE and will have the effect of disposing the actual JDialog
> which resides in ApplicationDialog. 
> 
> Issues I encounter are:
> 
> 1) subclasses don't 'dispose' the content pane they provide, however the
> surrounding JDialog is disposed. This can be fixed by providing an
> additional method disposeDialogContentPane. Any components kept in
> fields and created in createDialogContentPane can have their reference
> set to null in the disposeDialogContentPane.
> 
> 2) subclasses may use the createDialogContentPane for other reasons than
> just the creation of visual components. Eg WizardDialog actually adds
> its pages in that method. This is not a real part of the content
> creation and momentarily has problems because it gets executed every
> time the wizard is opened. It reflects in duplicate pages (see issue
> RCP-536). I don't think we want to remove them in
> disposeDialogContentPane and re-add them again but fix this by calling
> it only once. I'm looking for the best spot/way to do this.
> 
> 3) the create/dispose methods may not be transparent. Meaning when using
> the TitledApplicationDialog, a titlepane is used on top. When creating
> the dialog, titlePane.getControl() is used. When closing the
> ApplicationDialog, the JDialog can be disposed as well as any content in
> the TitledApplicationDialog by the disposeDialogContentPane, but the
> titlepane still has its component cached. Is this a problem?
> 
> WDYT?
> 
> Kind Regards,
> Jan
> 
> 
>  **** DISCLAIMER ****
>  http://www.schaubroeck.be/maildisclaimer.htm
> 
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> _______________________________________________
> Springframework-rcp-dev mailing list
> Spr...@li...
> https://lists.sourceforge.net/lists/listinfo/springframework-rcp-dev


 **** DISCLAIMER ****
 http://www.schaubroeck.be/maildisclaimer.htm

[Springframework-rcp-dev] ApplicationDialog dispose

[Jan H. <jh...@sc...>]

Hi,

I've run into some issues concerning the dispose of the
ApplicationDialog. The default CloseAction of ApplicationDialogs is set
to DISPOSE and will have the effect of disposing the actual JDialog
which resides in ApplicationDialog. 

Issues I encounter are:

1) subclasses don't 'dispose' the content pane they provide, however the
surrounding JDialog is disposed. This can be fixed by providing an
additional method disposeDialogContentPane. Any components kept in
fields and created in createDialogContentPane can have their reference
set to null in the disposeDialogContentPane.

2) subclasses may use the createDialogContentPane for other reasons than
just the creation of visual components. Eg WizardDialog actually adds
its pages in that method. This is not a real part of the content
creation and momentarily has problems because it gets executed every
time the wizard is opened. It reflects in duplicate pages (see issue
RCP-536). I don't think we want to remove them in
disposeDialogContentPane and re-add them again but fix this by calling
it only once. I'm looking for the best spot/way to do this.

3) the create/dispose methods may not be transparent. Meaning when using
the TitledApplicationDialog, a titlepane is used on top. When creating
the dialog, titlePane.getControl() is used. When closing the
ApplicationDialog, the JDialog can be disposed as well as any content in
the TitledApplicationDialog by the disposeDialogContentPane, but the
titlepane still has its component cached. Is this a problem?

WDYT?

Kind Regards,
Jan


 **** DISCLAIMER ****
 http://www.schaubroeck.be/maildisclaimer.htm

[Springframework-rcp-dev] [Spring-JIRA] Commented: (RCP-536) AbstractWizard#addPages is called multiple times, when Wizard is reused

[Jan H. (JIRA) <no...@sp...>]

    [ http://jira.springframework.org/browse/RCP-536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_31942 ] 

Jan Hoskens commented on RCP-536:
---------------------------------

After some more research, it seems that ordinary dialogs don't have this problem. Although they don't dispose their content at the moment the dialog is disposed. A next call to open the dialog will implicitly mean that the old content is dereferenced and set available for garbage collection. (contentPane is a JPanel, when creating contentPane is set to a new JPanel hence the old is dereferenced. Note: can optionally be a problem in custom code if referencing the contentpane.)

The wizardDialog however adds its pages when creating the content pane and these are not dereferenced in the same way. Hence the list of pages is only growing and showing duplicates.

> AbstractWizard#addPages is called multiple times, when Wizard is reused
> -----------------------------------------------------------------------
>
>                 Key: RCP-536
>                 URL: http://jira.springframework.org/browse/RCP-536
>             Project: Spring Framework Rich Client Project
>          Issue Type: Bug
>          Components: Command System
>    Affects Versions: 1.0.0
>            Reporter: Johannes Schneider
>            Priority: Critical
>
> The method AbstractWizard#addPages is called multiple times when a WizardDialog is shown multiple times.
> You can reproduce this using the PetClinitStandalone.
> Just open the NewOwnerWizard, enter some values, go to the next page and *cancel*.
> Now reopen the wizard. Now the wizard has each page added two times.....
> This is a major problem that should be fixed asap. Wizards are almost unusable now.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.springframework.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Re: [Springframework-rcp-dev] Best way for a special Constraint...

[Geoffrey De S. <ge0...@gm...>]

Maybe it's better to disable (and clear) the field if the other property 
is true?

With kind regards,
Geoffrey De Smet

Jan Hoskens schreef:
> Have you tried something like:
> 
> constraints.ifTrue(constraints.eq("X", ValueY),
> constraints.not(constraints.present(Y)));
> 
> Maybe we should indeed add an AbsentIfTrue as an opposite of the
> RequiredIfTrue.
> 
> Kind Regards,
> Jan
> 
> 
> On Fri, 2008-02-08 at 16:44 +0000, Benoit Xhenseval wrote:
>> Hi All,
>>
>>  
>>
>> It is Friday afternoon and my brain is slowing down…  What would be
>> the best way to say:
>>
>>  
>>
>> If Property X == ‘VAL_1’ then Property Y must be ABSENT/null
>>
>> If Property X == ‘VAL_1’ then Property Z must be ABSENT/null
>>
>> If Property X == ‘VAL_2’ then Property Y is required
>>
>> If Property X == ‘VAL_3’ then Property Z is required
>>
>>  
>>
>> The last 2 are easy:
>>
>> add(new RequiredIfTrue("Y", eq("X", “VAL_2”)));
>>
>> add(new RequiredIfTrue("Z", eq("X", “VAL_3”)));
>>
>>  
>>
>> but something like AbsentIfTrue would be useful…
>>
>> But how would you check for absence? Not(present(“Y”)) ?
>>
>>  
>>
>> Second question, is it possible to put a rule with a given regular
>> expression (like ISIN which are 2 char followed by 9 numerics).
>>
>>  
>>
>> Many thanks,
>>
>>  
>>
>> Benoit
>>
>>  
>>
>> ------------------------------
>>
>> IMPORTANT NOTICE 
>>
>> This communication contains information that is considered
>> confidential and may also be privileged . It is for the exclusive use
>> of the intended recipient(s). If you are not the intended recipient(s)
>> please note that any form of distribution, copying or use of this
>> communication or the information in it is strictly prohibited and may
>> be unlawful. If you have received this communication in error please
>> return it to the sender and delete the original.
>>
>>  
>>
>>
>> -------------------------------------------------------------------------
>> This SF.net email is sponsored by: Microsoft
>> Defy all challenges. Microsoft(R) Visual Studio 2008.
>> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
>> _______________________________________________ Springframework-rcp-dev mailing list Spr...@li... https://lists.sourceforge.net/lists/listinfo/springframework-rcp-dev
> 
> 
>  **** DISCLAIMER ****
>  http://www.schaubroeck.be/maildisclaimer.htm
> 
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> _______________________________________________
> Springframework-rcp-dev mailing list
> Spr...@li...
> https://lists.sourceforge.net/lists/listinfo/springframework-rcp-dev

[Springframework-rcp-dev] [Spring-JIRA] Commented: (RCP-536) AbstractWizard#addPages is called multiple times, when Wizard is reused

[Jan H. (JIRA) <no...@sp...>]

    [ http://jira.springframework.org/browse/RCP-536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_31937 ] 

Jan Hoskens commented on RCP-536:
---------------------------------

The current default on cancelling/finishing  dialogs is to dispose the window. Apparently this disposing is not being handled in in extended classes. They keep their content pane cached when the dialog is disposed. When reopening the wizard, the dialog is constructed anew and the pages are added to the content pane which wasn't disposed. The latter leads to the described behavior. 

I'm thinking of resolving this by making the dispose() method non-final and override it where needed. I'll check subclasses of ApplicationDialog to make sure they dispose their content pane and any additional components.

Thanks for reporting.

> AbstractWizard#addPages is called multiple times, when Wizard is reused
> -----------------------------------------------------------------------
>
>                 Key: RCP-536
>                 URL: http://jira.springframework.org/browse/RCP-536
>             Project: Spring Framework Rich Client Project
>          Issue Type: Bug
>          Components: Command System
>    Affects Versions: 1.0.0
>            Reporter: Johannes Schneider
>            Priority: Critical
>
> The method AbstractWizard#addPages is called multiple times when a WizardDialog is shown multiple times.
> You can reproduce this using the PetClinitStandalone.
> Just open the NewOwnerWizard, enter some values, go to the next page and *cancel*.
> Now reopen the wizard. Now the wizard has each page added two times.....
> This is a major problem that should be fixed asap. Wizards are almost unusable now.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.springframework.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Re: [Springframework-rcp-dev] Best way for a special Constraint...

[Jan H. <jh...@sc...>]

Have you tried something like:

constraints.ifTrue(constraints.eq("X", ValueY),
constraints.not(constraints.present(Y)));

Maybe we should indeed add an AbsentIfTrue as an opposite of the
RequiredIfTrue.

Kind Regards,
Jan


On Fri, 2008-02-08 at 16:44 +0000, Benoit Xhenseval wrote:
> Hi All,
> 
>  
> 
> It is Friday afternoon and my brain is slowing down…  What would be
> the best way to say:
> 
>  
> 
> If Property X == ‘VAL_1’ then Property Y must be ABSENT/null
> 
> If Property X == ‘VAL_1’ then Property Z must be ABSENT/null
> 
> If Property X == ‘VAL_2’ then Property Y is required
> 
> If Property X == ‘VAL_3’ then Property Z is required
> 
>  
> 
> The last 2 are easy:
> 
> add(new RequiredIfTrue("Y", eq("X", “VAL_2”)));
> 
> add(new RequiredIfTrue("Z", eq("X", “VAL_3”)));
> 
>  
> 
> but something like AbsentIfTrue would be useful…
> 
> But how would you check for absence? Not(present(“Y”)) ?
> 
>  
> 
> Second question, is it possible to put a rule with a given regular
> expression (like ISIN which are 2 char followed by 9 numerics).
> 
>  
> 
> Many thanks,
> 
>  
> 
> Benoit
> 
>  
> 
> ------------------------------
> 
> IMPORTANT NOTICE 
> 
> This communication contains information that is considered
> confidential and may also be privileged . It is for the exclusive use
> of the intended recipient(s). If you are not the intended recipient(s)
> please note that any form of distribution, copying or use of this
> communication or the information in it is strictly prohibited and may
> be unlawful. If you have received this communication in error please
> return it to the sender and delete the original.
> 
>  
> 
> 
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> _______________________________________________ Springframework-rcp-dev mailing list Spr...@li... https://lists.sourceforge.net/lists/listinfo/springframework-rcp-dev


 **** DISCLAIMER ****
 http://www.schaubroeck.be/maildisclaimer.htm

[Springframework-rcp-dev] [Spring-JIRA] Created: (RCP-537) Constraing regexp does not display a nice message

[Benoit X. (JIRA) <no...@sp...>]

Constraing regexp does not display a nice message
-------------------------------------------------

                 Key: RCP-537
                 URL: http://jira.springframework.org/browse/RCP-537
             Project: Spring Framework Rich Client Project
          Issue Type: Bug
    Affects Versions: 0.2.1
            Reporter: Benoit Xhenseval


The enclosed image shows that when a regular expression is violated, the message is not formatted properly.

eg the image enclosed is the result of:
add("isin", regexp("([A-Z]{2}[A-Z0-9]{9}[0-9])?", "ISIN Format"));

this results in:
"ISIN Code org.springframework.rules.constraint.RegexpConstraint@11f2041"

Could somebody add a toString method on RegexpConstraint

public toString() {
   return getDefaultMessage() + " " + pattern;
}

Thanks!

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.springframework.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[Springframework-rcp-dev] [Spring-JIRA] Updated: (RCP-537) Constraing regexp does not display a nice message

[Benoit X. (JIRA) <no...@sp...>]

     [ http://jira.springframework.org/browse/RCP-537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benoit Xhenseval updated RCP-537:
---------------------------------

    Attachment: screenshot-1.jpg

> Constraing regexp does not display a nice message
> -------------------------------------------------
>
>                 Key: RCP-537
>                 URL: http://jira.springframework.org/browse/RCP-537
>             Project: Spring Framework Rich Client Project
>          Issue Type: Bug
>    Affects Versions: 0.2.1
>            Reporter: Benoit Xhenseval
>         Attachments: screenshot-1.jpg
>
>
> The enclosed image shows that when a regular expression is violated, the message is not formatted properly.
> eg the image enclosed is the result of:
> add("isin", regexp("([A-Z]{2}[A-Z0-9]{9}[0-9])?", "ISIN Format"));
> this results in:
> "ISIN Code org.springframework.rules.constraint.RegexpConstraint@11f2041"
> Could somebody add a toString method on RegexpConstraint
> public toString() {
>    return getDefaultMessage() + " " + pattern;
> }
> Thanks!

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.springframework.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[Springframework-rcp-dev] Best way for a special Constraint...

[Benoit X. <bx...@ob...>]

Hi All,

 

It is Friday afternoon and my brain is slowing down.  What would be the best
way to say:

 

If Property X == 'VAL_1' then Property Y must be ABSENT/null

If Property X == 'VAL_1' then Property Z must be ABSENT/null

If Property X == 'VAL_2' then Property Y is required

If Property X == 'VAL_3' then Property Z is required

 

The last 2 are easy:

add(new RequiredIfTrue("Y", eq("X", "VAL_2")));

add(new RequiredIfTrue("Z", eq("X", "VAL_3")));

 

but something like AbsentIfTrue would be useful.

But how would you check for absence? Not(present("Y")) ?

 

Second question, is it possible to put a rule with a given regular
expression (like ISIN which are 2 char followed by 9 numerics).

 

Many thanks,

 

Benoit

 

------------------------------

IMPORTANT NOTICE 

This communication contains information that is considered confidential and
may also be privileged . It is for the exclusive use of the intended
recipient(s). If you are not the intended recipient(s) please note that any
form of distribution, copying or use of this communication or the
information in it is strictly prohibited and may be unlawful. If you have
received this communication in error please return it to the sender and
delete the original.