Menu
▾
▴
springframework-developer
|
From: Juergen H. <ju...@in...> - 2005-06-14 19:41:44
|
Everybody, Keith's LabeledEnum and ToStringCreator stuff has been moved over from the sandbox, to be shipped with Spring 1.2.2 (and to be used by Web Flow PR4). I've rearranged the structure and also reworked the implementations / interfaces quite a bit. ToStringCreator and its helpers reside in the "core.style" package now; LabeledEnum and LabeledEnumResolver in "core.enums" (without separate support subpackage; it's all in one package name). I've also reworked the generic comparators: they reside in "util.comparator" now. The biggest change there is that there is no SortDefinition class anymore. Instead, an InvertibleComparator decorator takes over the same role. SortDefinition already was a Comparator decorator before, so was arguably misnamed. Keith / Erwin, could you please make sure that everything's compiling again on the Web Flow side of things. Once the Web Flow module has found its final home in the CVS structure, that is ;-) Juergen |
|
From: Dmitriy K. <dko...@ru...> - 2005-06-14 19:53:03
|
>I've also reworked the generic comparators: they reside in "util.comparator" >now. The biggest change there is that there is no SortDefinition class >anymore. Instead, an InvertibleComparator decorator takes over the same >role. SortDefinition already was a Comparator decorator before, so was >arguably misnamed. > > > We're using SortDefinition quite a bit. I guess I'd need to revisit some of our apps and refactor, refactor, refactor... :-) Dmitriy. |
|
From: Juergen H. <ju...@in...> - 2005-06-14 20:40:55
|
Sorry, I guess I caused a misunderstanding here: "core.beans.support.SortDefinition" still exists, like it did before. We're staying fully backwards compatible to Spring 1.2.1. Keith had another SortDefiniton class in the "comparator" package in the sandbox. That's the one I reworked. A side benefit of that is that we don't have two classes named SortDefinition in the production codebase. Juergen -----Original Message----- From: spr...@li... [mailto:spr...@li...]On Behalf Of Dmitriy Kopylenko Sent: Tuesday, June 14, 2005 9:53 PM To: spr...@li... Subject: Re: [Springframework-developer] enums, styler, comparator >I've also reworked the generic comparators: they reside in "util.comparator" >now. The biggest change there is that there is no SortDefinition class >anymore. Instead, an InvertibleComparator decorator takes over the same >role. SortDefinition already was a Comparator decorator before, so was >arguably misnamed. > > > We're using SortDefinition quite a bit. I guess I'd need to revisit some of our apps and refactor, refactor, refactor... :-) Dmitriy. ------------------------------------------------------- SF.Net email is sponsored by: Discover Easy Linux Migration Strategies from IBM. Find simple to follow Roadmaps, straightforward articles, informative Webcasts and more! Get everything you need to get up to speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click _______________________________________________ Springframework-developer mailing list Spr...@li... https://lists.sourceforge.net/lists/listinfo/springframework-developer |
|
From: Dmitriy K. <dko...@ru...> - 2005-06-14 20:48:28
|
Roger that ;-) Thanks for the clarification... Dmitriy. Juergen Hoeller wrote: >Sorry, I guess I caused a misunderstanding here: >"core.beans.support.SortDefinition" still exists, like it did before. We're >staying fully backwards compatible to Spring 1.2.1. > >Keith had another SortDefiniton class in the "comparator" package in the >sandbox. That's the one I reworked. A side benefit of that is that we don't >have two classes named SortDefinition in the production codebase. > >Juergen > > >-----Original Message----- >From: spr...@li... >[mailto:spr...@li...]On Behalf >Of Dmitriy Kopylenko >Sent: Tuesday, June 14, 2005 9:53 PM >To: spr...@li... >Subject: Re: [Springframework-developer] enums, styler, comparator > > > > > >>I've also reworked the generic comparators: they reside in >> >> >"util.comparator" > > >>now. The biggest change there is that there is no SortDefinition class >>anymore. Instead, an InvertibleComparator decorator takes over the same >>role. SortDefinition already was a Comparator decorator before, so was >>arguably misnamed. >> >> >> >> >> >We're using SortDefinition quite a bit. I guess I'd need to revisit some >of our apps and refactor, refactor, refactor... :-) > >Dmitriy. > > > > >------------------------------------------------------- >SF.Net email is sponsored by: Discover Easy Linux Migration Strategies >from IBM. Find simple to follow Roadmaps, straightforward articles, >informative Webcasts and more! Get everything you need to get up to >speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click >_______________________________________________ >Springframework-developer mailing list >Spr...@li... >https://lists.sourceforge.net/lists/listinfo/springframework-developer > > > >------------------------------------------------------- >SF.Net email is sponsored by: Discover Easy Linux Migration Strategies >from IBM. Find simple to follow Roadmaps, straightforward articles, >informative Webcasts and more! Get everything you need to get up to >speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click >_______________________________________________ >Springframework-developer mailing list >Spr...@li... >https://lists.sourceforge.net/lists/listinfo/springframework-developer > > |
|
From: Keith D. <ke...@in...> - 2005-06-15 00:00:27
|
Lookin good!!! How come you didn't call InvertibleComparator "FlippableComparator" ;-) Keith -----Original Message----- From: spr...@li... [mailto:spr...@li...] On Behalf Of Juergen Hoeller Sent: Tuesday, June 14, 2005 4:41 PM To: spr...@li... Subject: Re: [Springframework-developer] enums, styler, comparator Sorry, I guess I caused a misunderstanding here: "core.beans.support.SortDefinition" still exists, like it did before. We're staying fully backwards compatible to Spring 1.2.1. Keith had another SortDefiniton class in the "comparator" package in the sandbox. That's the one I reworked. A side benefit of that is that we don't have two classes named SortDefinition in the production codebase. Juergen -----Original Message----- From: spr...@li... [mailto:spr...@li...]On Behalf Of Dmitriy Kopylenko Sent: Tuesday, June 14, 2005 9:53 PM To: spr...@li... Subject: Re: [Springframework-developer] enums, styler, comparator >I've also reworked the generic comparators: they reside in "util.comparator" >now. The biggest change there is that there is no SortDefinition class >anymore. Instead, an InvertibleComparator decorator takes over the same >role. SortDefinition already was a Comparator decorator before, so was >arguably misnamed. > > > We're using SortDefinition quite a bit. I guess I'd need to revisit some of our apps and refactor, refactor, refactor... :-) Dmitriy. ------------------------------------------------------- SF.Net email is sponsored by: Discover Easy Linux Migration Strategies from IBM. Find simple to follow Roadmaps, straightforward articles, informative Webcasts and more! Get everything you need to get up to speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click _______________________________________________ Springframework-developer mailing list Spr...@li... https://lists.sourceforge.net/lists/listinfo/springframework-developer ------------------------------------------------------- SF.Net email is sponsored by: Discover Easy Linux Migration Strategies from IBM. Find simple to follow Roadmaps, straightforward articles, informative Webcasts and more! Get everything you need to get up to speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click _______________________________________________ Springframework-developer mailing list Spr...@li... https://lists.sourceforge.net/lists/listinfo/springframework-developer |
|
From: Dmitriy K. <dko...@ru...> - 2005-06-15 02:12:20
|
I guess "FlippableComparator" is the American version of "InvertibleComparator" ;-) Dmitriy. Keith Donald wrote: >Lookin good!!! How come you didn't call InvertibleComparator >"FlippableComparator" ;-) Keith > > > |
|
From: Colin S. <col...@ex...> - 2005-06-16 16:00:20
|
Juergen Hoeller wrote: >Everybody, > >Keith's LabeledEnum and ToStringCreator stuff has been moved over from the >sandbox, to be shipped with Spring 1.2.2 (and to be used by Web Flow PR4). > >I've rearranged the structure and also reworked the implementations / >interfaces quite a bit. ToStringCreator and its helpers reside in the >"core.style" package now; LabeledEnum and LabeledEnumResolver in >"core.enums" (without separate support subpackage; it's all in one package >name). > >I've also reworked the generic comparators: they reside in "util.comparator" >now. The biggest change there is that there is no SortDefinition class >anymore. Instead, an InvertibleComparator decorator takes over the same >role. SortDefinition already was a Comparator decorator before, so was >arguably misnamed. > >Keith / Erwin, could you please make sure that everything's compiling again >on the Web Flow side of things. Once the Web Flow module has found its final >home in the CVS structure, that is ;-) > > What happened to the 'Styler' class? http://cvs.sourceforge.net/viewcvs.py/springframework/spring/src/org/springframework/core/Attic/Styler.java?view=markup I tried to make the SWF code compile against current Spring CVS while on a plane ride back to Toronto yesterday, but Styler seems to be gone. So right now the SWF code is still building against a snapshot from June 13th. Colin |
|
From: Juergen H. <ju...@in...> - 2005-06-16 18:06:42
|
It's been replaced by the ValueStyler interface and DefaultValueStyler implementation, in the "core.style" package. I'm currently discussing with Keith whether a ValueStyler singleton should be re-introduced. Currently, the only singleton held is ToStringCreator's DefaultToStringStyler, which in turn holds a DefaultValueStyler instance. I'd like to keep singletons as minimal as possible. There's always the option to use "new DefaultValueStyler()" / "new DefaultToStringStyler()" or even receive a ValueStyler / ToStringStyler through dependency injection. Juergen -----Original Message----- From: spr...@li... [mailto:spr...@li...]On Behalf Of Colin Sampaleanu Sent: Thursday, June 16, 2005 6:02 PM To: spr...@li... Subject: Re: [Springframework-developer] enums, styler, comparator Juergen Hoeller wrote: >Everybody, > >Keith's LabeledEnum and ToStringCreator stuff has been moved over from the >sandbox, to be shipped with Spring 1.2.2 (and to be used by Web Flow PR4). > >I've rearranged the structure and also reworked the implementations / >interfaces quite a bit. ToStringCreator and its helpers reside in the >"core.style" package now; LabeledEnum and LabeledEnumResolver in >"core.enums" (without separate support subpackage; it's all in one package >name). > >I've also reworked the generic comparators: they reside in "util.comparator" >now. The biggest change there is that there is no SortDefinition class >anymore. Instead, an InvertibleComparator decorator takes over the same >role. SortDefinition already was a Comparator decorator before, so was >arguably misnamed. > >Keith / Erwin, could you please make sure that everything's compiling again >on the Web Flow side of things. Once the Web Flow module has found its final >home in the CVS structure, that is ;-) > > What happened to the 'Styler' class? http://cvs.sourceforge.net/viewcvs.py/springframework/spring/src/org/springf ramework/core/Attic/Styler.java?view=markup I tried to make the SWF code compile against current Spring CVS while on a plane ride back to Toronto yesterday, but Styler seems to be gone. So right now the SWF code is still building against a snapshot from June 13th. Colin ------------------------------------------------------- SF.Net email is sponsored by: Discover Easy Linux Migration Strategies from IBM. Find simple to follow Roadmaps, straightforward articles, informative Webcasts and more! Get everything you need to get up to speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click _______________________________________________ Springframework-developer mailing list Spr...@li... https://lists.sourceforge.net/lists/listinfo/springframework-developer |
|
From: Keith D. <ke...@in...> - 2005-06-16 22:22:53
|
Yeah, but injection there is not at al practical. Singleton usage for this kind of usage is acceptable IMO. The singleton has a default that is not expensive to initialize (its just a POJO with no other dependencies). Furthermore, that default is still configurable through a static load method. I don't see the problem there. Now, I am up for just changing the exception messages in webflow to rely on the standard collections toString implementations. However I admit that would be a bit of a step back, especially after someone just remarked in a training how descriptive and "great looking" that one exception message was ;-) Keith -----Original Message----- From: spr...@li... [mailto:spr...@li...] On Behalf Of Juergen Hoeller Sent: Thursday, June 16, 2005 2:07 PM To: spr...@li... Subject: Re: [Springframework-developer] enums, styler, comparator It's been replaced by the ValueStyler interface and DefaultValueStyler implementation, in the "core.style" package. I'm currently discussing with Keith whether a ValueStyler singleton should be re-introduced. Currently, the only singleton held is ToStringCreator's DefaultToStringStyler, which in turn holds a DefaultValueStyler instance. I'd like to keep singletons as minimal as possible. There's always the option to use "new DefaultValueStyler()" / "new DefaultToStringStyler()" or even receive a ValueStyler / ToStringStyler through dependency injection. Juergen -----Original Message----- From: spr...@li... [mailto:spr...@li...]On Behalf Of Colin Sampaleanu Sent: Thursday, June 16, 2005 6:02 PM To: spr...@li... Subject: Re: [Springframework-developer] enums, styler, comparator Juergen Hoeller wrote: >Everybody, > >Keith's LabeledEnum and ToStringCreator stuff has been moved over from the >sandbox, to be shipped with Spring 1.2.2 (and to be used by Web Flow PR4). > >I've rearranged the structure and also reworked the implementations / >interfaces quite a bit. ToStringCreator and its helpers reside in the >"core.style" package now; LabeledEnum and LabeledEnumResolver in >"core.enums" (without separate support subpackage; it's all in one package >name). > >I've also reworked the generic comparators: they reside in "util.comparator" >now. The biggest change there is that there is no SortDefinition class >anymore. Instead, an InvertibleComparator decorator takes over the same >role. SortDefinition already was a Comparator decorator before, so was >arguably misnamed. > >Keith / Erwin, could you please make sure that everything's compiling again >on the Web Flow side of things. Once the Web Flow module has found its final >home in the CVS structure, that is ;-) > > What happened to the 'Styler' class? http://cvs.sourceforge.net/viewcvs.py/springframework/spring/src/org/springf ramework/core/Attic/Styler.java?view=markup I tried to make the SWF code compile against current Spring CVS while on a plane ride back to Toronto yesterday, but Styler seems to be gone. So right now the SWF code is still building against a snapshot from June 13th. Colin ------------------------------------------------------- SF.Net email is sponsored by: Discover Easy Linux Migration Strategies from IBM. Find simple to follow Roadmaps, straightforward articles, informative Webcasts and more! Get everything you need to get up to speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click _______________________________________________ Springframework-developer mailing list Spr...@li... https://lists.sourceforge.net/lists/listinfo/springframework-developer ------------------------------------------------------- SF.Net email is sponsored by: Discover Easy Linux Migration Strategies from IBM. Find simple to follow Roadmaps, straightforward articles, informative Webcasts and more! Get everything you need to get up to speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click _______________________________________________ Springframework-developer mailing list Spr...@li... https://lists.sourceforge.net/lists/listinfo/springframework-developer |
