|
From: Rob H. <ro...@ca...> - 2004-11-19 10:43:25
|
All, I have posted an update on JIRA regarding these issues (which are the same) and I would appreciated everyones on input on the suggested solutions. http://opensource.atlassian.com/projects/spring/browse/SPR-472 For those of you who are unware 1.1.1 conatined a nasty bug where proxy creation, with CGLIB, would restore any default state in the target object if your constructor set this state explicitly through method calls. I fixed this 1.1.2 although annoying the fix was only partial and this problem still shows up, but only when methods called by the constructor are unadvised. Rob |
|
From: Rob H. <ro...@ca...> - 2004-11-19 11:44:46
|
All,
Chris from CGLIB replied to me on this issue:
>Hi Rob,
>
>Probably #2 ("Create a dummy object that Dispatchers can re-route to
>during construction") is the simplest solution, but I don't like it
>either. It is probably better for me to add an option to Enhancer:
>
> e.setInterceptCallsFromConstructor(false);
>
>We actually have to jump through some hoops to intercept those calls in
>the first place, so I hope it won't be hard to ignore them. You could
>then also get rid of the code you added for the previous issue.
>
>I'll look into it tomorrow (3am here now...)
>
>Chris
>
Looks like we will get a solution to this problem at the CGLIB level.
Rob
Rob Harrop wrote:
> All,
>
> I have posted an update on JIRA regarding these issues (which are the
> same) and I would appreciated everyones on input on the suggested
> solutions.
>
> http://opensource.atlassian.com/projects/spring/browse/SPR-472
>
> For those of you who are unware 1.1.1 conatined a nasty bug where
> proxy creation, with CGLIB, would restore any default state in the
> target object if your constructor set this state explicitly through
> method calls. I fixed this 1.1.2 although annoying the fix was only
> partial and this problem still shows up, but only when methods called
> by the constructor are unadvised.
>
> Rob
>
>
> -------------------------------------------------------
> This SF.Net email is sponsored by: InterSystems CACHE
> FREE OODBMS DOWNLOAD - A multidimensional database that combines
> robust object and relational technologies, making it a perfect match
> for Java, C++,COM, XML, ODBC and JDBC. www.intersystems.com/match8
> _______________________________________________
> Springframework-developer mailing list
> Spr...@li...
> https://lists.sourceforge.net/lists/listinfo/springframework-developer
>
>
|
|
From: Rod J. <ro...@in...> - 2004-11-20 08:47:25
|
i would muchy prefer a CGLIB solution. I've never been totally comfortable with workarounds in Spring. Can we defer the
resolution, adding a note? What's their timeframe?
Rob Harrop wrote:
> All,
>
> Chris from CGLIB replied to me on this issue:
>
>> Hi Rob,
>>
>> Probably #2 ("Create a dummy object that Dispatchers can re-route to
>> during construction") is the simplest solution, but I don't like it
>> either. It is probably better for me to add an option to Enhancer:
>>
>> e.setInterceptCallsFromConstructor(false);
>>
>> We actually have to jump through some hoops to intercept those calls in
>> the first place, so I hope it won't be hard to ignore them. You could
>> then also get rid of the code you added for the previous issue.
>>
>> I'll look into it tomorrow (3am here now...)
>>
>> Chris
>>
> Looks like we will get a solution to this problem at the CGLIB level.
>
> Rob
>
> Rob Harrop wrote:
>
>> All,
>>
>> I have posted an update on JIRA regarding these issues (which are the
>> same) and I would appreciated everyones on input on the suggested
>> solutions.
>>
>> http://opensource.atlassian.com/projects/spring/browse/SPR-472
>>
>> For those of you who are unware 1.1.1 conatined a nasty bug where
>> proxy creation, with CGLIB, would restore any default state in the
>> target object if your constructor set this state explicitly through
>> method calls. I fixed this 1.1.2 although annoying the fix was only
>> partial and this problem still shows up, but only when methods called
>> by the constructor are unadvised.
>>
>> Rob
>>
>>
>> -------------------------------------------------------
>> This SF.Net email is sponsored by: InterSystems CACHE
>> FREE OODBMS DOWNLOAD - A multidimensional database that combines
>> robust object and relational technologies, making it a perfect match
>> for Java, C++,COM, XML, ODBC and JDBC. www.intersystems.com/match8
>> _______________________________________________
>> Springframework-developer mailing list
>> Spr...@li...
>> https://lists.sourceforge.net/lists/listinfo/springframework-developer
>>
>>
>
>
> -------------------------------------------------------
> This SF.Net email is sponsored by: InterSystems CACHE
> FREE OODBMS DOWNLOAD - A multidimensional database that combines
> robust object and relational technologies, making it a perfect match
> for Java, C++,COM, XML, ODBC and JDBC. www.intersystems.com/match8
> _______________________________________________
> Springframework-developer mailing list
> Spr...@li...
> https://lists.sourceforge.net/lists/listinfo/springframework-developer
>
--
____________________________________________________
Rod Johnson
Interface21 - Spring Services from the Source
http://www.springframework.com
Founder, Spring Framework:
http://www.springframework.org
Author, "Expert One-on-One J2EE Development Without EJB"
(May 2004, with Juergen Hoeller).
http://www.amazon.com/exec/obidos/ASIN/0764558315/
Author, "Expert One-on-One J2EE Design and Development"
(October 2002).
http://www.amazon.com/exec/obidos/tg/detail/-/0764543857/
____________________________________________________
Interface21 Limited
Registered Office Summit House, 2-2a Highfield Road, Dartford, Kent DA1 2JY
Registered in England and Wales No. 5187766
____________________________________________________
|
|
From: Rob H. <ro...@ca...> - 2004-11-22 09:28:28
|
Just had an e-mail from Chris. He informs me that this is much more
difficult than he first thought but he should be taking serious look at
in the next few days.
Rob
Rod Johnson wrote:
> i would muchy prefer a CGLIB solution. I've never been totally
> comfortable with workarounds in Spring. Can we defer the resolution,
> adding a note? What's their timeframe?
>
> Rob Harrop wrote:
>
>> All,
>>
>> Chris from CGLIB replied to me on this issue:
>>
>>> Hi Rob,
>>>
>>> Probably #2 ("Create a dummy object that Dispatchers can re-route to
>>> during construction") is the simplest solution, but I don't like it
>>> either. It is probably better for me to add an option to Enhancer:
>>>
>>> e.setInterceptCallsFromConstructor(false);
>>>
>>> We actually have to jump through some hoops to intercept those calls in
>>> the first place, so I hope it won't be hard to ignore them. You could
>>> then also get rid of the code you added for the previous issue.
>>>
>>> I'll look into it tomorrow (3am here now...)
>>>
>>> Chris
>>>
>> Looks like we will get a solution to this problem at the CGLIB level.
>>
>> Rob
>>
>> Rob Harrop wrote:
>>
>>> All,
>>>
>>> I have posted an update on JIRA regarding these issues (which are
>>> the same) and I would appreciated everyones on input on the
>>> suggested solutions.
>>>
>>> http://opensource.atlassian.com/projects/spring/browse/SPR-472
>>>
>>> For those of you who are unware 1.1.1 conatined a nasty bug where
>>> proxy creation, with CGLIB, would restore any default state in the
>>> target object if your constructor set this state explicitly through
>>> method calls. I fixed this 1.1.2 although annoying the fix was only
>>> partial and this problem still shows up, but only when methods
>>> called by the constructor are unadvised.
>>>
>>> Rob
>>>
>>>
>>> -------------------------------------------------------
>>> This SF.Net email is sponsored by: InterSystems CACHE
>>> FREE OODBMS DOWNLOAD - A multidimensional database that combines
>>> robust object and relational technologies, making it a perfect match
>>> for Java, C++,COM, XML, ODBC and JDBC. www.intersystems.com/match8
>>> _______________________________________________
>>> Springframework-developer mailing list
>>> Spr...@li...
>>> https://lists.sourceforge.net/lists/listinfo/springframework-developer
>>>
>>>
>>
>>
>> -------------------------------------------------------
>> This SF.Net email is sponsored by: InterSystems CACHE
>> FREE OODBMS DOWNLOAD - A multidimensional database that combines
>> robust object and relational technologies, making it a perfect match
>> for Java, C++,COM, XML, ODBC and JDBC. www.intersystems.com/match8
>> _______________________________________________
>> Springframework-developer mailing list
>> Spr...@li...
>> https://lists.sourceforge.net/lists/listinfo/springframework-developer
>>
>
|