Menu
▾
▴
springframework-developer
|
From: <jue...@we...> - 2004-10-10 09:26:56
|
Rob, =20 Thanks - that's great! Does this mean that we can close this issue now? =20 http://opensource.atlassian.com/projects/spring/browse/SPR-368 =20 Juergen =20 ________________________________ Von: spr...@li... im Auftrag = von Rob Harrop Gesendet: Fr 08.10.2004 01:39 An: spr...@li... Betreff: Re: [Springframework-developer] Re: Re: CGLIB side effect Doh! I made that change and it passes all tests now. I will tidy this up a bit and then commit. Cheers Chris. Rob Chris Nokleberg wrote: >Rob Harrop wrote: >=20 > >>I took a look at your suggested workaround and I started the basics of >>an implementation. The problem I came up against is that when the >>constructor is invoked by CGLIB, which in turn invokes a method, say >>setName(), the call to invokeSuper() by the interceptor fails with: >> =20 >> > >Make sure you are passing the proxy as the first argument to = invokeSuper, >not the target. > >Also, it may be better to move the logic earlier, i.e. into >DynamicAdvisedInterceptor instead of MethodInvocationImpl. > >Chris > > > > >------------------------------------------------------- >This SF.net email is sponsored by: IT Product Guide on = ITManagersJournal >Use IT products in your business? Tell us what you think of them. Give = us >Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out = more >http://productguide.itmanagersjournal.com/guidepromo.tmpl >_______________________________________________ >Springframework-developer mailing list >Spr...@li... >https://lists.sourceforge.net/lists/listinfo/springframework-developer > > >=20 > ------------------------------------------------------- This SF.net email is sponsored by: IT Product Guide on ITManagersJournal Use IT products in your business? Tell us what you think of them. Give = us Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out = more http://productguide.itmanagersjournal.com/guidepromo.tmpl _______________________________________________ Springframework-developer mailing list Spr...@li... https://lists.sourceforge.net/lists/listinfo/springframework-developer |
|
From: Rob H. <ro...@ca...> - 2004-10-10 10:30:02
|
Jurgen, Yep, you can close this now. I have committed the change along with a test case for this problem. Rob jürgen höller [werk3AT] writes: > Rob, > > Thanks - that's great! Does this mean that we can close this issue now? > > http://opensource.atlassian.com/projects/spring/browse/SPR-368 > > Juergen > > > ________________________________ > > Von: spr...@li... im Auftrag von Rob Harrop > Gesendet: Fr 08.10.2004 01:39 > An: spr...@li... > Betreff: Re: [Springframework-developer] Re: Re: CGLIB side effect > > > > Doh! I made that change and it passes all tests now. I will tidy this up > a bit and then commit. > > Cheers Chris. > > Rob > > Chris Nokleberg wrote: > >>Rob Harrop wrote: >> >> >>>I took a look at your suggested workaround and I started the basics of >>>an implementation. The problem I came up against is that when the >>>constructor is invoked by CGLIB, which in turn invokes a method, say >>>setName(), the call to invokeSuper() by the interceptor fails with: >>> >>> >> >>Make sure you are passing the proxy as the first argument to invokeSuper, >>not the target. >> >>Also, it may be better to move the logic earlier, i.e. into >>DynamicAdvisedInterceptor instead of MethodInvocationImpl. >> >>Chris >> >> >> >> >>------------------------------------------------------- >>This SF.net email is sponsored by: IT Product Guide on ITManagersJournal >>Use IT products in your business? Tell us what you think of them. Give us >>Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more >>http://productguide.itmanagersjournal.com/guidepromo.tmpl >>_______________________________________________ >>Springframework-developer mailing list >>Spr...@li... >>https://lists.sourceforge.net/lists/listinfo/springframework-developer >> >> >> >> > > > ------------------------------------------------------- > This SF.net email is sponsored by: IT Product Guide on ITManagersJournal > Use IT products in your business? Tell us what you think of them. Give us > Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more > http://productguide.itmanagersjournal.com/guidepromo.tmpl > _______________________________________________ > Springframework-developer mailing list > Spr...@li... > https://lists.sourceforge.net/lists/listinfo/springframework-developer > > > > > ------------------------------------------------------- > This SF.net email is sponsored by: IT Product Guide on ITManagersJournal > Use IT products in your business? Tell us what you think of them. Give us > Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more > http://productguide.itmanagersjournal.com/guidepromo.tmpl > _______________________________________________ > Springframework-developer mailing list > Spr...@li... > https://lists.sourceforge.net/lists/listinfo/springframework-developer |
|
From: Rob H. <ro...@ca...> - 2004-10-12 09:15:48
|
Jurgen, This is now fixed and committed. Rob jürgen höller [werk3AT] wrote: >Rob, > >Thanks - that's great! Does this mean that we can close this issue now? > >http://opensource.atlassian.com/projects/spring/browse/SPR-368 > >Juergen > > >________________________________ > >Von: spr...@li... im Auftrag von Rob Harrop >Gesendet: Fr 08.10.2004 01:39 >An: spr...@li... >Betreff: Re: [Springframework-developer] Re: Re: CGLIB side effect > > > >Doh! I made that change and it passes all tests now. I will tidy this up >a bit and then commit. > >Cheers Chris. > >Rob > >Chris Nokleberg wrote: > > > >>Rob Harrop wrote: >> >> >> >> >>>I took a look at your suggested workaround and I started the basics of >>>an implementation. The problem I came up against is that when the >>>constructor is invoked by CGLIB, which in turn invokes a method, say >>>setName(), the call to invokeSuper() by the interceptor fails with: >>> >>> >>> >>> >>Make sure you are passing the proxy as the first argument to invokeSuper, >>not the target. >> >>Also, it may be better to move the logic earlier, i.e. into >>DynamicAdvisedInterceptor instead of MethodInvocationImpl. >> >>Chris >> >> >> >> >>------------------------------------------------------- >>This SF.net email is sponsored by: IT Product Guide on ITManagersJournal >>Use IT products in your business? Tell us what you think of them. Give us >>Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more >>http://productguide.itmanagersjournal.com/guidepromo.tmpl >>_______________________________________________ >>Springframework-developer mailing list >>Spr...@li... >>https://lists.sourceforge.net/lists/listinfo/springframework-developer >> >> >> >> >> >> > > >------------------------------------------------------- >This SF.net email is sponsored by: IT Product Guide on ITManagersJournal >Use IT products in your business? Tell us what you think of them. Give us >Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more >http://productguide.itmanagersjournal.com/guidepromo.tmpl >_______________________________________________ >Springframework-developer mailing list >Spr...@li... >https://lists.sourceforge.net/lists/listinfo/springframework-developer > > > > >------------------------------------------------------- >This SF.net email is sponsored by: IT Product Guide on ITManagersJournal >Use IT products in your business? Tell us what you think of them. Give us >Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more >http://productguide.itmanagersjournal.com/guidepromo.tmpl >_______________________________________________ >Springframework-developer mailing list >Spr...@li... >https://lists.sourceforge.net/lists/listinfo/springframework-developer > > > > |
