springframework-developer

[Springframework-developer] JdbcUtils.extractDatabaseMetaData

[<jue...@we...>]

Thomas,
=20
The javadoc of JdbcUtils.extractDatabaseMetaData says that the method =
will never throw an exception, but it still throws a =
MetaDataAccessException on any kind of failure. Shouldn't it simply log =
exceptions and return null?
=20
Furthermore, why is the DatabaseMetaDataCallbackHandler interface in the =
jdbc.core package? It is just used in the jdbc.support package, which =
shouldn't depend on jdbc.core (just the other way round). Consequently, =
I suggest to move it to jdbc.support.
=20
Juergen
=20

Re: [Springframework-developer] JdbcUtils.extractDatabaseMetaData

[Thomas R. <tho...@tr...>]

> 
>The javadoc of JdbcUtils.extractDatabaseMetaData says that the method will never throw an exception, but it still throws a MetaDataAccessException on any kind of failure. Shouldn't it simply log exceptions and return null?
>  
>
That must have been an old comment that I forgot to change.  I have 
modified it to reflect that this method does throw a checked exception 
since we can't rely on the exception translation to be initialized when 
this method is called.  This method is infrequently used and I'd rather 
force the use of a catch block instead of relying on calling code to 
check for a null returned.

> 
>Furthermore, why is the DatabaseMetaDataCallbackHandler interface in the jdbc.core package? It is just used in the jdbc.support package, which shouldn't depend on jdbc.core (just the other way round). Consequently, I suggest to move it to jdbc.support.
> 
>  
>
Good point.  I have moved it.

Thomas