springframework-developer

[Springframework-developer] proposal for jstlview

[Seth L. <se...@eh...>]

Hello,

I looked through the code for JstlView, and it does not set the 
content-type passed to it via AbstractView.  The javadocs for 
setContentType state that it might be ignored by subclasses.

I'd like to propose that JstlView ignores that value if its null, or if 
not null, it should use it.  I think it makes sense that if 
setContentType is called to a View, then the View should use it.  If 
it's null, then go ahead and ignore it.  Is that a fair request?

I can easily provide a patch if others agree with this.

Thanks!
Seth

Re: [Springframework-developer] proposal for jstlview

[Seth L. <se...@eh...>]

Seth Ladd wrote:
> Hello,
> 
> I looked through the code for JstlView, and it does not set the 
> content-type passed to it via AbstractView.  The javadocs for 
> setContentType state that it might be ignored by subclasses.
> 
> I'd like to propose that JstlView ignores that value if its null, or if 
> not null, it should use it.  I think it makes sense that if 
> setContentType is called to a View, then the View should use it.  If 
> it's null, then go ahead and ignore it.  Is that a fair request?

Ahh... never mind, I see why it is ignored.  It seems that even if you 
set response.setContentType(), the JSP will ignore it and look for the 
content type given in the <%@ page %> declaration.

sigh

Thanks, though,
Seth