springframework-developer

Re: [Springframework-developer] AbstractSingleBeanDefinitionParser and Child Beans

[Sam B. <sam...@in...>]

Hi Stefan,
 
> recently I wanted to write a BeanDefinitionParser that creates child
> beans.  All the reasons to use AbstractSingleBeanDefinitionParser
> apply in my case, but there is no way to create child beans since the
> class doesn't account for it.
> 
> I ended up writing my own AbstractBeanDefinitionParser subclass that
> was a 1:1 copy of AbstractSingleBeanDefinitionParser with just a few
> changes:
> 
> ...
> 
> Of course I don't like repeating the code of parseInternal in my own
> class.  Is there a simpler way?  Or alternatively could
> AbstractSingleBeanDefinitionParser be opened up (my pretty simple
> patch would be available if you think you want it).

If you feel that this functionality would be a worthy addition to
the Spring Framework, please create a new JIRA issue in the Spring 
Framework project and include your original comments to the mailing 
list along with your code (if you wish to share it). Here's a link 
to JIRA:

http://opensource.atlassian.com/projects/spring/browse/SPR

Regards,

  Sam

--
Sam Brannen
Senior Software Engineer
Interface21 Limited
http://www.interface21.com

Re: [Springframework-developer] AbstractSingleBeanDefinitionParser and Child Beans

[Stefan B. <ste...@fr...>]

Hi Sam,

On Mon, 3 Sep 2007, Sam Brannen <sam...@in...> wrote:

>> Of course I don't like repeating the code of parseInternal in my
>> own class.  Is there a simpler way?  Or alternatively could
>> AbstractSingleBeanDefinitionParser be opened up (my pretty simple
>> patch would be available if you think you want it).
> 
> If you feel that this functionality would be a worthy addition to
> the Spring Framework, please create a new JIRA issue in the Spring 
> Framework project and include your original comments to the mailing 
> list along with your code (if you wish to share it).

Done.  SPR-3867 and SPR-3868.

I'm more familiar with the ASF way of doing open source and thought
you might want to discuss the merits of the patch before I created an
issue, that's why I didn't go there directly.

Thanks

        Stefan