|
From: Kopylenko, D. <dko...@ac...> - 2004-03-12 16:39:47
|
Sounds reasonable to me...
-----Original Message-----
From: Darren Davison [mailto:da...@da...]
Sent: Friday, March 12, 2004 11:16 AM
To: spr...@li...
Subject: [Springframework-developer] postHandle for Interceptors
If a controller handles the response completely it should return a null
ModelAndView to the dispatcher to indicate as such and prevent the
dispatcher attempting to render a view.
In such a case, is it appropriate that the dispatcher still attempts to call
the postHandle() method of any Interceptors in the chain? It seems
redundant to me - it also means every postHandle() method in every
Interceptor implementation has to explicitly check for a null MAV to avoid
throwing an NPE.
I'm unsure if there are valid use cases that would require a postHandle() to
execute if the controller has fully handled the response (ie with a
response.sendError(...)
How about amending line 381 of DispatcherServlet thus:
if (mappedHandler.getInterceptors() != null && mv != null) {
--
Darren Davison
Public Key: http://www.davison.uk.net/key.jsp
-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of GenToo
technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id70&alloc_id638&op=click
_______________________________________________
Springframework-developer mailing list
Spr...@li...
https://lists.sourceforge.net/lists/listinfo/springframework-developer
|
|
From: <jue...@we...> - 2004-03-12 19:02:51
|
I can imagine valid use cases for a HandlerInterceptor doing stuff after =
the handler returned a null ModelAndView. I think it's better to force =
HandlerInterceptors to check for a null ModelAndView rather than to =
restrict the power of this interceptor concept.
=20
Juergen
=20
________________________________
Von: spr...@li... im Auftrag =
von Darren Davison
Gesendet: Fr 12.03.2004 17:16
An: spr...@li...
Betreff: [Springframework-developer] postHandle for Interceptors
If a controller handles the response completely it should return a null
ModelAndView to the dispatcher to indicate as such and prevent the
dispatcher attempting to render a view.
In such a case, is it appropriate that the dispatcher still attempts to
call the postHandle() method of any Interceptors in the chain? It seems
redundant to me - it also means every postHandle() method in every
Interceptor implementation has to explicitly check for a null MAV to =
avoid
throwing an NPE.
I'm unsure if there are valid use cases that would require a =
postHandle()
to execute if the controller has fully handled the response (ie with a
response.sendError(...)
How about amending line 381 of DispatcherServlet thus:
if (mappedHandler.getInterceptors() !=3D null && mv !=3D null) {
--
Darren Davison
Public Key: http://www.davison.uk.net/key.jsp
-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id638&op=3Dick
_______________________________________________
Springframework-developer mailing list
Spr...@li...
https://lists.sourceforge.net/lists/listinfo/springframework-developer
|
|
From: Darren D. <da...@da...> - 2004-03-12 20:51:54
|
=2D----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Friday 12 March 2004 18:45, j=FCrgen h=F6ller [werk3AT] wrote: > I can imagine valid use cases for a HandlerInterceptor doing stuff after > the handler returned a null ModelAndView. I tried to think of stuff earlier before sending the mail about it, but=20 couldn't really come up with anything based on my own experience. What=20 kind of scenarios do you have in mind out of interest? =2D --=20 Darren Davison Public Key: http://www.davison.uk.net/key.jsp =2D----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (GNU/Linux) iD8DBQFAUh53KLMLAN01aw0RArxBAJ9qeUmniRunNeUB40Bv6bqPhWWw0wCdHG/9 sOOG0+ZC/1abohMYsSAEDFU=3D =3DmQRf =2D----END PGP SIGNATURE----- |
|
From: <jue...@we...> - 2004-03-12 22:32:50
|
A simple example: auditing. You'd want to be able to log the successful = execution of a handler, no matter if it returned a ModelAndView or wrote = output itself. =20 Juergen =20 ________________________________ Von: spr...@li... im Auftrag = von Darren Davison Gesendet: Fr 12.03.2004 21:32 An: spr...@li... Betreff: Re: [Springframework-developer] postHandle for Interceptors -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Friday 12 March 2004 18:45, j=FCrgen h=F6ller [werk3AT] wrote: > I can imagine valid use cases for a HandlerInterceptor doing stuff = after > the handler returned a null ModelAndView. I tried to think of stuff earlier before sending the mail about it, but couldn't really come up with anything based on my own experience. What kind of scenarios do you have in mind out of interest? - -- Darren Davison Public Key: http://www.davison.uk.net/key.jsp -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (GNU/Linux) iD8DBQFAUh53KLMLAN01aw0RArxBAJ9qeUmniRunNeUB40Bv6bqPhWWw0wCdHG/9 sOOG0+ZC/1abohMYsSAEDFU=3D =3DmQRf -----END PGP SIGNATURE----- ------------------------------------------------------- This SF.Net email is sponsored by: IBM Linux Tutorials Free Linux tutorial presented by Daniel Robbins, President and CEO of GenToo technologies. Learn everything from fundamentals to system administration.http://ads.osdn.com/?ad_id=1470&alloc_id638&op=3Dick _______________________________________________ Springframework-developer mailing list Spr...@li... https://lists.sourceforge.net/lists/listinfo/springframework-developer |
|
From: Mark P. <mar...@co...> - 2004-03-12 22:51:27
|
Hi, I've added two packages to the sandbox: selector and service. I've also added a docs directory. You can find a description (in progress) in sandbox/docs/sandbox-reference.pdf In the coming week I'll work with Andre on the JMS part. I plan on = adding a 'JMSReactor' which is a message listener that uses the selector package = or organize the processing of messages. The code I have already is for creating stand-alone JMS apps and a fa=E7ade for sending messages. With = some small modifications these can also be used inside an container.... FYI, I also have a simple JMX service that is basically a wrapper to the commons modeler with class instances coming from the spring app context. I'll also look at Ivan Ristic's classes posted a while ago on this topic = and see what kind of JMX functionality I can come up with to kick start the = JMX development. Cheers, Mark |
|
From: Keith D. <kd...@cs...> - 2004-03-12 23:12:34
|
Mark, Regarding JMX I think have almost exactly the same thing :-) - a service = to lookup MBeanInfo declarations via a MBeanInfoDatabase backed by jakarta modeler, and then services to instantiate model mbeans for POJOs at = runtime in a MBeanServer, which is also configured externally (and optionally decorated with adaptors and connectors for remote management via JSR = 160.) I've also got a strategy for object naming based on JSR-77 standards = (and a little CIM like, too.) My initial code to work from is pretty good, but it much of it was = written before I was a spring monkey so for me I've got a good deal of = repackaging to do as well as some issues that need to be ironed out (like what about support for standard mbeans, how do we want to store mbean metadata = (modeler or no modeler, attributes, etc.) Ivan's stuff looked good since he had already taken the next step with the BeanPostProcessor...=20 Maybe I can send you some of the stuff I have and we can collaborate? = Cool, yea, jumpstarting this would be great. Thanks! Keith -----Original Message----- From: spr...@li... [mailto:spr...@li...] On Behalf = Of Mark Pollack Sent: Friday, March 12, 2004 5:29 PM To: spr...@li... Subject: [Springframework-developer] Sandbox additions. Hi, I've added two packages to the sandbox: selector and service. I've also added a docs directory. You can find a description (in progress) in sandbox/docs/sandbox-reference.pdf In the coming week I'll work with Andre on the JMS part. I plan on = adding a 'JMSReactor' which is a message listener that uses the selector package = or organize the processing of messages. The code I have already is for creating stand-alone JMS apps and a fa=E7ade for sending messages. With = some small modifications these can also be used inside an container.... FYI, I also have a simple JMX service that is basically a wrapper to the commons modeler with class instances coming from the spring app context. I'll also look at Ivan Ristic's classes posted a while ago on this topic = and see what kind of JMX functionality I can come up with to kick start the = JMX development. Cheers, Mark ------------------------------------------------------- This SF.Net email is sponsored by: IBM Linux Tutorials Free Linux tutorial presented by Daniel Robbins, President and CEO of = GenToo technologies. Learn everything from fundamentals to system administration.http://ads.osdn.com/?ad_id=1470&alloc_id638&op=CCk _______________________________________________ Springframework-developer mailing list Spr...@li... https://lists.sourceforge.net/lists/listinfo/springframework-developer |
|
From: Mark P. <Mar...@Co...> - 2004-03-13 15:11:51
|
Hi, Actually it sounds like you might have done a bit more than I have. Sure= , send it on over! - Mark > Mark, > > Regarding JMX I think have almost exactly the same thing :-) - a servic= e > to > lookup MBeanInfo declarations via a MBeanInfoDatabase backed by jakarta > modeler, and then services to instantiate model mbeans for POJOs at > runtime > in a MBeanServer, which is also configured externally (and optionally > decorated with adaptors and connectors for remote management via JSR 16= 0.) > I've also got a strategy for object naming based on JSR-77 standards (a= nd > a > little CIM like, too.) > > My initial code to work from is pretty good, but it much of it was writ= ten > before I was a spring monkey so for me I've got a good deal of repackag= ing > to do as well as some issues that need to be ironed out (like what abou= t > support for standard mbeans, how do we want to store mbean metadata > (modeler > or no modeler, attributes, etc.) Ivan's stuff looked good since he had > already taken the next step with the BeanPostProcessor... > > Maybe I can send you some of the stuff I have and we can collaborate? > Cool, > yea, jumpstarting this would be great. > Thanks! Keith > > -----Original Message----- > From: spr...@li... > [mailto:spr...@li...] On Behal= f > Of > Mark Pollack > Sent: Friday, March 12, 2004 5:29 PM > To: spr...@li... > Subject: [Springframework-developer] Sandbox additions. > > > Hi, > > I've added two packages to the sandbox: selector and service. I've als= o > added a docs directory. You can find a description (in progress) in > sandbox/docs/sandbox-reference.pdf > > In the coming week I'll work with Andre on the JMS part. I plan on add= ing > a > 'JMSReactor' which is a message listener that uses the selector package= or > organize the processing of messages. The code I have already is for > creating stand-alone JMS apps and a fa=E7ade for sending messages. Wit= h > some > small modifications these can also be used inside an container.... > > FYI, I also have a simple JMX service that is basically a wrapper to th= e > commons modeler with class instances coming from the spring app context. > I'll also look at Ivan Ristic's classes posted a while ago on this topi= c > and > see what kind of JMX functionality I can come up with to kick start the > JMX > development. > > Cheers, > Mark > > > > > ------------------------------------------------------- > This SF.Net email is sponsored by: IBM Linux Tutorials > Free Linux tutorial presented by Daniel Robbins, President and CEO of > GenToo > technologies. Learn everything from fundamentals to system > administration.http://ads.osdn.com/?ad_id=1470&alloc_id638&op=CCk > _______________________________________________ > Springframework-developer mailing list > Spr...@li... > https://lists.sourceforge.net/lists/listinfo/springframework-developer > > > > ------------------------------------------------------- > This SF.Net email is sponsored by: IBM Linux Tutorials > Free Linux tutorial presented by Daniel Robbins, President and CEO of > GenToo technologies. Learn everything from fundamentals to system > administration.http://ads.osdn.com/?ad_id=1470&alloc_id638&op=CCk > _______________________________________________ > Springframework-developer mailing list > Spr...@li... > https://lists.sourceforge.net/lists/listinfo/springframework-developer > > |