springframework-developer — Spring Framework developers list

Re: [Springframework-developer] potential JdbcTemplate bug

[<tri...@tr...>]

Rod & Trevor,

After a closer look I'm convince that Trevor is right - the finally block is the
safest place to close all resources.  Did not consider non SQLExceptions, but as
you point out, they would not be caught and we could leave resultsets open.

Thomas

> Trevor
> 
> I think you're right, although I wasn't responsible for the current error
> handling and am probably not best placed to comment.
> 
> I guess the first thing is break the current code with more rigorous tests,
> which you seem to have done, before trying any changes.
> 
> Regards,
> Rod
> 
> ----- Original Message ----- 
> From: "Trevor Cook" <pr...@se...>
> To: "Spring Developers" <spr...@li...>
> Sent: Monday, September 22, 2003 2:39 AM
> Subject: [Springframework-developer] potential JdbcTemplate bug
> 
> 
> > I'm currently rewriting some of the tests for the jdbc package, and I have
> > encountered a potential problem.  Specifically, in the JdbcTemplate
> > "doWithResultSetFromPreparedQuery" method, exception handling does not
> > appear to always work.  Recently changes were made which placed various
> > "close" calls in a catch (SQLException) block.  However, if a Spring
> > exception is thrown (I noticed this by running a SqlFunction which
> returned
> > more than 1 row, thus throwing an "InvalidDataAccessApiUsageException")
> the
> > "SQLException" catch is NOT called, and the method exits without closing
> > resultset/preparedstatements, etc.  Note that while I noticed this in the
> > single method, this behaviour permeates the JdbcTemplate.
> >
> > The current ("paraphrased") code is:
> >
> > <code>
> > try {
> > ... various code ...
> > SQLWarning warning = ps.getWarnings();
> > rs.close();
> > ps.close();
> > throwExceptionOnWarningIfNotIgnoringWarnings(warning);
> > } catch (SQLException ex) {
> > if (rs != null) {
> > try {
> > rs.close();
> > } catch (SQLException ignore) {}
> > }
> > if (ps != null) {
> > try {
> > ps.close();
> > } catch (SQLException ignore) {}
> > }
> > throw getExceptionTranslator().translate("JdbcTemplate.query(psc) with
> > PreparedStatementCreator [" + psc + "]", null, ex);
> > } finally {
> > DataSourceUtils.closeConnectionIfNecessary(con, this.dataSource);
> > }
> > </code>
> >
> > I propose changing it to:
> >
> > <code>
> > try {
> > ... various code ...
> > SQLWarning warning = ps.getWarnings();
> > throwExceptionOnWarningIfNotIgnoringWarnings(warning);
> > } catch (SQLException ex) {
> > throw getExceptionTranslator().translate("JdbcTemplate.query(psc) with
> > PreparedStatementCreator [" + psc + "]", null, ex);
> > } finally {
> > if (rs != null) {
> > try {
> > rs.close();
> > } catch (SQLException ignore) {}
> > }
> > if (ps != null) {
> > try {
> > ps.close();
> > } catch (SQLException ignore) {}
> > }
> > DataSourceUtils.closeConnectionIfNecessary(con, this.dataSource);
> > }
> > </code>
> >
> > I believe this will ensure resources are closed regardless of
> > success/failure, and still allow Spring exceptions and "translated"
> > SQLExceptions to propogate as designed.  If anyone sees any holes in this
> > (specifically Rod/Thomas who I believe have done the most work on the jdbc
> > packages) please let me know.  Otherwise (and barring exceptions) I will
> > make the changes and commit them with the updated tests tomorrow.
> >
> > Trevor D. Cook
> >
> >
> >
> > -------------------------------------------------------
> > This sf.net email is sponsored by:ThinkGeek
> > Welcome to geek heaven.
> > http://thinkgeek.com/sf
> > _______________________________________________
> > Springframework-developer mailing list
> > Spr...@li...
> > https://lists.sourceforge.net/lists/listinfo/springframework-developer
> 
> 
> 
> -------------------------------------------------------
> This sf.net email is sponsored by:ThinkGeek
> Welcome to geek heaven.
> http://thinkgeek.com/sf
> _______________________________________________
> Springframework-developer mailing list
> Spr...@li...
> https://lists.sourceforge.net/lists/listinfo/springframework-developer
> 

RE: [Springframework-developer] Test coverage

[Alef A. \(JTeam\) <al...@jt...>]

If nobody's busy doing it already, I'll see what I can do on the
javamail package. I've got a devnull mailer lying around somewhere that
we use for testing, maybe I can integrate it somehow... 

By the way, up to 76,7 now...

Alef

-----Oorspronkelijk bericht-----
Van: spr...@li...
[mailto:spr...@li...] Namens
Rod Johnson
Verzonden: Saturday, September 20, 2003 11:17 PM
Aan: spr...@li...
Onderwerp: [Springframework-developer] Test coverage


I think one of the things that has contributed to the success and
quality of Spring is our commitment to a good test suite. I've put a
fair bit more work into the test suite over the weekend, with the
upgrade to EasyMock 1.0 and new test suites for Velocity etc.

I'm really pleased that everyone is emphasising tests in new coding, but
there is a still a bit of catchup to do.

With this and Alef's new tag tests, test coverage is now 75.8%. I'd like
to see this go above 80% before 1.0RC1.

So I think we should all kick in and add tests to our areas of interest.
Please run the Clover analysis as a starting point.

Current major gaps include:
- XSLT support. I wrote this code so I guess I really should do the
tests but I'm not sure I have time. (These days I work entirely test
first, but I wrote that last year.) If any of the dev team are using
this, maybe they could take a look? It might require some refactoring.
- jdbc.core.support: No tests for incrementer support. Can the
developers looking after this please try to add some tests?

Any volunteers for these or other areas in which tests can be improved?

Regards,
Rod



-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf _______________________________________________
Springframework-developer mailing list
Spr...@li...
https://lists.sourceforge.net/lists/listinfo/springframework-developer

Re: [Springframework-developer] potential JdbcTemplate bug

[Rod J. <rod...@in...>]

Trevor

I think you're right, although I wasn't responsible for the current error
handling and am probably not best placed to comment.

I guess the first thing is break the current code with more rigorous tests,
which you seem to have done, before trying any changes.

Regards,
Rod

----- Original Message ----- 
From: "Trevor Cook" <pr...@se...>
To: "Spring Developers" <spr...@li...>
Sent: Monday, September 22, 2003 2:39 AM
Subject: [Springframework-developer] potential JdbcTemplate bug


> I'm currently rewriting some of the tests for the jdbc package, and I have
> encountered a potential problem.  Specifically, in the JdbcTemplate
> "doWithResultSetFromPreparedQuery" method, exception handling does not
> appear to always work.  Recently changes were made which placed various
> "close" calls in a catch (SQLException) block.  However, if a Spring
> exception is thrown (I noticed this by running a SqlFunction which
returned
> more than 1 row, thus throwing an "InvalidDataAccessApiUsageException")
the
> "SQLException" catch is NOT called, and the method exits without closing
> resultset/preparedstatements, etc.  Note that while I noticed this in the
> single method, this behaviour permeates the JdbcTemplate.
>
> The current ("paraphrased") code is:
>
> <code>
> try {
> ... various code ...
> SQLWarning warning = ps.getWarnings();
> rs.close();
> ps.close();
> throwExceptionOnWarningIfNotIgnoringWarnings(warning);
> } catch (SQLException ex) {
> if (rs != null) {
> try {
> rs.close();
> } catch (SQLException ignore) {}
> }
> if (ps != null) {
> try {
> ps.close();
> } catch (SQLException ignore) {}
> }
> throw getExceptionTranslator().translate("JdbcTemplate.query(psc) with
> PreparedStatementCreator [" + psc + "]", null, ex);
> } finally {
> DataSourceUtils.closeConnectionIfNecessary(con, this.dataSource);
> }
> </code>
>
> I propose changing it to:
>
> <code>
> try {
> ... various code ...
> SQLWarning warning = ps.getWarnings();
> throwExceptionOnWarningIfNotIgnoringWarnings(warning);
> } catch (SQLException ex) {
> throw getExceptionTranslator().translate("JdbcTemplate.query(psc) with
> PreparedStatementCreator [" + psc + "]", null, ex);
> } finally {
> if (rs != null) {
> try {
> rs.close();
> } catch (SQLException ignore) {}
> }
> if (ps != null) {
> try {
> ps.close();
> } catch (SQLException ignore) {}
> }
> DataSourceUtils.closeConnectionIfNecessary(con, this.dataSource);
> }
> </code>
>
> I believe this will ensure resources are closed regardless of
> success/failure, and still allow Spring exceptions and "translated"
> SQLExceptions to propogate as designed.  If anyone sees any holes in this
> (specifically Rod/Thomas who I believe have done the most work on the jdbc
> packages) please let me know.  Otherwise (and barring exceptions) I will
> make the changes and commit them with the updated tests tomorrow.
>
> Trevor D. Cook
>
>
>
> -------------------------------------------------------
> This sf.net email is sponsored by:ThinkGeek
> Welcome to geek heaven.
> http://thinkgeek.com/sf
> _______________________________________________
> Springframework-developer mailing list
> Spr...@li...
> https://lists.sourceforge.net/lists/listinfo/springframework-developer

[Springframework-developer] potential JdbcTemplate bug

[Trevor C. <pr...@se...>]

I'm currently rewriting some of the tests for the jdbc package, and I have
encountered a potential problem.  Specifically, in the JdbcTemplate
"doWithResultSetFromPreparedQuery" method, exception handling does not
appear to always work.  Recently changes were made which placed various
"close" calls in a catch (SQLException) block.  However, if a Spring
exception is thrown (I noticed this by running a SqlFunction which returned
more than 1 row, thus throwing an "InvalidDataAccessApiUsageException") the
"SQLException" catch is NOT called, and the method exits without closing
resultset/preparedstatements, etc.  Note that while I noticed this in the
single method, this behaviour permeates the JdbcTemplate.

The current ("paraphrased") code is:

<code>
try {
	... various code ...
	SQLWarning warning = ps.getWarnings();
	rs.close();
	ps.close();
	throwExceptionOnWarningIfNotIgnoringWarnings(warning);
} catch (SQLException ex) {
	if (rs != null) {
		try {
			rs.close();
		} catch (SQLException ignore) {}
	}
	if (ps != null) {
		try {
			ps.close();
		} catch (SQLException ignore) {}
	}
	throw getExceptionTranslator().translate("JdbcTemplate.query(psc) with
PreparedStatementCreator [" + psc + "]", null, ex);
} finally {
	DataSourceUtils.closeConnectionIfNecessary(con, this.dataSource);
}
</code>

I propose changing it to:

<code>
try {
	... various code ...
	SQLWarning warning = ps.getWarnings();
	throwExceptionOnWarningIfNotIgnoringWarnings(warning);
} catch (SQLException ex) {
	throw getExceptionTranslator().translate("JdbcTemplate.query(psc) with
PreparedStatementCreator [" + psc + "]", null, ex);
} finally {
	if (rs != null) {
		try {
			rs.close();
		} catch (SQLException ignore) {}
	}
	if (ps != null) {
		try {
			ps.close();
		} catch (SQLException ignore) {}
	}
	DataSourceUtils.closeConnectionIfNecessary(con, this.dataSource);
}
</code>

I believe this will ensure resources are closed regardless of
success/failure, and still allow Spring exceptions and "translated"
SQLExceptions to propogate as designed.  If anyone sees any holes in this
(specifically Rod/Thomas who I believe have done the most work on the jdbc
packages) please let me know.  Otherwise (and barring exceptions) I will
make the changes and commit them with the updated tests tomorrow.

Trevor D. Cook

Re: [Springframework-developer] Re: Anonymous CVS access via Eclipse 3.0M3

[Colin S. <col...@ex...>]

There is actually another advantage to using the alternate server. It 
doesn't seem to be 24-hour delayed like the general anonymous server. 
Now I'm not sure SF wants this known, but on the other hand, they made 
the address of the alternate server public, and their upgraded CVS 
infrastructure is supposedly only days away from being deployed, so 
anybody that needs up to day anon CVS access may as well use the 
alternate servers.


Mark McNally wrote:

>Colin, 
>
>Thank you for the tip. Via the alternate server, I can again access the
>repository via eclipse. 
>
>I also installed Tortoise out of curiosity - very nice.
>
>Mark
>
>-----Original Message-----
>From: spr...@li...
>[mailto:spr...@li...] On Behalf
>Of Colin Sampaleanu
>Sent: Wednesday, September 17, 2003 10:43 PM
>To: Mark McNally
>Cc: spr...@li...
>Subject: Re: [Springframework-developer] Re: Anonymous CVS access via
>Eclipse 3.0M3
>
>Mark,
>
>Give TortoiseCVS a try as well:
>  http://www.tortoisecvs.org/
>It is integrated into Windows Explorer, and frankly, while I do use the 
>Eclipse CVS integration when I am in Eclipse, I find Tortoise can do 
>everything else the rest of the time, and works great.
>
>As for problems with CVS access to SourceForge from Eclipse, I think 
>this is due to the different timeout values that various clients have. 
>Eclipse seems to have a pretty low timeout, while command-line cvs will 
>work in the same circumstances. SF is at fault in any case, but until 
>they resolve the situation, what you may try doing is hitting the 
>'alternate' servers available via port 80, as described here. I find 
>them much more responsive:
>
>  
>http://sourceforge.net/docman/display_doc.php?docid=14033&group_id=1#fir
>ewall
>
>
>Mark McNally wrote:
>
>  
>
>>Rod and Rajeev, Thank you for your responses. I am back in business
>>    
>>
>now!
>  
>
>>I have kept my Eclipse 3.0M3 installation but am now using a separate 
>>cvs client.  I actually tried two different programs WinCVS and 
>>SmartCVS and, so far, have found SmartCVS - http://www.smartcvs.com/ -
>>    
>>
>
>  
>
>>to be much easier to setup and use.
>>
>>Mark
>>    
>>

[Springframework-developer] Mockup/Test classes in separate jar?

[Alef A. \(JTeam\) <al...@jt...>]

Hi all,

When testing applications, it might be handy for users (like me) to have
some mockup context classes available. This would include classes like
StaticApplicationContext and StatisWebApplicationContext. Maybe adding a
separate ant-target that creates a jar with mockup classes is an idea?

What do you think?

Alef

==
JTeam B.V.
Donker Curtiusstraat 7-412
1051 JL  Amsterdam
T: +31 20 486 20 36
M: +31 6 24 11 1996
F: +31 84 837 00 00
E: al...@jt...
W: www.jteam.nl

Re: [Springframework-developer] Test coverage

[Darren D. <da...@da...>]

On Saturday 20 September 2003 22:16, Rod Johnson wrote:

> Current major gaps include:
> - XSLT support. I wrote this code so I guess I really should do the tests
> but I'm not sure I have time. (These days I work entirely test first, but I
> wrote that last year.) If any of the dev team are using this, maybe they
> could take a look? It might require some refactoring.

I may be able to help out a little on this next week.  Although I've switched 
mostly to Velocity, I was using XSLT support a lot recently.

-- 

Darren Davison
Public Key: http://www.davison.uk.net/key.jsp

[Springframework-developer] Test coverage

[Rod J. <rod...@in...>]

I think one of the things that has contributed to the success and quality of
Spring is our commitment to a good test suite. I've put a fair bit more work
into the test suite over the weekend, with the upgrade to EasyMock 1.0 and
new test suites for Velocity etc.

I'm really pleased that everyone is emphasising tests in new coding, but
there is a still a bit of catchup to do.

With this and Alef's new tag tests, test coverage is now 75.8%. I'd like to
see this go above 80% before 1.0RC1.

So I think we should all kick in and add tests to our areas of interest.
Please run the Clover analysis as a starting point.

Current major gaps include:
- XSLT support. I wrote this code so I guess I really should do the tests
but I'm not sure I have time. (These days I work entirely test first, but I
wrote that last year.) If any of the dev team are using this, maybe they
could take a look? It might require some refactoring.
- jdbc.core.support: No tests for incrementer support. Can the developers
looking after this please try to add some tests?

Any volunteers for these or other areas in which tests can be improved?

Regards,
Rod

RE: [Springframework-developer] Mock objects

[Trevor C. <pr...@se...>]

I've started modifying the jdbc tests.  I'll post when they're
ready/committed.

T

-----Original Message-----
From: spr...@li...
[mailto:spr...@li...]On Behalf
Of Rod Johnson
Sent: September 19, 2003 7:21 AM
To: spr...@li...
Subject: [Springframework-developer] Mock objects


All,

I've just upgraded from EasyMock 0.8 to 1.0.

See the bottom of http://www.easymock.org/Documentation.html for the new
features, and why doing this was worthwhile.

I've upgraded the Jar (same name, so no project changes needed).

I've also needed to change a number of test classes because of tighter
behaviour in 1.0. For example, some tests incorrectly used
setReturnValue(null) instead of setVoidCallable().

Also the JdbcTemplate tests needed changing to allow more than one call to
DataSource.getConnection(). Thomas, I assume this is to get the metadata to
be able to look up error codes?

There are still a lot of deprecations. However, I think we can live with
these and gradually update the code to get rid of them.

The principal updates to remove the deprecations are:

- EasyMock.controlFor() should change to MockControl.createControl()
- mockControl.activate() => replay()
- remove import of EasyMock

I've only made these changes in tests I otherwise needed to change. I may
try a global replace later today.

We still need to upgrade from Mock Object 0.07 to 0.09. However, this breaks
a number of the JDBC tests, which I don't have time to look at now. Any
volunteers? (Trevor? I think this breaks some of your code.)

Regards,
Rod



-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
_______________________________________________
Springframework-developer mailing list
Spr...@li...
https://lists.sourceforge.net/lists/listinfo/springframework-developer

---
Incoming mail is certified Virus Free.
Checked by AVG anti-virus system (http://www.grisoft.com).
Version: 6.0.512 / Virus Database: 309 - Release Date: 19/08/2003

RE: [Springframework-developer] Mock Objects

[Trevor C. <pr...@se...>]

We do the same thing with plain ant and "default.properties".

T

-----Original Message-----
From: spr...@li...
[mailto:spr...@li...]On Behalf
Of Colin Sampaleanu
Sent: September 20, 2003 3:25 PM
To: Rod Johnson
Cc: spr...@li...
Subject: Re: [Springframework-developer] Mock Objects


btw, I don't know if it's worth making a change, but more often than 
not, the general practice with ant projects and maven projects that I've 
seen is to have build.properties be a file which is not checked into CVS 
(sometimes there is a build.properties.sample checked in), with this 
file used for developer specific overrides. Maven adds an optional 
project.properties file, which generally _is_ checked in if it exists. 
Properties from project.properties are overriden by properties from 
build.properties.

I'm a big fan of consistency where it doesn't hurt anything, so maybe it 
makes sense to rename build.properties to project.properties, and have 
something like this at the top of the build.xml file

  <!-- Load local and user build preferences -->
  <property file="${user.home}/build.properties"/>
  <property file="build.properties"/>
  <property file="project.properties"/>

This is consistent with Maven's order, although personally I've always 
thought that making the build.properties in the user home the most 
dominant was somewhat backwards; I think it should be the source of 
defaults, but be overriden by project properties.

Regards,
Colin

Rod Johnson wrote:

>Thanks Colin, I've fixed this.
>
>----- Original Message ----- 
>From: "Colin Sampaleanu" <col...@ex...>
>To: "Rod Johnson" <rod...@in...>
>Cc: <spr...@li...>
>Sent: Friday, September 19, 2003 11:42 PM
>Subject: Re: [Springframework-developer] Mock Objects
>
>
>  
>
>>Test running seems to be broken, with the build.properties and build.xml
>>that's in CVS. That is,
>>
>>            <batchtest fork="yes" todir="${reports.dir}">
>>                <fileset dir="test" includes="${test.includes}"
>>excludes="${test.excludes}"/>
>>            </batchtest>
>>
>>should be
>>
>>            <batchtest fork="yes" todir="${reports.dir}">
>>                <fileset dir="${testbuild.dir}"
>>includes="${test.includes}" excludes="${test.excludes}"/>
>>            </batchtest>
>>
>>or no tests run...
>>
>>
>>Rod Johnson wrote:
>>
>>    
>>
>>>I've now updated all the deprecated EasyMock APIs in the test suite.
>>>      
>>>
>Please
>  
>
>>>remember to update before working on any tests: I've modified a large
>>>proportion of the test suite.
>>>
>>>Regards,
>>>Rod
>>>      
>>>





-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
_______________________________________________
Springframework-developer mailing list
Spr...@li...
https://lists.sourceforge.net/lists/listinfo/springframework-developer

---
Incoming mail is certified Virus Free.
Checked by AVG anti-virus system (http://www.grisoft.com).
Version: 6.0.512 / Virus Database: 309 - Release Date: 19/08/2003

[Springframework-developer] Tag documentation and additions

[Alef A. \(JTeam\) <al...@jt...>]

Everybody,

I've just added documentation for the tags Spring comes with. It's
located in docs/taglib. I'd like to ask someone how knows something
about the spring:theme tag and the spring:htmlEscape tag to document
those, since I've never used those. I can imagine what htmlEscape does,
but have no clue about themes (heard something on the list once, but
that's all ;-). Maybe it's an idea to put the taglib documentation on
the website as well... One thing: I've made references to the API-docs
in there, and used href including
../api/org/springframe/etcetera/Bla.html... On the website, I saw the
API documentation included 1.0m1 in the URL... This will be a problem
when putting the taglib docs online...

Also, I've added a transform tag (servlet/tags/TransformTag). It's
supposed to render properties from for instance reference data using the
some PropertyEditor that's currently used (the tag can only be used
inside <spring:bind>). Have a look at the documentation what it can do
for you.

While at it, I've revised the tests for the tags a little bit (each tag
has a separate test now, to make things a bit more readable and stuff).

Alef

Re: [Springframework-developer] Mock Objects

[Colin S. <col...@ex...>]

btw, I don't know if it's worth making a change, but more often than 
not, the general practice with ant projects and maven projects that I've 
seen is to have build.properties be a file which is not checked into CVS 
(sometimes there is a build.properties.sample checked in), with this 
file used for developer specific overrides. Maven adds an optional 
project.properties file, which generally _is_ checked in if it exists. 
Properties from project.properties are overriden by properties from 
build.properties.

I'm a big fan of consistency where it doesn't hurt anything, so maybe it 
makes sense to rename build.properties to project.properties, and have 
something like this at the top of the build.xml file

  <!-- Load local and user build preferences -->
  <property file="${user.home}/build.properties"/>
  <property file="build.properties"/>
  <property file="project.properties"/>

This is consistent with Maven's order, although personally I've always 
thought that making the build.properties in the user home the most 
dominant was somewhat backwards; I think it should be the source of 
defaults, but be overriden by project properties.

Regards,
Colin

Rod Johnson wrote:

>Thanks Colin, I've fixed this.
>
>----- Original Message ----- 
>From: "Colin Sampaleanu" <col...@ex...>
>To: "Rod Johnson" <rod...@in...>
>Cc: <spr...@li...>
>Sent: Friday, September 19, 2003 11:42 PM
>Subject: Re: [Springframework-developer] Mock Objects
>
>
>  
>
>>Test running seems to be broken, with the build.properties and build.xml
>>that's in CVS. That is,
>>
>>            <batchtest fork="yes" todir="${reports.dir}">
>>                <fileset dir="test" includes="${test.includes}"
>>excludes="${test.excludes}"/>
>>            </batchtest>
>>
>>should be
>>
>>            <batchtest fork="yes" todir="${reports.dir}">
>>                <fileset dir="${testbuild.dir}"
>>includes="${test.includes}" excludes="${test.excludes}"/>
>>            </batchtest>
>>
>>or no tests run...
>>
>>
>>Rod Johnson wrote:
>>
>>    
>>
>>>I've now updated all the deprecated EasyMock APIs in the test suite.
>>>      
>>>
>Please
>  
>
>>>remember to update before working on any tests: I've modified a large
>>>proportion of the test suite.
>>>
>>>Regards,
>>>Rod
>>>      
>>>

[Springframework-developer] Velocity support

[Rod J. <rod...@in...>]

Attention Velocity users:

I've just changed the Velocity support to use the VelocityEngine model
rather than a Velocity singleton. This is partly to make testing easier (I
plan to add some Velocity tests) but also in case there's ever a need to
have a different Velocity setup for different controller servlets. As you
know, I hate singletons. And the VelocityConfigurer implementation was a bit
misleading in that using two in different servlet XML in the same JVM with
different config could have produced unexpected results.

This should be backward compatible. The VelocityView now looks for a
VelocityConfiguration implementation such as VelocityConfigurer in the
current application context hierarchy (it can be shared in the root web app
context). The name of this bean doesn't matter.

Anyway, please check your Velocity applications against the latest in CVS
before we release M2 and let me know if there are any problems.

Regards,
Rod

Re: [Springframework-developer] Mock Objects

[Rod J. <rod...@in...>]

Thanks Colin, I've fixed this.

----- Original Message ----- 
From: "Colin Sampaleanu" <col...@ex...>
To: "Rod Johnson" <rod...@in...>
Cc: <spr...@li...>
Sent: Friday, September 19, 2003 11:42 PM
Subject: Re: [Springframework-developer] Mock Objects


> Test running seems to be broken, with the build.properties and build.xml
> that's in CVS. That is,
>
>             <batchtest fork="yes" todir="${reports.dir}">
>                 <fileset dir="test" includes="${test.includes}"
> excludes="${test.excludes}"/>
>             </batchtest>
>
> should be
>
>             <batchtest fork="yes" todir="${reports.dir}">
>                 <fileset dir="${testbuild.dir}"
> includes="${test.includes}" excludes="${test.excludes}"/>
>             </batchtest>
>
> or no tests run...
>
>
> Rod Johnson wrote:
>
> >I've now updated all the deprecated EasyMock APIs in the test suite.
Please
> >remember to update before working on any tests: I've modified a large
> >proportion of the test suite.
> >
> >Regards,
> >Rod
> >
> >
> >
> >-------------------------------------------------------
> >This sf.net email is sponsored by:ThinkGeek
> >Welcome to geek heaven.
> >http://thinkgeek.com/sf
> >_______________________________________________
> >Springframework-developer mailing list
> >Spr...@li...
> >https://lists.sourceforge.net/lists/listinfo/springframework-developer
> >
> >
>
>

[Springframework-developer] Hibernate and JBG

[Kopylenko, D. <dko...@ac...>]

Hello everyone,

F.Y.Y Hibernate joins Jboss group 

http://www.theserverside.com/home/thread.jsp?thread_id=21482&article_count=1
24

Regards,
Dmitriy.

Re: [Springframework-developer] Mock Objects

[Colin S. <col...@ex...>]

Test running seems to be broken, with the build.properties and build.xml 
that's in CVS. That is,

            <batchtest fork="yes" todir="${reports.dir}">
                <fileset dir="test" includes="${test.includes}" 
excludes="${test.excludes}"/>
            </batchtest>

should be

            <batchtest fork="yes" todir="${reports.dir}">
                <fileset dir="${testbuild.dir}" 
includes="${test.includes}" excludes="${test.excludes}"/>
            </batchtest>

or no tests run...


Rod Johnson wrote:

>I've now updated all the deprecated EasyMock APIs in the test suite. Please
>remember to update before working on any tests: I've modified a large
>proportion of the test suite.
>
>Regards,
>Rod
>
>
>
>-------------------------------------------------------
>This sf.net email is sponsored by:ThinkGeek
>Welcome to geek heaven.
>http://thinkgeek.com/sf
>_______________________________________________
>Springframework-developer mailing list
>Spr...@li...
>https://lists.sourceforge.net/lists/listinfo/springframework-developer
>  
>

[Springframework-developer] Mock objects

[Rod J. <rod...@in...>]

All,

I've just upgraded from EasyMock 0.8 to 1.0.

See the bottom of http://www.easymock.org/Documentation.html for the new
features, and why doing this was worthwhile.

I've upgraded the Jar (same name, so no project changes needed).

I've also needed to change a number of test classes because of tighter
behaviour in 1.0. For example, some tests incorrectly used
setReturnValue(null) instead of setVoidCallable().

Also the JdbcTemplate tests needed changing to allow more than one call to
DataSource.getConnection(). Thomas, I assume this is to get the metadata to
be able to look up error codes?

There are still a lot of deprecations. However, I think we can live with
these and gradually update the code to get rid of them.

The principal updates to remove the deprecations are:

- EasyMock.controlFor() should change to MockControl.createControl()
- mockControl.activate() => replay()
- remove import of EasyMock

I've only made these changes in tests I otherwise needed to change. I may
try a global replace later today.

We still need to upgrade from Mock Object 0.07 to 0.09. However, this breaks
a number of the JDBC tests, which I don't have time to look at now. Any
volunteers? (Trevor? I think this breaks some of your code.)

Regards,
Rod

[Springframework-developer] Mock Objects

[Rod J. <rod...@in...>]

I've now updated all the deprecated EasyMock APIs in the test suite. Please
remember to update before working on any tests: I've modified a large
proportion of the test suite.

Regards,
Rod

[Springframework-developer] Re: Anonymous CVS access via Eclipse 3.0M3

[Mark M. <mar...@co...>]

Colin, 

Thank you for the tip. Via the alternate server, I can again access the
repository via eclipse. 

I also installed Tortoise out of curiosity - very nice.

Mark

-----Original Message-----
From: spr...@li...
[mailto:spr...@li...] On Behalf
Of Colin Sampaleanu
Sent: Wednesday, September 17, 2003 10:43 PM
To: Mark McNally
Cc: spr...@li...
Subject: Re: [Springframework-developer] Re: Anonymous CVS access via
Eclipse 3.0M3

Mark,

Give TortoiseCVS a try as well:
  http://www.tortoisecvs.org/
It is integrated into Windows Explorer, and frankly, while I do use the 
Eclipse CVS integration when I am in Eclipse, I find Tortoise can do 
everything else the rest of the time, and works great.

As for problems with CVS access to SourceForge from Eclipse, I think 
this is due to the different timeout values that various clients have. 
Eclipse seems to have a pretty low timeout, while command-line cvs will 
work in the same circumstances. SF is at fault in any case, but until 
they resolve the situation, what you may try doing is hitting the 
'alternate' servers available via port 80, as described here. I find 
them much more responsive:

  
http://sourceforge.net/docman/display_doc.php?docid=14033&group_id=1#fir
ewall


Mark McNally wrote:

> Rod and Rajeev, Thank you for your responses. I am back in business
now!
>
> I have kept my Eclipse 3.0M3 installation but am now using a separate 
> cvs client.  I actually tried two different programs WinCVS and 
> SmartCVS and, so far, have found SmartCVS - http://www.smartcvs.com/ -

> to be much easier to setup and use.
>
> Mark
>

Re: [Springframework-developer] Re: Anonymous CVS access via Eclipse 3.0M3

[Colin S. <col...@ex...>]

Mark,

Give TortoiseCVS a try as well:
  http://www.tortoisecvs.org/
It is integrated into Windows Explorer, and frankly, while I do use the 
Eclipse CVS integration when I am in Eclipse, I find Tortoise can do 
everything else the rest of the time, and works great.

As for problems with CVS access to SourceForge from Eclipse, I think 
this is due to the different timeout values that various clients have. 
Eclipse seems to have a pretty low timeout, while command-line cvs will 
work in the same circumstances. SF is at fault in any case, but until 
they resolve the situation, what you may try doing is hitting the 
'alternate' servers available via port 80, as described here. I find 
them much more responsive:

  
http://sourceforge.net/docman/display_doc.php?docid=14033&group_id=1#firewall


Mark McNally wrote:

> Rod and Rajeev, Thank you for your responses. I am back in business now!
>
> I have kept my Eclipse 3.0M3 installation but am now using a separate 
> cvs client.  I actually tried two different programs WinCVS and 
> SmartCVS and, so far, have found SmartCVS - http://www.smartcvs.com/ - 
> to be much easier to setup and use.
>
> Mark
>
> _________________________________________________________________
> Compare Cable, DSL or Satellite plans: As low as $29.95.  
> https://broadband.msn.com
>
>
>
> -------------------------------------------------------
> This sf.net email is sponsored by:ThinkGeek
> Welcome to geek heaven.
> http://thinkgeek.com/sf
> _______________________________________________
> Springframework-developer mailing list
> Spr...@li...
> https://lists.sourceforge.net/lists/listinfo/springframework-developer

[Springframework-developer] Re: Anonymous CVS access via Eclipse 3.0M3

[Mark M. <mg...@ho...>]

Rod and Rajeev, Thank you for your responses. I am back in business now!

I have kept my Eclipse 3.0M3 installation but am now using a separate cvs 
client.  I actually tried two different programs WinCVS and SmartCVS and, so 
far, have found SmartCVS - http://www.smartcvs.com/ - to be much easier to 
setup and use.

Mark

_________________________________________________________________
Compare Cable, DSL or Satellite plans: As low as $29.95.  
https://broadband.msn.com

[Springframework-developer] Prefilling forms before passing controller

[Christophe V. <c.v...@pa...>]

Hello,

Is there an official way to have more than one form on the same page? Or to have a form (eg. a loginbox) on a "normal" index page?

The problem when you try to do something like that is that when you use the <spring:bind> tag, you'll get an exception if you haven't gone through your formcontroller (because there are no errors bound, and you can't create the BindStatus).

I solved the problem by putting a null check for the errors in BindTag, wich allows the page to be rendered even if you haven't gone through the controller (yet).

This method has two disadvantages:
- you no langer get an exception if you try to bind something which doesn't exist (in case of a typo, ...), but that was exactly what I wanted to be able to do :)
- if you have a form on the page, and you haven't gone through the controller yet, you're not able to prefill any values (because that is what you normally accomplish with getFormBackingObject() ).

The latter was solved by extending the tag and defining an extra attribute, altValue, which will be used for the BindStatus value if no errors where found (errors == null) in the requestContext (which is only possible if you haven't gone through the controller yet).
By extending, you have different tags, and you can keep the exceptions in forms where you don't need the extra functionality.

This way, one can have multiple forms on the same page, which will be handled by different controllers, and can be prefilled should one choose to.

From ExtBindTag.doStartTagInternal():

// retrieve errors object
this.errors = getRequestContext().getErrors(name, false);

if(this.errors == null) {
  BindStatus status = new BindStatus(this.property,this.altValue, null,null);
  this.pageContext.setAttribute(STATUS_VARIABLE_NAME,status);
  return EVAL_BODY_INCLUDE;
}

Now I am able to do something like this on the main index page (written in JSP 2):

<form action="${url}" method="post">
<table>
//fill in the nick, with the value found in the cookie
//once we submitted, the "normal" status.value will be used, and not the
//value of the cookie
<spring:extBind path="userCredentials.nick" altValue="${cookie.nick.value}">
  <tr><td>Nickname:</td></tr>
  <tr><td><input type="text" name="nick" value="${status.value}"/></td></tr>
  <tr><td>${status.errorMessage}</td></tr>
</spring:extBind>
//we don't need to prefill the password, use normal tag
<spring:bind path="userCredentials.password">
   <tr><td>Password:</td></tr>
   <tr><td><input type="password" name="password"/></td></tr>
   <tr><td>${status.errorMessage}</td></tr>
</spring:bind>
<tr><td><input type="submit" value="login"/></td></tr>
</table>
</form>

If there was another (better :) way to solve this problem, please let me know.
Otherwise, this is probably a usefull extension.

-- 
Kind regards,
Christophe Vanfleteren

Re: [Springframework-developer] New - stored procedures returning result sets

[Rod J. <rod...@in...>]

> I have checked in the changes for supporting stored procedures returning
result
> sets.  For Oracle you would declare an SqlOutParameter with a type of
> oracle.jdbc.OracleTypes.CURSOR along with a RowCallbackHandler that will
map or
> process the returned rows.

Thanks Thomas, I know a lot of users want this functionality.

> I have also made a change so if you call execute without calling compile,
the
> framework will automatically compile you prepared statement or stored
procedure
> instead of just throwing an exception.  This is more inline with how JDO
handles
> this.

Does this apply to all RDBMS operations?

Regards,
Rod

[Springframework-developer] New - stored procedures returning result sets

[<tri...@tr...>]

I have checked in the changes for supporting stored procedures returning result
sets.  For Oracle you would declare an SqlOutParameter with a type of
oracle.jdbc.OracleTypes.CURSOR along with a RowCallbackHandler that will map or
process the returned rows.  

For databases where you don't explicitly declare the result sets that are
returned (SQL Server, Sybas, DB2) you would declare an SqlReturnResultSet
parameter with a RowCallBackHandler.  You can specify multiple parameters and
RowCallBackHandlers if your procedure returns multiple result sets.  

Postgres is supposed to support this in 7.4 and you would declare it the same
way as Oracle except the type would be java.sql.Types.OTHER.

This is an example of an Oracle procedure:

class MySPwithRS extends StoredProcedure {

  private List results = new LinkedList();
	
  MySPwithRS(DataSource ds) {
    super(ds, "pkg_test.get_emp");
    setFunction(true);
    declareParameter(new SqlOutParameter("rs", oracle.jdbc.OracleTypes.CURSOR,
      new RowCallbackHandlerImpl()));
    compile();
  }

  Object execute() {
    Map in = new HashMap();
    Map out = execute(in);
    out.put("rs", results);
    return out;
  }

  private class RowCallbackHandlerImpl implements RowCallbackHandler {
    public void processRow(ResultSet rs)  throws SQLException {
      results.add(rs.getString(2));
    }
  }
}

I have also made a change so if you call execute without calling compile, the
framework will automatically compile you prepared statement or stored procedure
instead of just throwing an exception.  This is more inline with how JDO handles
this.

Thomas

Re: [Springframework-developer] Anonymous CVS access via Eclipse 3.0M3

[Rajeev K. <Ra...@cu...>]

I am also having the same problem with eclipse 2.1.1 and 3.0M3.  However,
WinCVS works fine for me.
----- Original Message -----
From: "Mark McNally" <mg...@ho...>
To: <spr...@li...>
Sent: Tuesday, September 16, 2003 10:34 AM
Subject: [Springframework-developer] Anonymous CVS access via Eclipse 3.0M3


> Hello,
>
> I am wondering if others are having problems with Anonymous CVS access of
> the springframework repository.
>
> I am not sure if the issue is with the repository, my cvs client (Eclipse)
> or something else. I am attempting access via Eclipse but nothing below
the
> head node appears in the Eclipse cvs browser. I see no error messages when
I
> refresh but still no content is visible. I also tried to connect with the
> Hibernate repository and experienced the same symptoms.
>
> I have had intermittent connectivity problems for awhile but, before
> upgrading to version 3.0M3 of Eclipse several days ago, I was usually able
> to pull down the files.  I may revert to back to version 2.1 and give it a
> try but thought I'd throw this out here first.
>
> My repository identification string looks like this:
>   :pserver:ano...@cv...:/cvsroot/springframework
>
>
> Rod, Thank you for writing such a great book. I refer to and recommend it
> often.
> Also, thanks to all who have continued to advance this elegant framework
and
> supporting documentation.
>
> Mark
>
> _________________________________________________________________
> Use custom emotions -- try MSN Messenger 6.0!
> http://www.msnmessenger-download.com/tracking/reach_emoticon
>
>
>
> -------------------------------------------------------
> This sf.net email is sponsored by:ThinkGeek
> Welcome to geek heaven.
> http://thinkgeek.com/sf
> _______________________________________________
> Springframework-developer mailing list
> Spr...@li...
> https://lists.sourceforge.net/lists/listinfo/springframework-developer