[Springframework-rcp-dev] [Spring-JIRA] Created: (RCP-379) Memory-leak: Petclinic-Sample blunders in the CloseAction trap

[Markus R. (JIRA) <no...@at...>]

Memory-leak: Petclinic-Sample blunders in the CloseAction trap
--------------------------------------------------------------

         Key: RCP-379
         URL: http://opensource.atlassian.com/projects/spring/browse/RCP-379
     Project: Spring Framework Rich Client Project
        Type: Bug

  Components: Samples, Dialog System  
    Versions: 0.1.0    
    Reporter: Markus Rogg


The default behavior in SRCP is, that it hiddes the ApplicationDialog (RCP-9). I think this is a trap for the application developers and will easy lead to memory-leaks (e.g. the petclinic sample creates every time the user clicks on a pet a new TitledPageApplicationDialog, but the click on OK only hides (default behavior) the dialog (the NewOwnerWizard reuses the dialog and hasn't this problem)). Maybe it's a solution that the customer must use the constructor with the CloseAction to avoid this memory leak.

Another memory leak (especially for CloseAction.DISPOSE) is RCP-97. This memory leak holds all ApplicationDialogs (the static CommandFaceDescriptor.BLANK knows the CommandFaceButtonManager (registered as PropertyChangeListener), the CommandFaceButtonManager knows the command and the command (finishCommand and cancelCommand) is an anonymous inner class of the ApplicationDialog.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://opensource.atlassian.com/projects/spring/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira