[Springframework-rcp-dev] [Spring-JIRA] Commented: (RCP-299) and access to the control on a CommandGroup

[Brian R. (JIRA) <no...@at...>]

    [ http://opensource.atlassian.com/projects/spring/browse/RCP-299?page=comments#action_17620 ] 

Brian Ross commented on RCP-299:
--------------------------------

I could override DefaultApplicationWindow, but this seems like something that needs to be available as part of the framework, not custom code.

After reading your explanation, I understand the problem with my suggestion.  The window would be a better place.  The API would be a bit weird though, in that you would have 2 methods, getToolBar() and getToolBarControl().  Perhaps an intermediate object is in order.  Instead of instances of JComponent, the create methods could return CommandGroupComponent objects or something, which would give the user access to both the underlying command group and the control created by it.  This way, I could call window.getToolBar().getControl() or window.getToolBar().getCommandGroup().  It's a bit cleaner, I think.

> and access to the control on a CommandGroup
> -------------------------------------------
>
>          Key: RCP-299
>          URL: http://opensource.atlassian.com/projects/spring/browse/RCP-299
>      Project: Spring Framework Rich Client Project
>         Type: Improvement

>   Components: Command System
>     Reporter: Brian Ross
>     Assignee: Larry Streepy
>  Attachments: CommandGroup.java
>
> some CommandGroup controls, like the toolbar, only support a very small set of features at this point.  Those who wish to add things to the toolbar other than plain buttons need a way to access the control from their code.  this involves only a small change to CommandGroup.java, which I will attach.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://opensource.atlassian.com/projects/spring/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira