|
From: Larry S. (JIRA) <no...@at...> - 2006-05-14 14:26:45
|
[ http://opensource.atlassian.com/projects/spring/browse/RCP-267?page=comments#action_17597 ] Larry Streepy commented on RCP-267: ----------------------------------- Automatically committing the underlying form for each wizard page isn't appropriate for all cases. Often, all the pages in the wizard are operating on a single (or hierarchical) form model, so committing as the user moves between pages would be the wrong thing to do. > Forms in Wizards (with FormBackedWizardPages) are never commited by the WizardDialog (the only implementation of a WizardContainer). > ------------------------------------------------------------------------------------------------------------------------------------ > > Key: RCP-267 > URL: http://opensource.atlassian.com/projects/spring/browse/RCP-267 > Project: Spring Framework Rich Client Project > Type: Improvement > Environment: any > Reporter: Arne Limburg > Assignee: Oliver Hutchison > > Forms in Wizards (with FormBackedWizardPages) are never commited by the WizardDialog (the only implementation of a WizardContainer). I don't consider this as a bug, but this should be done, when a FormBackedWizardPage becomes invisible (due to a click on back or next or via showPage) if it is commitable. At least this should happen on a click on next. I suggest adding the methods isCommittable() and commit() to the FormBackedWizardPage, delegating to the backed Form's FormModel. Then the WizardDialog should call this methods in onNext(), onBack() and showPage() if the current page is an instance of FormBackedWizardPage. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/spring/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |