[Springframework-rcp-dev] [Spring-JIRA] Commented: (RCP-299) and access to the control on a CommandGroup

[Larry S. (JIRA) <no...@at...>]

    [ http://opensource.atlassian.com/projects/spring/browse/RCP-299?page=comments#action_17593 ] 

Larry Streepy commented on RCP-299:
-----------------------------------

The problem with the suggested patch is that it assumes that the command group will only be used to create a single control.  However, the general design of the CommandGroup is that it can be rendered into several different control types.  Thus, just recording the last control created creates the temporal coupling I mentioned above.

If you want to capture the primary controls created for the application window (like the toolbar and menubar), you should look at overriding DefaultApplicationWindow.

I'll also look at the possibility of making those components available in the ApplicationWindow interface.


> and access to the control on a CommandGroup
> -------------------------------------------
>
>          Key: RCP-299
>          URL: http://opensource.atlassian.com/projects/spring/browse/RCP-299
>      Project: Spring Framework Rich Client Project
>         Type: Improvement

>   Components: Command System
>     Reporter: Brian Ross
>     Assignee: Larry Streepy
>  Attachments: CommandGroup.java
>
> some CommandGroup controls, like the toolbar, only support a very small set of features at this point.  Those who wish to add things to the toolbar other than plain buttons need a way to access the control from their code.  this involves only a small change to CommandGroup.java, which I will attach.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://opensource.atlassian.com/projects/spring/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira