[Springframework-rcp-dev] [Spring-JIRA] Updated: (RCP-266) ComboBoxAutoCompletionInterceptorFactory shouldn't use hardcoded "instanceof LabeledEnumListRenderer" etc

[Geoffrey De S. (JIRA) <no...@at...>]

     [ http://opensource.atlassian.com/projects/spring/browse/RCP-266?page=all ]

Geoffrey De Smet updated RCP-266:
---------------------------------

    Attachment: spring-richclient-patch-RCP-266.zip

The real issue is that bindings can set renderers but not editors.
So I fixed that, patch attached.

Just unzip it in the springrich root, take a look at the differences and commit it.

> ComboBoxAutoCompletionInterceptorFactory shouldn't use hardcoded "instanceof LabeledEnumListRenderer" etc
> ---------------------------------------------------------------------------------------------------------
>
>          Key: RCP-266
>          URL: http://opensource.atlassian.com/projects/spring/browse/RCP-266
>      Project: Spring Framework Rich Client Project
>         Type: Bug
>   Components: Binding System
>     Reporter: Geoffrey De Smet
>     Assignee: Oliver Hutchison
>     Priority: Minor
>  Attachments: spring-richclient-patch-RCP-266.zip
>
> I wrote a "TigerEnumComboBoxBinder" for 1.5 enum, which works mainly because it can do:
>         ComboBoxBinding binding = (ComboBoxBinding)super.doBind(control, formModel, formPropertyPath, context);
>         binding.setSelectableItemsHolder(createEnumSelectableItemsHolder(formModel, formPropertyPath));
>         binding.setRenderer(createEnumRenderer());
> Yet there the ComboBoxAutoCompletionInterceptorFactory does something more on other combobox bindings, it checks with an instanceof and adds interceptors hardcoded.
> I believe it should be able to set the interceptors on the binding and use those.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://opensource.atlassian.com/projects/spring/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira