[Springframework-rcp-dev] [Spring-JIRA] Created: (RCP-261) Needed changes in SpringRCP classes

[Martin Z. (JIRA) <no...@at...>]

Needed changes in SpringRCP classes
-----------------------------------

         Key: RCP-261
         URL: http://opensource.atlassian.com/projects/spring/browse/RCP-261
     Project: Spring Framework Rich Client Project
        Type: Improvement
  Components: Application Framework  
 Environment: WinXp
 Reporter: Martin Zeltner
 Assigned to: Oliver Hutchison 


Hello everybody,

I'm currently working with SpringRCP in project EL4J
(http://el4j.sf.net) and I had problems with some
classes, because they hide methods that should not be
hidden and do not have a default constructor and so on.
Here are the details for the appended files:

---+ AbstractApplicationPage.java
* Had only a constructor with parameters that can
not be set twice.

---+ PageLayoutBuilder.java
* I've added method "public void addView(String
viewDescriptorId, Object positionArgument)" to be able
to place a view somehow.

---+ ApplicationLauncher.java
* The splash screen was displayed too late, because
startup- and root-application-context has been started
at the time.


Here are further changes that should be made:

* Add a default constructor where it is possible and
implement interface InitializingBean.
* If these classes would implement interface
BeanNameAware it would be very easy to locate
misconfigurations (e.g. if you have multiple views
configured).
* Don't hide setter or getter methods if it is not
really necessary, e.g. see method "setId" of class
"AbstractForm".
* In method "createPage" of class
"DefaultApplicationWindow" don't lookup a
"DefaultApplicationPage".


I hope my explanations are clear, else just ask.
Comments are welcome too.

Best regards,
Martin

BTW: In EL4J 0.9.2 (http://el4j.sf.net) we have a very nice SpringRCP demo working with javabeans. At the moment it is very simple and we didn't release any docs but we will extend it in the near future.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://opensource.atlassian.com/projects/spring/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira