[Springframework-rcp-dev] [Spring-JIRA] Created: (RCP-631) Clearing the valuemodels in AbstractFormModel#setDeliverValueChangeEvents(boolean, boolean) should occur after all ValueChangeEvents are delivered.

[Matthieu S. (JIRA) <no...@sp...>]

Clearing the valuemodels in AbstractFormModel#setDeliverValueChangeEvents(boolean,boolean) should occur after all ValueChangeEvents are delivered.
--------------------------------------------------------------------------------------------------------------------------------------------------

                 Key: RCP-631
                 URL: https://jira.springsource.org/browse/RCP-631
             Project: Spring Rich Client Project
          Issue Type: Bug
          Components: Core
    Affects Versions: 1.1.0
            Reporter: Matthieu Steyt
            Assignee: Lieven Doclo
            Priority: Major


Consider the following example:

A formmodel containing two valuemodels A and B. B has a changelistener registered in which A gets a new value. The current implementation of the setDeliverValueChangeEvents(boolean,boolean) method uses the following sequence:
1. valueChangeEvents of A are delivered
2. A is cleared (dirty = false)
3. valueChangeEvents of B are delivered, as a consequence A is adapted (back to dirty)
4. B is cleared (dirty = false)

Result:
A is dirty, while it is the intention of the method that A is cleared.

Solution:
Two for-loops instead of one. One for firing the events and one for clearing the value models.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.springsource.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira