[Springframework-rcp-dev] [Spring-JIRA] Updated: (RCP-626) VLDocking integration broken

[Adam A. (JIRA) <no...@sp...>]

     [ https://jira.springsource.org/browse/RCP-626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adam Armistead updated RCP-626:
-------------------------------

    Attachment: RCP-626.patch

I removed the page listener and associated layout saving code in the VLDockingApplicationPageFactory as this was causing the desktop layout to be saved once for each page created.  Pages are saved when closed anyway.  Which works on a show page command and when closing the application.

I created a VLDockingApplicationWindowFactory and VLDockingApplicationWindow that interact with the VLDockingApplicationPage to load and save layouts and clear the docking desktop when a new page is shown.

I removed loading the initial layout from the createControl method in the VLDockingApplicationPage as this was attempting to layout floating dockables whose position is dependent on the main window before the docking desktop was added to the window.  This was pulled out and put in the loadInitialLayout method which is called from VLDockingApplicationWindow during a show page command AFTER the docking desktop is added to the main window.

To configure the VLDocking support the only thing that needs to be done differently is in the ApplicationContext xml file you must specify a VLDockingApplicationWindowFactory bean and reference this with an idref tag in the application services.

> VLDocking integration broken
> ----------------------------
>
>                 Key: RCP-626
>                 URL: https://jira.springsource.org/browse/RCP-626
>             Project: Spring Rich Client Project
>          Issue Type: Bug
>            Reporter: Adam Armistead
>            Assignee: Lieven Doclo
>         Attachments: RCP-626.patch
>
>
> In the VLDocking integrations each application page is its own DockingDesktop instance.  Pages are not being saved and loaded correctly resulting in floating dockables remaining on screen after showing a new page that should not show the floating dockable as a view.  Floating dockables are not positioned correctly when a page is shown, and when closing a page it is saved once for each page created, so if you create 5 application pages and close one of them it is saved 5 times in a row.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.springsource.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira