[Springframework-rcp-dev] [Spring-JIRA] Commented: (RCP-621) calling CommandGroup.add(AbstractCommand command) or CommandGroup.remove(AbstractCommand command) methods caused a ConcurrentModificationException

[Chris.Hunter (JIRA) <no...@sp...>]

    [ https://jira.springsource.org/browse/RCP-621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=48557#action_48557 ] 

Chris.Hunter commented on RCP-621:
----------------------------------

it happened in multi-thread accessing of the two methods, seems not consider the synchronization of using the field in multiple threads :

private final HashSet members = new LinkedHashSet(5);

> calling CommandGroup.add(AbstractCommand command) or CommandGroup.remove(AbstractCommand command) methods caused a ConcurrentModificationException
> --------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: RCP-621
>                 URL: https://jira.springsource.org/browse/RCP-621
>             Project: Spring Rich Client Project
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.1.1
>         Environment: java version "1.6.0_15"
> Java(TM) SE Runtime Environment (build 1.6.0_15-b03)
> Java HotSpot(TM) Client VM (build 14.1-b02, mixed mode, sharing)
>            Reporter: Chris.Hunter
>            Assignee: Lieven Doclo
>   Original Estimate: 0.12d
>  Remaining Estimate: 0.12d
>
> java.util.ConcurrentModificationException
> 	at java.util.LinkedHashMap$LinkedHashIterator.nextEntry(Unknown Source)
> 	at java.util.LinkedHashMap$KeyIterator.next(Unknown Source)
> 	at org.springframework.richclient.command.ExpansionPointGroupMember.fill(ExpansionPointGroupMember.java:169)
> 	at org.springframework.richclient.command.GroupMemberContainerManager.rebuildControlsFor(GroupMemberContainerManager.java:64)
> 	at org.springframework.richclient.command.GroupMemberList.rebuildControls(GroupMemberList.java:91)
> 	at org.springframework.richclient.command.CommandGroup.rebuildAllControls(CommandGroup.java:352)
> 	at org.springframework.richclient.command.CommandGroup.rebuildIfNecessary(CommandGroup.java:343)
> 	at org.springframework.richclient.command.CommandGroup.remove(CommandGroup.java:307)
> 	at org.springframework.richclient.command.CommandGroup.remove(CommandGroup.java:296)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.springsource.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira