[Springframework-rcp-dev] [Spring-JIRA] Updated: (RCP-60) FileChooser - Utils with accessory component

[Lieven D. (JIRA) <no...@sp...>]

     [ http://jira.springframework.org/browse/RCP-60?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lieven Doclo updated RCP-60:
----------------------------

    Fix Version/s: 1.x

> FileChooser - Utils with accessory component
> --------------------------------------------
>
>                 Key: RCP-60
>                 URL: http://jira.springframework.org/browse/RCP-60
>             Project: Spring Framework Rich Client Project
>          Issue Type: Improvement
>            Reporter: springtester
>            Priority: Minor
>             Fix For: 1.x
>
>
> FileChooser allows the addition of an accessory component.
> I created a simple patch and a more comlicated one which allows
> this for FileChooserUtils.
> I removed the static JFileChooser member (since an added
> accessory component would have been there even if you
> wouldn't want it).
> --simple
>  import java.awt.Component;
>  import java.io.File;
> +import javax.swing.JComponent;
>  import javax.swing.JFileChooser;
>  /**
> @@ -27,20 +28,34 @@
>   * @author Keith Donald
>   */
>  public class FileChooserUtils {
> -    private static JFileChooser fileChooser;
>      private FileChooserUtils() {
>      }
>      public static File showFileChooser(Component parent, String 
> defaultExtension, String approveButtonName,
>              String fileTypeDescription) {
> -        if (fileChooser == null) {
> -            fileChooser = new JFileChooser();
> +        JFileChooser fileChooser = new JFileChooser();
> +        DefaultFileFilter filter = new DefaultFileFilter();
> +        filter.addExtension(defaultExtension);
> +        filter.setDescription(fileTypeDescription);
> +        fileChooser.setFileFilter(filter);
> +        int returnVal = fileChooser.showDialog(parent, approveButtonName);
> +        if (returnVal == JFileChooser.APPROVE_OPTION) {
> +            return fileChooser.getSelectedFile();
>          }
> +        else {
> +            return null;
> +        }
> +    }
> +
> +    public static File showFileChooser(Component parent, String 
> defaultExtension, String approveButtonName,
> +            String fileTypeDescription, JComponent accessory ) {
> +        JFileChooser  fileChooser = new JFileChooser();
>          DefaultFileFilter filter = new DefaultFileFilter();
>          filter.addExtension(defaultExtension);
>          filter.setDescription(fileTypeDescription);
>          fileChooser.setFileFilter(filter);
> +        fileChooser.setAccessory(accessory);
>          int returnVal = fileChooser.showDialog(parent, approveButtonName);
>          if (returnVal == JFileChooser.APPROVE_OPTION) {
>              return fileChooser.getSelectedFile();
> @@ -49,4 +64,9 @@
>              return null;
>          }
>      }
> +
> +
> +
> +
> +
>  }
> \ No newline at end of file
> --complicated
> Index: FileChooserUtils.java
> ===================================================================
> RCS file: 
> /cvsroot/spring-rich-c/spring-richclient/src/org/springframework/richclient/filechooser/FileChooserUtils.java,v
> retrieving revision 1.5
> diff -u -r1.5 FileChooserUtils.java
> --- FileChooserUtils.java       31 Oct 2004 18:58:46 -0000      1.5
> +++ FileChooserUtils.java       3 Dec 2004 13:35:07 -0000
> @@ -18,6 +18,7 @@
>  import java.awt.Component;
>  import java.io.File;
>  
> +import javax.swing.JComponent;
>  import javax.swing.JFileChooser;
>  
>  /**
> @@ -27,20 +28,26 @@
>   * @author Keith Donald
>   */
>  public class FileChooserUtils {
> -    private static JFileChooser fileChooser;
> -
> + 
> 0;  
>      private FileChooserUtils() {
>      }
>  
>      public static File showFileChooser(Component parent, String 
> defaultExtension, String approveButtonName,
>              String fileTypeDescription) {
> -        if (fileChooser == null) {
> -            fileChooser = new JFileChooser();
> +       JFileChooser fileChooser = createFileChooser(parent,defaultExtension, 
> approveButtonName, fileTypeDescription, null );
> +       int returnVal = fileChooser.showDialog(parent, approveButtonName);
> +        if (returnVal == JFileChooser.APPROVE_OPTION) {
> +            return fileChooser.getSelectedFile();
>          }
> -        DefaultFileFilter filter = new DefaultFileFilter();
> -        filter.addExtension(defaultExtension);
> -        filter.setDescription(fileTypeDescription);
> -        fileChooser.setFileFilter(filter);
> +        else {
> +            return null;
> +        }
> +    }
> +    
> +    
> +    public static File showFileChooser(Component parent, String 
> defaultExtension, String approveButtonName,
> +            String fileTypeDescription, JComponent accessory ) {
> +        JFileChooser fileChooser = createFileChooser(parent,defaultExtension, 
> approveButtonName, fileTypeDescription, accessory );
>          int returnVal = fileChooser.showDialog(parent, approveButtonName);
>          if (returnVal == JFileChooser.APPROVE_OPTION) {
>              return fileChooser.getSelectedFile();
> @@ -49,4 +56,17 @@
>              return null;
>          }
>      }
> +    static JFileChooser createFileChooser( Component parent, String 
> defaultExtension, String approveButtonName,
> +            String fileTypeDescription, JComponent accessory ){
> +       JFileChooser fileChooser = new JFileChooser();
> +        DefaultFileFilter filter = new DefaultFileFilter();
> +        filter.addExtension(defaultExtension);
> +        filter.setDescription(fileTypeDescription);
> +        fileChooser.setFileFilter(filter);
> +        if( accessory != null ){
> +               fileChooser.setAccessory(accessory);
> +        }
> + 
> 0;      return fileChooser;            
> +    }
> +    
>  }
> \ No newline at end of file

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.springframework.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira