[Springframework-rcp-dev] [Spring-JIRA] Closed: (RCP-536) AbstractWizard#addPages is called multiple times, when Wizard is reused

[Jan H. (JIRA) <no...@sp...>]

     [ http://jira.springframework.org/browse/RCP-536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jan Hoskens closed RCP-536.
---------------------------

         Assignee: Jan Hoskens
       Resolution: Fixed
    Fix Version/s: 1.0.0

The adding of pages is moved to setWizard() of the WizardDialog:

http://spring-rich-c.svn.sourceforge.net/viewvc/spring-rich-c?view=rev&revision=1967

The createDialogContentPane() can be called multiple times when the close action is set to DISPOSE. Therefor an additional method disposeDialogContentPane() is created in ApplicationDialog to allow cleanup of the contentpane. 

The addPages() however is not a part of the construction of the contentPane (page.getControl() is) and therefor removed from that method. Placing this in the WizardDialog.setWizard() method changes the behavior defined in javadoc as lazy init, but when creating the container (hence setting things up to show) it seems logical to have the wizard pages available (except for dynamically added pages) and their graphical control will be created lazily when the JDialog is created.

> AbstractWizard#addPages is called multiple times, when Wizard is reused
> -----------------------------------------------------------------------
>
>                 Key: RCP-536
>                 URL: http://jira.springframework.org/browse/RCP-536
>             Project: Spring Framework Rich Client Project
>          Issue Type: Bug
>          Components: Command System
>    Affects Versions: 1.0.0
>            Reporter: Johannes Schneider
>            Assignee: Jan Hoskens
>            Priority: Critical
>             Fix For: 1.0.0
>
>
> The method AbstractWizard#addPages is called multiple times when a WizardDialog is shown multiple times.
> You can reproduce this using the PetClinitStandalone.
> Just open the NewOwnerWizard, enter some values, go to the next page and *cancel*.
> Now reopen the wizard. Now the wizard has each page added two times.....
> This is a major problem that should be fixed asap. Wizards are almost unusable now.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.springframework.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira