[Springframework-rcp-dev] [Spring-JIRA] Commented: (RCP-536) AbstractWizard#addPages is called multiple times, when Wizard is reused

[Jan H. (JIRA) <no...@sp...>]

    [ http://jira.springframework.org/browse/RCP-536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_31937 ] 

Jan Hoskens commented on RCP-536:
---------------------------------

The current default on cancelling/finishing  dialogs is to dispose the window. Apparently this disposing is not being handled in in extended classes. They keep their content pane cached when the dialog is disposed. When reopening the wizard, the dialog is constructed anew and the pages are added to the content pane which wasn't disposed. The latter leads to the described behavior. 

I'm thinking of resolving this by making the dispose() method non-final and override it where needed. I'll check subclasses of ApplicationDialog to make sure they dispose their content pane and any additional components.

Thanks for reporting.

> AbstractWizard#addPages is called multiple times, when Wizard is reused
> -----------------------------------------------------------------------
>
>                 Key: RCP-536
>                 URL: http://jira.springframework.org/browse/RCP-536
>             Project: Spring Framework Rich Client Project
>          Issue Type: Bug
>          Components: Command System
>    Affects Versions: 1.0.0
>            Reporter: Johannes Schneider
>            Priority: Critical
>
> The method AbstractWizard#addPages is called multiple times when a WizardDialog is shown multiple times.
> You can reproduce this using the PetClinitStandalone.
> Just open the NewOwnerWizard, enter some values, go to the next page and *cancel*.
> Now reopen the wizard. Now the wizard has each page added two times.....
> This is a major problem that should be fixed asap. Wizards are almost unusable now.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.springframework.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira