[Springframework-rcp-dev] ApplicationDialogs & CloseAction

[Jan H. <jh...@sc...>]

Hi all,

I'm reviewing the CloseAction & ApplicationDialog usage to fix RCP-379.
Currently the default action is to hide the dialog. Which is fine if it
is reused a lot but not when it's a one-shot dialog. 

Two questions arise:

1) do we want 'hide' to still be the default behavior?

I'm comfortable in having the 'hide' default, but it may lead to memory
leaks if it's overlooked (as in petclinic now, stated in RCP-379). We
can stress this in the api docs of course (which I would do anyways).

2) do we want to override this default in subclasses like
MessageDialog/ConfirmationDialog?

Both dialogs are typically small one-shot dialogs which won't suffer
from recreating the ui that much as a full application dialog.  

WDYT?

Anyways I'll go on and fix the petclinic memory leaks by explicitly
providing the closeAction and documenting this in code (probably using
both styles to show the difference)

Kind Regards,
Jan


 **** DISCLAIMER ****
 http://www.schaubroeck.be/maildisclaimer.htm