|
From: Jan H. <jh...@sc...> - 2007-12-28 16:18:06
|
Hi all, While looking at issue RCP-308 and rereading the associated forum thread, I get the feeling that we need a BindingException. I'll shortly sketch the problem and my idea. When any exception occurs while setting a value, the exception is caught in DefaultFormModel.ValidatingFormValueModel.setValueSilently(). Hereafter a binding error is raised, the exception logged as debug and that's it. This can be a perfect use-case for some, but it also covers up exceptions that may come from any listener attached to that valuemodel (or wrapped model). The latter should definitely not be handled as a binding error. The issue states that the log level should be at least at the warning level, which stands out more when developing. This is correct but I think we do need more precise handling of errors. We could create a BindingException that any PropertyAccessStrategy can throw and catch only this exception to raise as a binding error (and log it as warning). All others should be passed upwards. So I'm thinking of adding a BindingException and using this in the BeanPropertyAccessStrategy.setValue(Object) to wrap any exceptions concerning the binding to the backing bean. What do you think? Kind Regards, Jan **** DISCLAIMER **** http://www.schaubroeck.be/maildisclaimer.htm |