[Springframework-rcp-dev] [Spring-JIRA] Resolved: (RCP-141) AbstractFormModel.setFormObject() does not re-enable after being disabled

[Peter De B. (JIRA) <no...@at...>]

     [ http://opensource.atlassian.com/projects/spring/browse/RCP-141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Peter De Bruycker resolved RCP-141.
-----------------------------------

    Resolution: Fixed

issue has been resolved some time ago, so I'm closing it

> AbstractFormModel.setFormObject() does not re-enable after being disabled
> -------------------------------------------------------------------------
>
>                 Key: RCP-141
>                 URL: http://opensource.atlassian.com/projects/spring/browse/RCP-141
>             Project: Spring Framework Rich Client Project
>          Issue Type: Bug
>            Reporter: Scott Russell
>            Assignee: Oliver Hutchison
>            Priority: Minor
>             Fix For: 1.0.0
>
>         Attachments: NullableBeanPropertyAccessStrategy.java, NullableBeanWrapper.java
>
>
> In AbstractFormModel, if you call setFormObject(null), then the form model is set disabled. If you then subsequently call setFormObject(Object) with a non-null form object, the form object holder is changed with the new value, but the form model is not re-enabled.
> The code in question:
>     public void setFormObject(Object formObject) {
>         revert();
>         if (formObject == null) {
>             handleSetNullFormObject();
>         }
>         else {
>             getFormObjectHolder().setValue(formObject);
>         }
>     }
> should probably read:
>     public void setFormObject(Object formObject) {
>         revert();
>         if (formObject == null) {
>             handleSetNullFormObject();
>         }
>         else {
>             getFormObjectHolder().setValue(formObject);
>             setEnabled(true);
>         }
>     }
> -Scott

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/spring/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira