Re: [Springframework-rcp-dev] DefaultApplicationObjectConfigurer behaviour

[Jan H. <jh...@sc...>]

Seems acceptable to me. 

It may be appropriate to use this behavior in all configureXXX methods
in order to avoid confusion.

Kind Regards,
Jan

On Fri, 2007-11-30 at 14:42 +0100, Peter De Bruycker wrote:
> I'm looking to close issue RCP-13.
> 
> Solving it means altering DefaultApplicationObjectConfigurer
> behaviour, more specifically the configureTitle method.
> 
> the new implementation would look like this:
> 
>     protected void configureTitle(TitleConfigurable configurable,
> String objectName) {
>         Assert.required(configurable, "configurable");
>         Assert.required(objectName, "objectName");
>         String title = loadMessage(objectName + "." + TITLE_KEY);
>         if(StringUtils.hasText(title)) {
>             configurable.setTitle(title);
>         }
>     }
> 
> What this does is checking if a string is found in the MessageSource.
> Only if a string is found, it will be set. 
> 
> This means that if a title was already set on the TitleConfigurable
> instance (for example the ApplicationDescriptor), and no title is
> provided in the MessageSource, the title will remain the same.
> The current implementation just erases the current title. 
> 
> Is this change in behaviour acceptable?
> 
> regards,
> 
> Peter
> -------------------------------------------------------------------------
> SF.Net email is sponsored by: The Future of Linux Business White Paper
> from Novell.  From the desktop to the data center, Linux is going
> mainstream.  Let it simplify your IT future.
> http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4
> _______________________________________________ Springframework-rcp-dev mailing list Spr...@li... https://lists.sourceforge.net/lists/listinfo/springframework-rcp-dev


 **** DISCLAIMER ****
 http://www.schaubroeck.be/maildisclaimer.htm