[Springframework-rcp-dev] DefaultApplicationObjectConfigurer behaviour

[Peter De B. <pet...@gm...>]

I'm looking to close issue RCP-13.

Solving it means altering DefaultApplicationObjectConfigurer behaviour, more
specifically the configureTitle method.

the new implementation would look like this:

    protected void configureTitle(TitleConfigurable configurable, String
objectName) {
        Assert.required(configurable, "configurable");
        Assert.required(objectName, "objectName");
        String title = loadMessage(objectName + "." + TITLE_KEY);
        if(StringUtils.hasText(title)) {
            configurable.setTitle(title);
        }
    }

What this does is checking if a string is found in the MessageSource. Only
if a string is found, it will be set.

This means that if a title was already set on the TitleConfigurable instance
(for example the ApplicationDescriptor), and no title is provided in the
MessageSource, the title will remain the same.
The current implementation just erases the current title.

Is this change in behaviour acceptable?

regards,

Peter