Re: [Springframework-rcp-dev] Refactoring the docking code

[Rogan D. <ro...@da...>]

Jonny Wray wrote:
> Rogan,
> 
> This is Jonny Wray, author of the JIDE docking integration.
> 
> I looked over your refactorings wrt the JIDE related code and it looks 
> great. Good to know there's common ground between the two frameworks 
> that can be abstracted out. The one difference I notice is that you are 
> applying perspectives on a page, whereas I apply then on a window, at 
> least at the API level. However, in my implementation it actually 
> identifies the perspective on a page by page basis, so the changes 
> shouldn't be too hard to make and the code should be cleaner.
> 
> One other addition might be useful, a 'change perspective' command that 
> allows configuration of the specific perspective within the application 
> context, and a  doExecuteCommand method that calls switch on that 
> perspective.
> 
> thanks
> Jonny

Hi Jonny,

Thanks for taking the time to take a look. I did consider your 
implementation of the JIDE docking code when doing the refactoring. The 
major difference that is not accounted for in the refactoring is the 
JideApplicationWindow code.

I must admit, I'm not entirely sure why this is needed. Any reason that 
this has to be different to the standard behaviour? Can the JIDE 
DockableHolder not be a property of the JideApplicationPage, rather?

I absolutely do plan to make a ChangePerspectiveCommand. You may have 
seen the PageDescriptorRegistry, ShowPageCommand and ShowPageMenu that I 
added at the beginning of the year. I was previously implementing 
Perspectives in their own Page. Unfortunately, this ends up requiring 
unclean changes to support persistence of Views across Perspective changes.

Rogan