[Springframework-rcp-dev] [Spring-JIRA] Commented: (RCP-165) Eliminate need for special bean names when configuring Application and ApplicationServices

[Arne L. (JIRA) <no...@at...>]

    [ http://opensource.atlassian.com/projects/spring/browse/RCP-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_25262 ] 

Arne Limburg commented on RCP-165:
----------------------------------

3) You are right. I have upgraded my patch.

4) It is great for prototypes.

I don't think you have to refactor the advisor. These bean names are not magic anyway. You can change them via the menubarBeanName and toolbarBeanName properties in DefaultApplicationLifecycleAdvisor. With this you can also change the toolbar without the need of specifying any menubar. You only need to include my commands-context.xml into yours, provide your own toolbar-bean and set its name in the advisor. You can also add new menubar entries by specifying a new menubar bean, but reuse the fileMenu, editMenu, windowMenu and helpMenu.

But anyway this cannot be the final solution. We need a more pluggable architecture for the commands context. What about a special menubar bean that acts as a beanpostprocessor to search for menubar entries? We then would need only a marker interface like MenubarEntry for the commands that should be plugged into the menubar. Same could go for the toolbar and the new-menu. You then would just have to specify your additional menus, new-commands and toolbar commands and could use the default-commands-context for the rest. We then should provide the ability to specify multiple commands-contexts in the advisor.

> Eliminate need for special bean names when configuring Application and ApplicationServices
> ------------------------------------------------------------------------------------------
>
>                 Key: RCP-165
>                 URL: http://opensource.atlassian.com/projects/spring/browse/RCP-165
>             Project: Spring Framework Rich Client Project
>          Issue Type: Improvement
>            Reporter: Oliver Hutchison
>            Assignee: Jan Hoskens
>             Fix For: 0.3.0
>
>         Attachments: Application.java.patch, RCP-165.patch, RCP-165.patch
>
>
> We should totally eliminate the special bean names that are required when configuring the Application and ApplicationServices singletons. Both these classes should be configurable using DI.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/spring/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira