[Springframework-rcp-dev] [Spring-JIRA] Commented: (RCP-165) Eliminate need for special bean names when configuring Application and ApplicationServices

[Jan H. (JIRA) <no...@at...>]

    [ http://opensource.atlassian.com/projects/spring/browse/RCP-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_25231 ] 

Jan Hoskens commented on RCP-165:
---------------------------------

Some remarks:

3) You've bypassed the ApplicationPageFactory by directly creating a DefaultApplicationPage in the openWindow. I think we should let the factory handle the null case.

4) why are you providing a commands-context that will always be overruled and hence unneeded? I can imagine starting a new app from an archetype which does provide something like this, but I don't see why we would include a sample-xml with the rcp-support-jar. Can't we opt to have an empty menu or no menu at all instead? 

Besides this, I would like to refactor the advisor in order to remove these magic bean names so anyone who would like to have menu or/and toolbar can define this with the advisor in a more clear way. This would also allow to reuse menu's in other apps (think of suites or so).

WDYT?

Thanks for the patch!

> Eliminate need for special bean names when configuring Application and ApplicationServices
> ------------------------------------------------------------------------------------------
>
>                 Key: RCP-165
>                 URL: http://opensource.atlassian.com/projects/spring/browse/RCP-165
>             Project: Spring Framework Rich Client Project
>          Issue Type: Improvement
>            Reporter: Oliver Hutchison
>            Assignee: Jan Hoskens
>             Fix For: 0.3.0
>
>         Attachments: Application.java.patch, RCP-165.patch
>
>
> We should totally eliminate the special bean names that are required when configuring the Application and ApplicationServices singletons. Both these classes should be configurable using DI.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/spring/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira