|
From: Jan H. <jh...@sc...> - 2007-07-10 09:34:05
|
Yep, I forgot to run the tests. Typical, I've been running them all day, but when changing that small thingy I forgot that step! Will fix the tests, they were plain wrong: mnemonics should be tested against the VK_XXX keycode (which is an int) not against a character. (there's no 'a' keycode) Thanks, Kind Regards, Jan On Tue, 2007-07-10 at 10:14 +0100, Benoit Xhenseval wrote: > Hi > > > > I believe the last change to LabelInfo breaks a couple of unit tests. > > > > ------------------------------------------------------------------------------- > > Test set: org.springframework.richclient.core.LabelInfoTests > > ------------------------------------------------------------------------------- > > Tests run: 19, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 0.016 > sec <<< FAILURE! > > testValueOfWithValidSyntax(org.springframework.richclient.core.LabelInfoTests) Time elapsed: 0 sec <<< FAILURE! > > junit.framework.AssertionFailedError: expected:<97> but was:<65> > > at junit.framework.Assert.fail(Assert.java:47) > > at > junit.framework.Assert.failNotEquals(Assert.java:282) > > at junit.framework.Assert.assertEquals(Assert.java:64) > > at > junit.framework.Assert.assertEquals(Assert.java:201) > > at > junit.framework.Assert.assertEquals(Assert.java:207) > > at > org.springframework.richclient.core.LabelInfoTests.testValueOfWithValidSyntax(LabelInfoTests.java:89) > > at > org.springframework.richclient.core.LabelInfoTests.testValueOfWithValidSyntax(LabelInfoTests.java:89) > > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native > Method) > > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) > > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) > > at java.lang.reflect.Method.invoke(Method.java:585) > > at junit.framework.TestCase.runTest(TestCase.java:154) > > at junit.framework.TestCase.runBare(TestCase.java:127) > > at junit.framework.TestResult > $1.protect(TestResult.java:106) > > at > junit.framework.TestResult.runProtected(TestResult.java:124) > > at junit.framework.TestResult.run(TestResult.java:109) > > at junit.framework.TestCase.run(TestCase.java:118) > > at > junit.framework.TestSuite.runTest(TestSuite.java:208) > > at junit.framework.TestSuite.run(TestSuite.java:203) > > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native > Method) > > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) > > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) > > at java.lang.reflect.Method.invoke(Method.java:585) > > at > org.apache.maven.surefire.junit.JUnitTestSet.execute(JUnitTestSet.java:213) > > at > org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(AbstractDirectoryTestSuite.java:138) > > at > org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(AbstractDirectoryTestSuite.java:125) > > at > org.apache.maven.surefire.Surefire.run(Surefire.java:132) > > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native > Method) > > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) > > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) > > at java.lang.reflect.Method.invoke(Method.java:585) > > at > org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(SurefireBooter.java:290) > > at > org.apache.maven.surefire.booter.SurefireBooter.run(SurefireBooter.java:198) > > at > org.apache.maven.plugin.surefire.SurefirePlugin.execute(SurefirePlugin.java:398) > > at > org.apache.maven.plugin.DefaultPluginManager.executeMojo(DefaultPluginManager.java:443) > > at > org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:539) > > at > org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalWithLifecycle(DefaultLifecycleExecutor.java:480) > > at > org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoal(DefaultLifecycleExecutor.java:459) > > at > org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalAndHandleFailures(DefaultLifecycleExecutor.java:311) > > at > org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeTaskSegments(DefaultLifecycleExecutor.java:278) > > at > org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLifecycleExecutor.java:143) > > at > org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:334) > > at > org.apache.maven.DefaultMaven.execute(DefaultMaven.java:125) > > at > org.apache.maven.cli.MavenCli.main(MavenCli.java:272) > > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native > Method) > > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) > > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) > > at java.lang.reflect.Method.invoke(Method.java:585) > > at > org.codehaus.classworlds.Launcher.launchEnhanced(Launcher.java:315) > > at > org.codehaus.classworlds.Launcher.launch(Launcher.java:255) > > at > org.codehaus.classworlds.Launcher.mainWithExitCode(Launcher.java:430) > > at > org.codehaus.classworlds.Launcher.main(Launcher.java:375) > > > > testForAtSymbols(org.springframework.richclient.core.LabelInfoTests) > Time elapsed: 0 sec <<< FAILURE! > > junit.framework.AssertionFailedError: expected:<97> but was:<65> > > at junit.framework.Assert.fail(Assert.java:47) > > at > junit.framework.Assert.failNotEquals(Assert.java:282) > > at junit.framework.Assert.assertEquals(Assert.java:64) > > at > junit.framework.Assert.assertEquals(Assert.java:201) > > at > junit.framework.Assert.assertEquals(Assert.java:207) > > at > org.springframework.richclient.core.LabelInfoTests.testForAtSymbols(LabelInfoTests.java:155) > > at > org.springframework.richclient.core.LabelInfoTests.testForAtSymbols(LabelInfoTests.java:155) > > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native > Method) > > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) > > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) > > at java.lang.reflect.Method.invoke(Method.java:585) > > at junit.framework.TestCase.runTest(TestCase.java:154) > > at junit.framework.TestCase.runBare(TestCase.java:127) > > at junit.framework.TestResult > $1.protect(TestResult.java:106) > > at > junit.framework.TestResult.runProtected(TestResult.java:124) > > at junit.framework.TestResult.run(TestResult.java:109) > > at junit.framework.TestCase.run(TestCase.java:118) > > at > junit.framework.TestSuite.runTest(TestSuite.java:208) > > at junit.framework.TestSuite.run(TestSuite.java:203) > > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native > Method) > > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) > > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) > > at java.lang.reflect.Method.invoke(Method.java:585) > > at > org.apache.maven.surefire.junit.JUnitTestSet.execute(JUnitTestSet.java:213) > > at > org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(AbstractDirectoryTestSuite.java:138) > > at > org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(AbstractDirectoryTestSuite.java:125) > > at > org.apache.maven.surefire.Surefire.run(Surefire.java:132) > > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native > Method) > > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) > > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) > > at java.lang.reflect.Method.invoke(Method.java:585) > > at > org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(SurefireBooter.java:290) > > at > org.apache.maven.surefire.booter.SurefireBooter.run(SurefireBooter.java:198) > > at > org.apache.maven.plugin.surefire.SurefirePlugin.execute(SurefirePlugin.java:398) > > at > org.apache.maven.plugin.DefaultPluginManager.executeMojo(DefaultPluginManager.java:443) > > at > org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:539) > > at > org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalWithLifecycle(DefaultLifecycleExecutor.java:480) > > at > org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoal(DefaultLifecycleExecutor.java:459) > > at > org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalAndHandleFailures(DefaultLifecycleExecutor.java:311) > > at > org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeTaskSegments(DefaultLifecycleExecutor.java:278) > > at > org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLifecycleExecutor.java:143) > > at > org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:334) > > at > org.apache.maven.DefaultMaven.execute(DefaultMaven.java:125) > > at > org.apache.maven.cli.MavenCli.main(MavenCli.java:272) > > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native > Method) > > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) > > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) > > at java.lang.reflect.Method.invoke(Method.java:585) > > at > org.codehaus.classworlds.Launcher.launchEnhanced(Launcher.java:315) > > at > org.codehaus.classworlds.Launcher.launch(Launcher.java:255) > > at > org.codehaus.classworlds.Launcher.mainWithExitCode(Launcher.java:430) > > at > org.codehaus.classworlds.Launcher.main(Launcher.java:375) > > > > > > 2 tests with ‘a’ but now the method getMnemonic will return ‘A’ > > > > Thanks > > > > Benoit > > > > No virus found in this outgoing message. > Checked by AVG Free Edition. > Version: 7.5.476 / Virus Database: 269.10.2/893 - Release Date: > 09/07/2007 17:22 > > > ------------------------------------------------------------------------- > This SF.net email is sponsored by DB2 Express > Download DB2 Express C - the FREE version of DB2 express and take > control of your XML. No limits. Just data. Click to get it now. > http://sourceforge.net/powerbar/db2/ > _______________________________________________ Springframework-rcp-dev mailing list Spr...@li... https://lists.sourceforge.net/lists/listinfo/springframework-rcp-dev **** DISCLAIMER **** http://www.schaubroeck.be/maildisclaimer.htm |