Re: [Springframework-rcp-dev] StatusBar a concrete class...

[Jan H. <jh...@sc...>]

Hmm,

As far as my eclipse search shows me, the StatusBar is only used
internally by the StatusBarCommandGroup. The implementation of StatusBar
is quite specific. I don't think we need interfacing at that level
because it's actually the StatusBarCommandGroup that takes care of this.
You can create your own CustomStatusBar without extending the Status Bar
and then extend the StatusBarCommandGroup by overriding all methods and
delegating to your own CustomStatusBar.

Then again, at that point (the StatusBarCommandGroup) it might be
feasible/preferable to have an interface but I don't know how tight the
specific StatusBarCommandGroup is coupled in the rcp-code.

Kind Regards,
Jan

On Fri, 2007-07-06 at 17:55 +0100, Benoit Xhenseval wrote:
> Hi
> 
> I'm trying to change the StatusBar to split it to have a section for
> scrolling messages. I'm a bit surprised that quite a few interfaces
> are using StatusBar which is a concrete class.
> 
> 
> 
> Should I use only the StatusBarCommandGroup???
> 
> 
> At the moment, my approach is to have:
> - my lifecycleAdvisor to override getStatusBarCommandGroup()
> - returning a StatusBarCommandGroup that overrides createStatusBar()
> (but requires a StatusBar itself!!! so I must extends that class even
> if I do not intend to use it...
> 
> Is my approach ok?
> 
> 
> 
> However this seems extension of the StatusBar seems to cause some
> issue, the initialize method on StatusBar is called which then creates
> items in the JPanel…
> 
> 
> Could the StatusBar be refactored to be an interface?
> 
>  
> 
> I’m willing to provide a patch if you’re ok with this:
> 
> Interface StatusBar {
> 
>     ProgressMonitor getProgressMonitor() 
> 
>     void setMessage(String message) 
> 
>     void setMessage(ImageIcon icon, String message) 
> 
>     void setErrorMessage(String message) 
> 
>     void setErrorMessage(ImageIcon icon, String message) 
> 
>     void setVisible(boolean visible)
> 
> }
> 
>  
> 
> Let me know, we’re a bit stuck at the moment…
> 
> 
> Thanks!
> 
> Benoit
> 
> 
> 
> No virus found in this outgoing message.
> Checked by AVG Free Edition.
> Version: 7.5.476 / Virus Database: 269.10.1/888 - Release Date:
> 06/07/2007 06:36
> 
> 
> -------------------------------------------------------------------------
> This SF.net email is sponsored by DB2 Express
> Download DB2 Express C - the FREE version of DB2 express and take
> control of your XML. No limits. Just data. Click to get it now.
> http://sourceforge.net/powerbar/db2/
> _______________________________________________ Springframework-rcp-dev mailing list Spr...@li... https://lists.sourceforge.net/lists/listinfo/springframework-rcp-dev


 **** DISCLAIMER ****
 http://www.schaubroeck.be/maildisclaimer.htm