#1 Needed changes in SpringRCP classes
Hello everybody,
I'm currently working with SpringRCP in project EL4J
(http://el4j.sf.net) and I had problems with some
classes, because they hide methods that should not be
hidden and do not have a default constructor and so on.
Here are the details for the appended files:
---+ AbstractApplicationPage.java
* Had only a constructor with parameters that can
not be set twice.
---+ PageLayoutBuilder.java
* I've added method "public void addView(String
viewDescriptorId, Object positionArgument)" to be able
to place a view somehow.
---+ ApplicationLauncher.java
* The splash screen was displayed too late, because
startup- and root-application-context has been started
at the time.
Here are further changes that should be made:
* Add a default constructor where it is possible and
implement interface InitializingBean.
* If these classes would implement interface
BeanNameAware it would be very easy to locate
misconfigurations (e.g. if you have multiple views
configured).
* Don't hide setter or getter methods if it is not
really necessary, e.g. see method "setId" of class
"AbstractForm".
* In method "createPage" of class
"DefaultApplicationWindow" don't lookup a
"DefaultApplicationPage".
I hope my explanations are clear, else just ask.
Comments are welcome too.
Best regards,
Martin
Patched classes - 20/12/2005
Logged In: NO
Request moved to JIRA of SpringRCP. See
http://opensource2.atlassian.com/projects/spring/browse/RCP-261