Re: [spi-devel-general] Re: SPI

[Greg KH <gr...@kr...>]

On Tue, Nov 29, 2005 at 08:14:05AM +0300, Vitaly Wool wrote:
> Hi David,
> 
> there're a few things I still dislike in your core. Namely,
> 
> - leaving too much for the controller driver. I am sure that the core 
> should provide default techniques for queue handling, it's a common 
> thing to do
> - you call wait_for_completion() in the core and leave the complete() 
> call fot the controller driver. This is IMHO a good way to produce 
> erroneous code
> 
> I also think that callbacks for retrieving next message from queue is 
> better way to do it.
> 
> Greg, BTW, can you please share the review results?

What "review results"?  I just got back from vacation...

thanks,

greg k-h