Re: [spi-devel-general] Re: SPI

[Vitaly W. <vw...@ru...>]

Hi David,

there're a few things I still dislike in your core. Namely,

- leaving too much for the controller driver. I am sure that the core 
should provide default techniques for queue handling, it's a common 
thing to do
- you call wait_for_completion() in the core and leave the complete() 
call fot the controller driver. This is IMHO a good way to produce 
erroneous code

I also think that callbacks for retrieving next message from queue is 
better way to do it.

Greg, BTW, can you please share the review results?

Best regards,
   Vitaly

David Brownell wrote:

>On Wednesday 23 November 2005 2:01 pm, David Brownell wrote:
>  
>
>>On Friday 11 November 2005 1:32 am, dmitry pervushin wrote:
>>    
>>
>>>This is an updated version of SPI framework from me, Dmitry Pervushin.
>>>It seems that now it is good time to consolidate our SPI frameworks to
>>>push it to kernel :)
>>>      
>>>
>>Agreed.
>>    
>>
>
>And I see Andrew merged my framework into MM, and that it's already
>gotten some patches.  I think that means the next MM kernel (rc2-mm2?)
>will be a good base for that consolidation.  (Dunno about 2.6.16...)
>
>
>What this suggests to me is that there may need to be a few more
>patches on the way.  Drivers, especially ... but also a few in the
>framework itself. I fully expect someone to want:
>
>  
>
>> - Yours has a "struct spi_driver", mine doesn't.  It's probably
>>   inevitable, though not currently needed.  Likewise mine has
>>   the struct driver.suspend() and resume() changes, yours doesn't.
>>    
>>
>
>That's in the "best done early" category.
>
>
>Sometime after Stephen posts his updated pxa2xx_spi driver, I'll
>be able to post the Lubbock board-specific patch ... that'll mean
>one "reference" board (albeit an old one) has out-of-the-box support
>on Linux.  Given the number of PXA25x systems with an ADS7846, I'd
>hope to see some testers of that stack (and, surely, bugfixes).
>
>One of the things that would IMO help here is getting a bitbanging
>adapter driver:  rub four GPIO pins together, make a fire.  ;)
>
>If anyone's at work on such a thing (Mark?) please drop a line;
>it looks to me like this should be very simple, and incidentally
>help nail down any semantics that aren't described in the docs.
>
>- Dave
>
>
>
>-------------------------------------------------------
>This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
>for problems?  Stop!  Download the new AJAX search engine that makes
>searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
>http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
>_______________________________________________
>spi-devel-general mailing list
>spi...@li...
>https://lists.sourceforge.net/lists/listinfo/spi-devel-general
>
>
>  
>