[spi-devel-general] Re: SPI

[Eric P. <Eri...@tr...>]

09/26/2005 01:12 PM, dmitry pervushin wrote/a =C3=A9crit:
> Hello guys,
>=20
> I am attaching the next incarnation of SPI core; feel free to comment i=
t.
Hello,

Very little comments...


> Index: linux-2.6.10/drivers/spi/Kconfig
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- /dev/null
> +++ linux-2.6.10/drivers/spi/Kconfig
> @@ -0,0 +1,33 @@
> +#
> +# SPI device configuration
> +#
> +menu "SPI support"
> +
> +config SPI
> +	default Y
> +	tristate "SPI support"
> +        default false
> +	help
> +	  Say Y if you need to enable SPI support on your kernel
SPI is far from being well know, please put more help. At least define=20
SPI as "Serial Peripheral Interface" and suggest the user to have a look=20
at Documentation/spi.txt . IMHO, it's also convenient if you give the=20
name of the module that will be created (spi?).


> Index: linux-2.6.10/Documentation/spi.txt
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- /dev/null
> +++ linux-2.6.10/Documentation/spi.txt
:
:
> +
> +1. What is SPI ?
> +----------------
> +SPI stands for "Serial Peripheral Interface", a full-duplex synchronou=
s=20
> +serial interface for connecting low-/medium-bandwidth external devices=
=20
> +using four wires. SPI devices communicate using a master/slave relatio=
n-
> +ship over two data lines and two control lines:
> +- Master Out Slave In (MOSI): supplies the output data from the master=
=20
> +  to the inputs of the slaves;
> +- Master In Slave Out (MISO): supplies the output data from a slave to=
=20
> +  the input of the master. It is important to note that there can be n=
o=20
> +  more than one slave that is transmitting data during any particular=20
> +  transfer;
> +- Serial Clock (SCLK): a control line driven by the master, regulating=
=20
> +  the flow of data bits;
> +- Slave Select (SS): a control line that allows slaves to be turned on=
=20
> +  and off with  hardware control.
> +More information is also available at http://en.wikipedia.org/wiki/Ser=
ial_Peripheral_Interface/ .
Broken link, it is=20
http://en.wikipedia.org/wiki/Serial_Peripheral_Interface (no trailing /)


Cheers,
Eric