#8 commitcheck.sh: problem with ! operator

[Bernd Goetz]

The HEAD version of commitcheck.sh:

----------------------- start HEAD version

#! /bin/sh
#
# Make sure the various tests for a successful commit
pass.
#

ENABLE_ACLS=yes

#
# Does the committer have access to the repository?
#
if test "x-$ENABLE_ACLS" = "x-yes" ; then
if ! $CVSROOT/CVSROOT/cvs_acls.pl ${1+"$@"} ; then
exit 1
fi
fi

#
# Tests pass, make the patch ready to commit and
report.
#
if ! $CVSROOT/CVSROOT/commit_prep.pl ${1+"$@"}; then
exit 2
fi

exit 0

----------------------- end HEAD version

Went back to older version of commitcheck.sh:

--------------- start older version

#! /bin/sh

if $CVSROOT/CVSROOT/cvs_acls.pl ${1+"$@"}; then
if $CVSROOT/CVSROOT/commit_prep.pl ${1+"$@"}; then
exit 0
fi
fi

exit 1

---------------- end older version

[Bryan Davis]

Logged In: YES
user_id=588890

I made these changes to work on Solaris:

#! /bin/sh
#
#
Make sure the various tests for a successful commit
pass.
#

ENABLE_ACLS=@ENABLE_ACLS@

#
#
Does the committer have access to the repository?
#
if [ "x-
$ENABLE_ACLS" = "x-yes" ]; then

$CVSROOT/CVSROOT/cvs_acls.pl ${1+"$@"} || exit
1
fi

#
# Tests pass, make the patch ready to commit
and report.
#
$CVSROOT/CVSROOT/commit_prep.pl
${1+"$@"} || exit 2

exit 0

[Ken Coar]

Logged In: YES
user_id=100718

Can you re-submit this is the form of a unified diff? (I.e., 'diff -u'.)
Otherwise, trying to figure out what changed, with SourceForge inserting
line wraps, is very difficult.

[Bryan Davis]

Logged In: YES
user_id=588890

I uploaded the changes as a udiff in patch #593304. Hope this helps.
The spackle package is great stuff.