Menu

Git Merge Request #1: Several improvements and bug fixes. (merged)

Merging...

Merged

Something went wrong. Please, merge manually

Checking if merge is possible...

Something went wrong. Please, merge manually

Giulio Paci wants to merge 3 commits from /u/giuliopaci/sp-tk/ to master, 2021-08-24

Hi all,
I am opening this merge request to submit several changes that I have maintained over the years.

Changes to autoconf/automake files have been done to improve their reliabilities.
With the above changes, it is now possible to compile SPTK by:

autoreconf -is
mkdir build
cd build
../configure --prefix=$(pwd)/install
make -j
make -j install

Without polluting the source tree.

Some changes are there to fix:
- Compilation with GCC 10
- Errors reported by cppcheck
- Mispellings

I have added also a few new behaviors:
- 2 new commands (nacorr, str) from my former colleague Fabio Tesser, which we needed for speech synthesis;
- pitch command: we introduced a new output, which we also needed for speech synthesis;
- getfp() function: we implemented basic support for stdin/stdout so that we can avoid temporary files in some of our scripts;
- rawtowav: minimal support for -h flag (to avoid printing the error line if this flag is provided)

Please consider merging this request.
If you prefer to have separate requests for different features, please let me know.

Once this merge request is applied, several files becomes obsolete and can be removed. If you want, I can take care of those as well in a separate merge request.

Cheers

Commit Date  
[33e669] (HEADmaster) by Giulio Paci Giulio Paci

Fix errors detected by cppcheck.

2021-01-16 21:57:42 Tree
[55e921] by Giulio Paci Giulio Paci

Improve wording in error message.

2021-08-24 10:15:33 Tree
[38fc7f] by Giulio Paci Giulio Paci

Fix spelling errors.

2021-01-16 21:58:17 Tree

Discussion

  • Giulio Paci

    Giulio Paci - 2021-08-24

    Hi Mizuki,
    I have updated the PR according to your request (I assumed your comment "except gmm.c and lmadf.c" only applied to commit ed9d54. I added a new commit since I noticed that one of the error messages did not sound well, even after correction of the spelling error.

    Best regards,
    Giulio

     
  • Giulio Paci

    Giulio Paci - 2021-08-24

    I also agree to transfer the copyright of my changes to the SPTK team.

     
  • Takenori Yoshimura

    • Status: open --> merged
     
  • Takenori Yoshimura

    Thank you for your kind response. Your request has been merged. Sorry for our late reply.

    Regards,
    Takenori

     

Log in to post a comment.

Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.