|This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110897/|
Yes for (1), no for (2). And maybe no for (1). Ideally (1) should be fixed by qDebug not printing these messages when Soprano is compiled in release mode or something like that. I remember reading a bug report about this on bugs.kde.org by Thiago. Maybe you should take a look at that. Otherwise commit (1), I guess. I'm really not too fond of the ErrorCache's design because doing this hash lookup is not especially cheap, specially when it is done all over. That being said, it makes sense in the way it is being used in Soprano. Lets take the example of the Soprano::Model - Two different threads can access two member functions of the same model and can return errors. Thread 1 - Soprano::Model::executeQuery( Query1 ); Thread 2 - Soprano::Model::executeQuery( Query2 ); Thread 1 will want to check the errors, and so will thread 2, if both of these operations are happening somewhere around the same time, Thread1 could get Thread2's error and vice versa. That being said - we need to find a way that the QHash does not just keep growing. I'm open to suggestions. PS: Nice work with your patches!
On June 8th, 2013, 7:03 p.m. UTC, Simeon Bird wrote:
Review request for Soprano and Vishesh Handa.
By Simeon Bird.
Updated June 8, 2013, 7:03 p.m.