Menu

#40 File descriptor never closed in 3.4.8

Solid-3.4
open
Core (22)
7
2009-07-27
2009-06-26
Storm
No

In file confparse.c, function initconf(char*) opens a file (line 655). However, I can't manage to find where it is closed.

If I'm right, that can be a problem, since this function is called on SIGHUP, and the configfile is never closed.

Discussion

  • Juan Baez

    Juan Baez - 2009-06-26

    This should not be an issue, since we never call flock() on the file, and we always open the file for reading.

    We currently run 3.4.8

    -
    Server Up 632 days, 0:29:07
    End of /STATS report.
    -

    We've rehashed quite a few times, so we should have noticed if something was not right. Either way, we should be closing the file. I'll look into it, it's been a minute now.

     
  • Juan Baez

    Juan Baez - 2009-06-26
    • assigned_to: nobody --> tux316
     
  • Juan Baez

    Juan Baez - 2009-07-27
    • priority: 5 --> 7
     

Log in to post a comment.