Re: [Soaplite-devel] SOAP::Client

[Scott W. <sc...@pe...>]

On Thu, Oct 04, 2007 at 12:44:06PM +0200, Martin Kutter wrote:
> Hi there,
> 
> around line 2250 in SOAP/Lite.pm, there's the package SOAP::Client.
> 
> 
> Are there any reasons for SOAP::Client behaving like this ? If not, I'd
> change the line to 
> 
>  my $self = ref $_[0] ? shift : shift->new();

I don't use S::C, but I agree with your assessment and solution.
> 
> This might induce subtle side effects, even though there's no effect on
> the test suite.

Without a test, the user hasn't ever had a guarantee. Perhaps you can
make a test that would trigger a fault as the code exists now, you
implement your fix, and push out a few provisional releases so some
S::C users could try it out for you.

Scott
-- 
Scott Wiersdorf
<sc...@pe...>