[Soaplite-commit] SF.net SVN: soaplite: [214] trunk

[<kut...@us...>]

Revision: 214
          http://soaplite.svn.sourceforge.net/soaplite/?rev=214&view=rev
Author:   kutterma
Date:     2008-03-15 14:04:01 -0700 (Sat, 15 Mar 2008)

Log Message:
-----------
- updated some use dependencies
- removed this code from SOAP::Serializer and added test

    foreach my $this_ns (keys %{$self->{'_namespaces'}}) {
        return $self->{'_namespaces'}->{$this_ns} if ($ns eq $this_ns);
    }

I just don't understand why this isn't written as 

   return exists ($self->{'_namespaces'}->{$ns})
       ? $self->{'_namespaces'}->{$ns}
       : ()

Fear of algorithm complexity attacks on hash keys? Why would one want to implement exists by iterating over the list of keys? I don't know, but now it should be a magnitude faster or so ;-)

Modified Paths:
--------------
    trunk/lib/SOAP/Lite/Custom/XML/Deserializer.pm
    trunk/lib/SOAP/Lite/Deserializer.pm
    trunk/lib/SOAP/Serializer.pm

Added Paths:
-----------
    trunk/t/SOAP/Serializer.t


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.